public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: dmitry.torokhov@gmail.com
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	krzk+dt@kernel.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, marex@denx.de, mingo@kernel.org,
	mwelling@ieee.org, phucduc.bui@gmail.com, robh@kernel.org,
	tglx@kernel.org
Subject: [PATCH 2/2] Input: Touchscreen: tsc200x - delegate wakeup IRQ
Date: Wed, 11 Mar 2026 10:17:35 +0700	[thread overview]
Message-ID: <20260311031735.2044-1-phucduc.bui@gmail.com> (raw)
In-Reply-To: <abC1NfUoHCHEeZpr@google.com>

Hi Dmitry,

> Sorry, but this just makes it all worse. There is no downside from
> letting the driver to control wakeup if it wants to, so I'd rather leave
> it as it was, at least for now.

Thanks you for your reply

I was thinking that the code might be simplified by removing
ts->wake_irq_enabled.

In resume(), we could just check device_may_wakeup(dev) before calling
disable_irq_wake(ts->irq). From what I can see, wake_irq_enabled is only
used there, so it seems redundant.

I don't have the hardware to test this right now, so I didn't try the
change myself.

Do you think it would make sense to remove this field?

Best regards,
Phuc

  reply	other threads:[~2026-03-11  3:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 11:00 [PATCH 0/2] Input: tsc200x: Improve wakeup source handling phucduc.bui
2026-03-09 11:00 ` [PATCH 1/2] dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source phucduc.bui
2026-03-13 23:23   ` Rob Herring
2026-03-16  2:41     ` [PATCH 1/2] dt-bindings: input: touchscreen: ti,tsc2005: Add phucduc.bui
2026-03-09 11:00 ` [PATCH 2/2] Input: Touchscreen: tsc200x - delegate wakeup IRQ management to I2C core phucduc.bui
2026-03-11  0:21   ` Dmitry Torokhov
2026-03-11  3:17     ` phucduc.bui [this message]
2026-03-16  2:44     ` phucduc.bui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311031735.2044-1-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mingo@kernel.org \
    --cc=mwelling@ieee.org \
    --cc=robh@kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox