From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D56D62D949C for ; Wed, 11 Mar 2026 03:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773199063; cv=none; b=Hi/lr9LO74zsg5lvP1KLc3O1Cye8kVenDrssjUiXU0DFimKCuuy06+jZyIJbR5P0cXwM8S5Fxm7j2UrvJZDuA02U6rhPqHIzkuFxc/0VYfSbhcP7YXNLsuFsgdt0DLgy74RW1pzAalV3HUsAdUVkAEBDr7wXC5NFJllRh34yk/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773199063; c=relaxed/simple; bh=9oo8f816zUb8gdoM9br7bk+Bv4pQ1YUHqKG/Gnd1WLI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V1FCr0Ef53SGhdRiSMrOXH/II9EZG8ZWNhpv3MmhcT8JGh8bNS/E9W3pDDVk9l/SKc2JdiRFmruQk1r3IKJHOO4crz8lIjB0sfpMt9YhFrKeXwlQ7pliR40NeWKwaaPaNFZn5QIo3kghH8PGoLyGM39fMqwqUkDNBUCPH+n3x3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nfpQZjZf; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nfpQZjZf" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c7382731edfso4598220a12.1 for ; Tue, 10 Mar 2026 20:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773199062; x=1773803862; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9oo8f816zUb8gdoM9br7bk+Bv4pQ1YUHqKG/Gnd1WLI=; b=nfpQZjZfY6X76Hb1dyvwJLVEXYQv+4MCXo1Q6Jm8SqZmQXQWUa1rVko+T5WLjqrAll cAT4rjT5d+y20Vavldb1mSyRgiqjNtNaTsN22EpX6FRf+mIWEsXfUhV3c5Uxi2s7V//x SUfj56KVE/+VaYsvbX77PzzQZwMZCXl1w4BUs0YGyC+UEPrqp5blAeELCt/Mfc1xuKIr l2l6HPl3ACm8sAdW8JqHXdkwiZpda6LUyDiSb/HQrQgsitKhSNpqZssfkNUKosNg89tT nHDBs+qIWQw0bOw1UHGYUxjDp4au9Vujcamkc4jXQ0oqs9bRQSK628P9e189Q5UDrbJg ptYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199062; x=1773803862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9oo8f816zUb8gdoM9br7bk+Bv4pQ1YUHqKG/Gnd1WLI=; b=ILrn4R1MElquWTZuq4iyIET4ewGAIkuH+CfIM17JEZ8mWFOIY5tMhGi75JjaogDtO5 jX23SxUSQp8jj8f0rdSlvwpw15+SYHSlsShi58xA60MopDnc1f7L4gDC6Bo5DV1uFC+c JgzcNCAxVqk/axbOQ/BuQRPLhQzv5gmHNrzkER1+CO59vz1u0VSZ1CbEu04hFxGIOs2g EbCiQ4VIhuKE2ei6UcgZA//1kqSffFu7DToRIyFfQJ1DoRdefgWHngxq9w0IpCBlm7Jc oaojSQUW1oTyCRw9hAZ24tdlBqc4ZjnDmniI75Yue0iKTAVs1GKCbljACcIgstIZ3tiS Fzdw== X-Forwarded-Encrypted: i=1; AJvYcCU5ZLWhY/m5twoiRTID6CQkRQag6Bj9DOcmP6eBZDOG7ZAlQ1coOb2szVq9b4yYM6GjXJcvurq4wxI3bq4=@vger.kernel.org X-Gm-Message-State: AOJu0YzsuTb2hupco78ffl6QR30LhbluLYt0mrRGNpqIG0vtxDS+gjD0 utYJzZCjG/PIsbmZQ2oEpir7Ng6nf2rCRazA7Hdi6rlSeb83DcQdcQrd X-Gm-Gg: ATEYQzz+kzVw/O2MqZ9atdgyP+EH49HcuK7cC7MWeCGpCJRa5w1K99Pf7VJJcXG8lMF ooGcjEqz38c8ubltJ9XVGxBc8iNrf0AZKXq5muFhsQmUAkB3XTErrYJXKmXv156n8OCHz3DRRtN yYIzB+ShgHUejs+8rJryE+NoPUtPlP+v7PSMuJR/gAr+RK7cp5zu+eoSBKTrzC8Iz3qfuP19S49 OwxcZyakvnMnByTdEHIfIUWVKdtHh6xO6c4czuLy7CZ8NDdc5BEkatsMQ+W+ERwnWVBRNTX+fKe o74DmfwWz0DGfOTZtHcl3aAcaZN0TC/pqGaimy6GJZP4K3sVm0d4c9sfs+elK7X7vUnvs9FI8JB TTS9DUi3hZfBGWEGw6ZhhTKnR0HmNr9XdcVlgAdt45983v9vXiZMkpXeYnIoTJvSQOHLaWTG5Tz O769MBkUYH0SDsOEvz3tdSO/GaBpGNy9zRbLwVFFpaBcm69VZnEddP3N9eh+3bPNHtWHd7NOPu6 j0aIA== X-Received: by 2002:a05:6a20:938a:b0:398:6461:6888 with SMTP id adf61e73a8af0-398c615d5f8mr835628637.60.1773199062154; Tue, 10 Mar 2026 20:17:42 -0700 (PDT) Received: from localhost.localdomain ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829f6df3417sm711651b3a.19.2026.03.10.20.17.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 10 Mar 2026 20:17:41 -0700 (PDT) From: phucduc.bui@gmail.com To: dmitry.torokhov@gmail.com Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, krzk+dt@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, marex@denx.de, mingo@kernel.org, mwelling@ieee.org, phucduc.bui@gmail.com, robh@kernel.org, tglx@kernel.org Subject: [PATCH 2/2] Input: Touchscreen: tsc200x - delegate wakeup IRQ Date: Wed, 11 Mar 2026 10:17:35 +0700 Message-Id: <20260311031735.2044-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Dmitry, > Sorry, but this just makes it all worse. There is no downside from > letting the driver to control wakeup if it wants to, so I'd rather leave > it as it was, at least for now. Thanks you for your reply I was thinking that the code might be simplified by removing ts->wake_irq_enabled. In resume(), we could just check device_may_wakeup(dev) before calling disable_irq_wake(ts->irq). From what I can see, wake_irq_enabled is only used there, so it seems redundant. I don't have the hardware to test this right now, so I didn't try the change myself. Do you think it would make sense to remove this field? Best regards, Phuc