* [PATCH] Input: mpr121: Drop redundant wakeup handling
@ 2026-03-09 7:14 phucduc.bui
2026-03-11 0:06 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: phucduc.bui @ 2026-03-09 7:14 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: phucduc.bui, linux-input, linux-kernel
From: bui duc phuc <phucduc.bui@gmail.com>
The driver currently calls device_init_wakeup() and manually toggles
IRQ wake in suspend and resume paths. This is unnecessary since the
I2C core already handles wakeup configuration when the device is
described in Device Tree with the "wakeup-source" property.
Note: Compile-tested only, not verified on hardware.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/input/keyboard/mpr121_touchkey.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/input/keyboard/mpr121_touchkey.c b/drivers/input/keyboard/mpr121_touchkey.c
index bd1a944ded46..47edc161ec77 100644
--- a/drivers/input/keyboard/mpr121_touchkey.c
+++ b/drivers/input/keyboard/mpr121_touchkey.c
@@ -295,8 +295,6 @@ static int mpr_touchkey_probe(struct i2c_client *client)
return error;
i2c_set_clientdata(client, mpr121);
- device_init_wakeup(dev,
- device_property_read_bool(dev, "wakeup-source"));
return 0;
}
@@ -305,9 +303,6 @@ static int mpr_suspend(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
- if (device_may_wakeup(&client->dev))
- enable_irq_wake(client->irq);
-
i2c_smbus_write_byte_data(client, ELECTRODE_CONF_ADDR, 0x00);
return 0;
@@ -318,9 +313,6 @@ static int mpr_resume(struct device *dev)
struct i2c_client *client = to_i2c_client(dev);
struct mpr121_touchkey *mpr121 = i2c_get_clientdata(client);
- if (device_may_wakeup(&client->dev))
- disable_irq_wake(client->irq);
-
i2c_smbus_write_byte_data(client, ELECTRODE_CONF_ADDR,
mpr121->keycount);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: mpr121: Drop redundant wakeup handling
2026-03-09 7:14 [PATCH] Input: mpr121: Drop redundant wakeup handling phucduc.bui
@ 2026-03-11 0:06 ` Dmitry Torokhov
2026-03-11 4:28 ` [PATCH v4 1/2] dt-bindings: input: touchscreen: phucduc.bui
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2026-03-11 0:06 UTC (permalink / raw)
To: phucduc.bui; +Cc: linux-input, linux-kernel
On Mon, Mar 09, 2026 at 02:14:13PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The driver currently calls device_init_wakeup() and manually toggles
> IRQ wake in suspend and resume paths. This is unnecessary since the
> I2C core already handles wakeup configuration when the device is
> described in Device Tree with the "wakeup-source" property.
>
> Note: Compile-tested only, not verified on hardware.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: input: touchscreen:
2026-03-10 23:35 [PATCH v4 1/2] dt-bindings: input: touchscreen: sitronix,st1232: Add wakeup-source Dmitry Torokhov
@ 2026-03-11 4:25 ` phucduc.bui
0 siblings, 0 replies; 4+ messages in thread
From: phucduc.bui @ 2026-03-11 4:25 UTC (permalink / raw)
To: dmitry.torokhov
Cc: conor+dt, devicetree, geert+renesas, hechtb, javier.carrasco,
jeff, krzk+dt, krzk, krzysztof.kozlowski, linux-input,
linux-kernel, linux-renesas-soc, magnus.damm, phucduc.bui, robh,
wsa+renesas
Hi Dmitry,
Thank you for applying the patch.
Best regards,
Phuc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: input: touchscreen:
2026-03-11 0:06 ` Dmitry Torokhov
@ 2026-03-11 4:28 ` phucduc.bui
0 siblings, 0 replies; 4+ messages in thread
From: phucduc.bui @ 2026-03-11 4:28 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, phucduc.bui
Hi Dmitry,
Thank you for applying the patch.
Best regards,
Phuc
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-11 4:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-09 7:14 [PATCH] Input: mpr121: Drop redundant wakeup handling phucduc.bui
2026-03-11 0:06 ` Dmitry Torokhov
2026-03-11 4:28 ` [PATCH v4 1/2] dt-bindings: input: touchscreen: phucduc.bui
-- strict thread matches above, loose matches on Subject: below --
2026-03-10 23:35 [PATCH v4 1/2] dt-bindings: input: touchscreen: sitronix,st1232: Add wakeup-source Dmitry Torokhov
2026-03-11 4:25 ` [PATCH v4 1/2] dt-bindings: input: touchscreen: phucduc.bui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox