From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 746CE31A045 for ; Wed, 11 Mar 2026 08:24:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773217443; cv=none; b=g/s13OGADMdF6bJ0ygH27X8Ma6qDbuOzHsrjZzDik9FFqZ/+PfUEYMRVqVLZ59VEdFdXHpZYnGndGKDnPq2zxZzAF1a3RjjC1IoNVC4qnCjws7ZL/A0/kke99JykE0a2/yR3sB7rrlCcY6QmQ91SSY/IaInU6Xcy2XKOvWpLWIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773217443; c=relaxed/simple; bh=44Z0qRUXUhsuCSzCi6hLN3itEzTgPOqA9Np28eT5kcI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W+mx9Dbzi+WgyHXo4wL5Nj925gRZKUyteyfBQBXVHVdAWs4i4TOZijFgvEwCxy9ooUvJH5JkygQna6F/feoaSrpyqTkFaxYNziYp7qcRlZ+iAZb4VWq55bE3DGcgcMVvofygab4Vq6zBsY0S4FhQ3ZDnLzmKsW8h9lA13B43H08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IFVYBQdi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IFVYBQdi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14A36C4CEF7; Wed, 11 Mar 2026 08:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773217443; bh=44Z0qRUXUhsuCSzCi6hLN3itEzTgPOqA9Np28eT5kcI=; h=From:To:Cc:Subject:Date:From; b=IFVYBQdiL6iFyB5UwOOskqh4Py8xsXxxHJu1wM27eJJsJM6eNATMmpzuACf1FIWu1 SAVFvcazvtj2oACoeMOeTJA9LTsDYIKpaqSNl0yV0nJX3JPXT2AmUpRQ5GmITQ/jjp 7iFc6j6zEHvXqR8KyU/QUx+PaWQl6OhBHozID2P6b99p2MKOnqYJpDmH97/DauRl1x b6p608lwCl+tare/neSzV3q/PVQsP3oTJ0xJ+wtWQZ/Fh18u67GdYGwMLWy0D3W7sa KUlV+krNxRUUIaFdZ7Y7YxmsSL2BT1m7EJCMdRpbovsDAEmOy4zXZ9SfAjK+9hfBSb 3wXEKkVluCMaA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1w0ErI-000000004Hm-1qgc; Wed, 11 Mar 2026 09:24:00 +0100 From: Johan Hovold To: Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] greybus: es2: drop redundant device reference Date: Wed, 11 Mar 2026 09:22:26 +0100 Message-ID: <20260311082226.14865-1-johan@kernel.org> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- This one needs one more spin... Sorry about the mess up. Johan Changes in v3: - drop the leftover usb_dev_put() in early error paths Changes in v2: - drop temporary udev variable as reported by the kernel test robot (W=1 warning) drivers/greybus/es2.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c index 6ae0ac828afa..75b889fa21b4 100644 --- a/drivers/greybus/es2.c +++ b/drivers/greybus/es2.c @@ -772,7 +772,6 @@ static int check_urb_status(struct urb *urb) static void es2_destroy(struct es2_ap_dev *es2) { - struct usb_device *udev; struct urb *urb; int i; @@ -804,10 +803,7 @@ static void es2_destroy(struct es2_ap_dev *es2) gb_hd_cport_release_reserved(es2->hd, ES2_CPORT_CDSI1); gb_hd_cport_release_reserved(es2->hd, ES2_CPORT_CDSI0); - udev = es2->usb_dev; gb_hd_put(es2->hd); - - usb_put_dev(udev); } static void cport_in_callback(struct urb *urb) @@ -1257,11 +1253,10 @@ static int ap_probe(struct usb_interface *interface, bool bulk_in_found = false; bool arpc_in_found = false; - udev = usb_get_dev(interface_to_usbdev(interface)); + udev = interface_to_usbdev(interface); num_cports = apb_get_cport_count(udev); if (num_cports < 0) { - usb_put_dev(udev); dev_err(&udev->dev, "Cannot retrieve CPort count: %d\n", num_cports); return num_cports; @@ -1269,10 +1264,8 @@ static int ap_probe(struct usb_interface *interface, hd = gb_hd_create(&es2_driver, &udev->dev, ES2_GBUF_MSG_SIZE_MAX, num_cports); - if (IS_ERR(hd)) { - usb_put_dev(udev); + if (IS_ERR(hd)) return PTR_ERR(hd); - } es2 = hd_to_es2(hd); es2->hd = hd; -- 2.52.0