From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AFF832BF41 for ; Wed, 11 Mar 2026 09:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773222849; cv=none; b=oa6SymVquKXKQyjFYlnen35d1jNbTggaALBA32XOLwynnplPpbG14k3qieW85RCFpKhxiDPPuNJIwvHpssvQi4tOi80iNOWvf6WyLhfiK8YkPUdpi4nz12jsrUQnAXj9tyqpJznkyEFklinQChTC/9+ocmM35NznDlKmPt5YaK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773222849; c=relaxed/simple; bh=AmJzAwkpGNcbesSQbn3M5nVXXEHJl1Kd7Y1uVDI5uu0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JPfYUf1yeSMG4z7f+V49aURpsm8OzHAmlIc7bcckaP4WZx78gWCnxTceUp2qJKw5tZcprFie1Ugal8nI077e1CEm+Njzn1vDdO2QBWB1lgXUcmvFy6lF1G9XCMHxmCCLb1ymiR57P1NpCV+vLdbaalO93tfvDci8tcg9/QcxrBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AKLetuOT; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AKLetuOT" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so5318139f8f.3 for ; Wed, 11 Mar 2026 02:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773222846; x=1773827646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Aw5gX3EdSpWwdEcJs/5ar7LileEwolaW97u1s2g+7SM=; b=AKLetuOTqnh4za40nbNK16XFxarXK3qmtnpvbQh4nfBFmGm5ZeF04UpLII6F2REYGH +UUctpA7jQ1DidixRMbrPnXGKp0jaQ/AHBp4fyBM2gcyaG4GCfopUs2LrzjiTm9ePEUR 0CGFBYBbCuR241YcNMniV0/mrumfdwWvwT9dDvteQpsuJ+IMaKV1ZJh09CYWHh7ERA+q 68KNjXwHP09VquIfebcNXdfKtBdVvxTVLPShsMc1YIHJRp1A2jgAdWrO4v3jJcXXOfI3 dYL52phqg0ZGN+tcdvmOh2v4+lSapvUPgUpQFEwaIaVpAR8VXQSub3XBU8Ulh+qU4e8G l55w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773222846; x=1773827646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Aw5gX3EdSpWwdEcJs/5ar7LileEwolaW97u1s2g+7SM=; b=WhSJSW/636maue0qtnuhVp3gEaXuQnhRiH6XgLIgsUjow5Os06dN72O4TdotW636wC VQJM2O7r5fBZ7Kh7D2xjECAymvTTkvKqhYPkh11P+aVeFl8QMRJms7lczjPgwtXCMWbX nTxzOwu9faWVRLo3R6uc+bVCaYb6xHsWXJZ7l4HNOe7DZ7wuzLRNNKFs3dyLLh4DxAYO t6usmLay+CqYPDNnHjeByKxmBFYiUm6uVOt8JLTnU5Wa5EpyL4lXsit9+6kqu+CJI+jX QpOljhDDm1oAWTGRmj0nIHm7fvt/z3zz+XB58+Bf4Yup9E04Uvft0xZZuFiesCK1zLRs ONzw== X-Forwarded-Encrypted: i=1; AJvYcCVZZ3v2JsNcMT/45hIaqD8VGYWHx3AlS+qZWgKyezdgl9nz4RzgvzoaHaeSjgud/IyGLC9nut6KO6Y7FOY=@vger.kernel.org X-Gm-Message-State: AOJu0YwTzkjdzFT3YSPB8Ec6C3VQNnK5tBaO+VVWsfP4WpfIOYhQppWH kAe22CBB8SBIjDvLPp5iIz0Amf27HnnmRaDj9I2twK/GR1e9sI61F3ss X-Gm-Gg: ATEYQzy49mIjDsRtCiS+oKi21JlYIhEHQBLZUbSYgXOk+ZesA/cdPBKO+nIGPLJiPHf 4hibiqaxaepI+Df7WLEB92iJyK7M9IH87AxrlV3rBauOMzVf4ObJok8bAiWH4k2K/YQlEqHD3v5 xflp3M3l/pCBocu2eDJ1nqwrLTLRs6CZI5bbU8C1JDLSzfaSntfAr6A6z/4MMnNa9ueaCx9aeWE QNNpwJYLnzWoGLqG002XXr395NTvgMFFz1duKVy9hNLSf0CBGFtfN6/7agczb3nUVOBU/RKSz/z RJoSl1jBtDMOLFR0psGRxgOecTI8fG4UeTmt5IePLDb1D2Wcap1yBjd14/qlQSk40iCqG51tkNg eKKNyCeI8vX67zcArONofvadosUvDIH6IMx/Yp0s6nVkyymJSMnNKakK4sxoX36Xom8I0wGM1sU woXF0MRpyV00oDbZwXPNTBEf7OjR82V5eUK71ECsvUV6kvXvlC/jeemaaGRg== X-Received: by 2002:a05:6000:40dc:b0:439:d750:42f6 with SMTP id ffacd0b85a97d-439f82050c4mr3857148f8f.24.1773222846480; Wed, 11 Mar 2026 02:54:06 -0700 (PDT) Received: from db07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439f818d61esm5693608f8f.8.2026.03.11.02.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 02:54:06 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: andriy.shevchenko@intel.com Cc: 0rayn.dev@gmail.com, Michael.Hennerich@analog.com, andy@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, dlechner@baylibre.com, jic23@kernel.org, krzk+dt@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, me@brighamcampbell.com, nuno.sa@analog.com, robh@kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH v2 3/5] iio: dac: ad5504: Align headers with IWYU principle Date: Wed, 11 Mar 2026 09:54:03 +0000 Message-ID: <20260311095403.9908-1-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Andy, Thank you for the detailed review across the series. > > #include > Is this still being used directly. Yes, it is still needed for `struct device` and `dev_get_platdata()`. > > #include > And what is this for? You are right, this appears to be a leftover. I will double-check its usage and drop it in v3 if it's no longer needed. > The rest of the changes looks correct, but still missing headers: > linux/kstrtox.h > > asm/byteorder.h > > Might be more. Good catch on these. I will add (for cpu_to_be16()) and . I will also do another general pass over the includes to better align with IWYU principles before sending v3. Regarding the probe function (Patch 4): I will split the `struct device *dev = &spi->dev;` refactoring into its own preparatory patch. For the scale calculation, I will restore the `-ENODEV` check to maintain ACPI compatibility, use `ARRAY_SIZE()` (adding ), validate the range array indices properly, and drop the legacy `pdata` fallback. I will include all of these fixes in v3. Best regards, Taha