public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Pascal Eberhard <pascal.eberhard@se.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] ARM: dts: r9a06g032: Add #address-cells in the GIC node
Date: Wed, 11 Mar 2026 11:21:09 +0100	[thread overview]
Message-ID: <20260311112109.061a1e4b@bootlin.com> (raw)
In-Reply-To: <CAMuHMdX01rwBMGn1FLGm-fHA0w-7+BCskMiucgxcui+PTVF7rA@mail.gmail.com>

Hi Geert,

On Wed, 11 Mar 2026 09:39:40 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Wolfram,
> 
> On Wed, 11 Mar 2026 at 09:32, Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > On Tue, Mar 03, 2026 at 11:20:29AM +0100, Herve Codina (Schneider Electric) wrote:  
> > > When checking dts involving the r9a06g032.dtsi file, the following kind
> > > of warnings are reported:
> > >    Missing property '#address-cells' in node xxx, using 0 as fallback
> > >
> > > Indeed, #address-cells is not present in the GIC interrupt controller
> > > node.
> > >
> > > Fix it adding the missing property.
> > >
> > > No functional change.
> > >
> > > Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@bootlin.com>  
> >
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > I like Krzysztof's explanation "Value '0' is correct because GIC
> > interrupt controller does not have children." Maybe it can be added to
> > the commit message?  
> 
> Some of the examples in the GIC DT bindings, do?
> But #address-cells is not a required property in the GIC DT bindings,
> so why should it be added at all?
> 
> BTW, I never understood why an interrupt-controller should have
> #address-cells (according to dtc)?

I think this comes from the interrupt-map definition:
  https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#interrupt-map

Best regards,
Hervé

  reply	other threads:[~2026-03-11 10:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 10:20 [PATCH] ARM: dts: r9a06g032: Add #address-cells in the GIC node Herve Codina (Schneider Electric)
2026-03-10 22:06 ` Wolfram Sang
2026-03-11  7:30   ` Herve Codina
2026-03-11  8:29     ` Wolfram Sang
2026-03-11  7:35   ` Krzysztof Kozlowski
2026-03-11  8:32 ` Wolfram Sang
2026-03-11  8:39   ` Geert Uytterhoeven
2026-03-11 10:21     ` Herve Codina [this message]
2026-03-24  9:17   ` Herve Codina
2026-03-24 19:13     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311112109.061a1e4b@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=pascal.eberhard@se.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox