From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D44CC30ACEE for ; Thu, 12 Mar 2026 18:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773341125; cv=none; b=jWW2iJnyoHcBh7x5HDVdKpDtILptJL03XCwSuJgP9ebjNacZL85ic9XnEwYlBJRHlUJxzC+VVaRLNlEFoyr1V5CPi6IeiggAZe6wtmahTXjSDsq5UgsYAHALyVd4P1jWCI0mP4Qm4wWvkTfiQozK3GpNh+yzJrmS2djTUYoPUnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773341125; c=relaxed/simple; bh=IGvEzpYaRLimGwvck9y9/u/ARgKxX4vdmL9hrr7TzZo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uBGvU707zcxYANp+dwQYddk6WtjgRamDa7kJEChwhfA1YwCijFJJp07iddZ/nyRsbPio46LpsNKg5MXMgybLkvcNnwd5WI4/7IaNvdu+xr8jYklr9gsCzjuFn6SsqEbx6Y8E4oLTnx/Mk8zn72S4gRG3XLpeGU1XxsxalGmzzEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dYNpDHXg; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dYNpDHXg" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-38a3c62d7d2so10354911fa.1 for ; Thu, 12 Mar 2026 11:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773341121; x=1773945921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wzAvoq4uraTzTssrO28BscOnZK0V5B4etFhaIgkco6M=; b=dYNpDHXgfa5DGP09s0c/w9gdqr2qKzM403SeakN5GQUasTEuF7qfgATRG/0DD3hvaQ dL6EKDQE59W0hpa3+a0gYGTTMTNCHb/oV16Tn4NDhamwHeW3L9gyRXXwgHUI1rM/X2Ya WMYJoGce4g2swa+7LMlp7sVj3V9sM9Lv6lk5wKgFY++igalaDfqZcGpR0J0QIhR9fR9d 84fYzpjpRUm2UDblgh5OyhU5A2clpvNhOmUkgKeeBTQJvWkYsq0fhZrMG5lOFTKJrt1t JPjvsTMELg7iRvDojamSIqIW99quCl067v1KNCgwKYd4hVjA2aR6rAI9UKg2b7stOlYV g17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773341121; x=1773945921; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wzAvoq4uraTzTssrO28BscOnZK0V5B4etFhaIgkco6M=; b=u4I21GX57YVw2KjJ0JlWAPlzzEomfxxbVipoQ4An5h+k2ZeJZtayRodtzKpeYOFRTk 0KAQyK72vqCv70jhqbpT8cE7TKwC+tBPGl7A88gab5L1o2qDLPbxPMd/UPYEHDGAIfYx UbXpsYvjIyGZVeFHzuC56vcVkO/9QOWiL5HyzEcnW56Dn9lHf/CCH6AlZ1NfvPkd93H2 9K2Lugijz3RDd0gx2hqKWvcQWvSXq08UNVf7t+MjQqERsctgdyztr0gLsTw7RqqY+J62 Dw1/dRYbUtNQ2mAx9vKKoJfO/cIUpsBqRvye+g/swwIa2Go1qqQFxy8ZqGjyWGhifWmy ksqg== X-Forwarded-Encrypted: i=1; AJvYcCXY8ILN7nM/snsUUNu46+4rYVOIYIU7bavZfachlIy5aOzSgFAlJMfXoyEXm6MLU8eK9rBy4qmXbXLUhDo=@vger.kernel.org X-Gm-Message-State: AOJu0YzsALlO7U8pAtvnUfgcfDsxHM0vLzXxg34MJeC3bvCMfOhmo1Em UyxxoeReS6CiTGGah3O7jabARuPul8osEzjkwlHmEOe0FjU5Osb/EdjH X-Gm-Gg: ATEYQzzaGno9liSxtW6QqKa4348rL2zzGQLpr55wzqG8RD41DfvXcI79UtI4+hWYOjd T2ueqiExSc45G8bbn2jmpJ2ejQea9AaDZq0kPnNMUWE9v0ps6VYA/bG8QeGf8lZ20IP1/Ub70FA XPoISeCfR7gdTne6p2km20D/Ftqp3tsLaD6tKUcCq15faK/9+WuMn3lJxU4u1/kUcofhv0qERbB tm4VqEqDslpGJ/IL4YwxW4MluMqvvweuMRis5eANqi6k9ieaSqrKQW0DmM++n3KkmFnxWi1h1AA Ifx92ElDTYFVJdvrTDyN3e8Yn6S8FXIwmD7QZ9OjiF1yExrFLE9BMqDuWfuMtvtK2WKY9DVoD2S cwIfwMtj5+c2uyDI4LFovES8VsDd9v8+/EE7fZgqPjiRSfrb7Gd9KAUet9KVppb75r+mX8l4c62 JWNjY1ld01wefeF0tjEPkaWyqGI8yBCvrAx8t/Hi5ZV6lcYAT2qMELPINvEjbuiicxSa5ucBo= X-Received: by 2002:a2e:ab0a:0:b0:37c:c84a:99b9 with SMTP id 38308e7fff4ca-38a8979cc5emr1066641fa.24.1773341120875; Thu, 12 Mar 2026 11:45:20 -0700 (PDT) Received: from ubuntu.. (static.159.107.27.37.clients.your-server.de. [37.27.107.159]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e7b64bsm10382991fa.43.2026.03.12.11.45.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 11:45:20 -0700 (PDT) From: Josh Law X-Google-Original-From: Josh Law To: Masami Hiramatsu , Andrew Morton Cc: Josh Law , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 1/3] lib/bootconfig: fix off-by-one in xbc_verify_tree() unclosed brace error Date: Thu, 12 Mar 2026 18:45:18 +0000 Message-Id: <20260312184520.24399-1-objecting@objecting.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __xbc_open_brace() pushes entries with post-increment (open_brace[brace_index++]), so brace_index always points one past the last valid entry. xbc_verify_tree() reads open_brace[brace_index] to report which brace is unclosed, but this is one past the last pushed entry and contains stale/zero data, causing the error message to reference the wrong node. Use open_brace[brace_index - 1] to correctly identify the unclosed brace. brace_index is known to be > 0 here since we are inside the if (brace_index) guard. Signed-off-by: Josh Law --- lib/bootconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bootconfig.c b/lib/bootconfig.c index 2bcd5c2aa87e..a1e6a2e14b01 100644 --- a/lib/bootconfig.c +++ b/lib/bootconfig.c @@ -802,7 +802,7 @@ static int __init xbc_verify_tree(void) /* Brace closing */ if (brace_index) { - n = &xbc_nodes[open_brace[brace_index]]; + n = &xbc_nodes[open_brace[brace_index - 1]]; return xbc_parse_error("Brace is not closed", xbc_node_get_data(n)); } -- 2.34.1