* [PATCH] usb: serial: add RW135R-GL (33f8:1003) support
@ 2026-03-12 10:21 zwq2226404116
2026-03-12 11:09 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: zwq2226404116 @ 2026-03-12 10:21 UTC (permalink / raw)
To: johan, gregkh; +Cc: linux-usb, linux-kernel, zwq2226404116, wanquan.zhong
From: "wanquan.zhong" <wanquan.zhong@fibocom.com>
Add VID/PID 33f8:1003 for the Rolling Wireless RW135R-GL M.2 module,
used in laptop debug cards with MBIM interface for Linux/Chrome OS.
The device supports mbim, diag, adb and AT commands.
Device info from lsusb:
Bus 03 Device 12: ID 33f8:1003 Rolling Wireless S.a.r.l.
Signed-off-by: wanquan.zhong <wanquan.zhong@fibocom.com>
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index e349ed66d2ac..abeeb7c66977 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2449,6 +2449,9 @@ static const struct usb_device_id option_ids[] = {
.driver_info = RSVD(4) | RSVD(5) },
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0115, 0xff), /* Rolling RW135-GL (laptop MBIM) */
.driver_info = RSVD(5) },
+ /* Rolling RW135R-GL (laptop MBIM) */
+ { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff),
+ .driver_info = RSVD(5) },
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a2, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a3, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a4, 0xff), /* Rolling RW101-GL (laptop MBIM) */
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: serial: add RW135R-GL (33f8:1003) support
2026-03-12 10:21 [PATCH] usb: serial: add RW135R-GL (33f8:1003) support zwq2226404116
@ 2026-03-12 11:09 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-03-12 11:09 UTC (permalink / raw)
To: zwq2226404116; +Cc: johan, linux-usb, linux-kernel, wanquan.zhong
On Thu, Mar 12, 2026 at 06:21:08PM +0800, zwq2226404116@163.com wrote:
> From: "wanquan.zhong" <wanquan.zhong@fibocom.com>
>
> Add VID/PID 33f8:1003 for the Rolling Wireless RW135R-GL M.2 module,
> used in laptop debug cards with MBIM interface for Linux/Chrome OS.
> The device supports mbim, diag, adb and AT commands.
>
> Device info from lsusb:
> Bus 03 Device 12: ID 33f8:1003 Rolling Wireless S.a.r.l.
>
> Signed-off-by: wanquan.zhong <wanquan.zhong@fibocom.com>
Please use your name, not your email alias, for the name portion of the
From and Signed-off-by fields.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] usb: serial: add RW135R-GL (33f8:1003) support
@ 2026-03-12 11:32 zwq2226404116
2026-03-12 12:31 ` Johan Hovold
0 siblings, 1 reply; 4+ messages in thread
From: zwq2226404116 @ 2026-03-12 11:32 UTC (permalink / raw)
To: johan, gregkh; +Cc: linux-usb, linux-kernel, zwq2226404116, Wanquan Zhong
From: Wanquan Zhong <wanquan.zhong@fibocom.com>
Add VID/PID 33f8:1003 for the Rolling Wireless RW135R-GL M.2 module,
used in laptop debug cards with MBIM interface for Linux/Chrome OS.
The device supports mbim, diag, adb and AT commands.
Device info from lsusb:
Bus 03 Device 12: ID 33f8:1003 Rolling Wireless S.a.r.l.
Signed-off-by: Wanquan Zhong <wanquan.zhong@fibocom.com>
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index e349ed66d2ac..abeeb7c66977 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2449,6 +2449,9 @@ static const struct usb_device_id option_ids[] = {
.driver_info = RSVD(4) | RSVD(5) },
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0115, 0xff), /* Rolling RW135-GL (laptop MBIM) */
.driver_info = RSVD(5) },
+ /* Rolling RW135R-GL (laptop MBIM) */
+ { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff),
+ .driver_info = RSVD(5) },
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a2, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a3, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a4, 0xff), /* Rolling RW101-GL (laptop MBIM) */
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: serial: add RW135R-GL (33f8:1003) support
2026-03-12 11:32 zwq2226404116
@ 2026-03-12 12:31 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2026-03-12 12:31 UTC (permalink / raw)
To: zwq2226404116; +Cc: gregkh, linux-usb, linux-kernel, Wanquan Zhong
On Thu, Mar 12, 2026 at 07:32:14PM +0800, zwq2226404116@163.com wrote:
> From: Wanquan Zhong <wanquan.zhong@fibocom.com>
>
> Add VID/PID 33f8:1003 for the Rolling Wireless RW135R-GL M.2 module,
> used in laptop debug cards with MBIM interface for Linux/Chrome OS.
> The device supports mbim, diag, adb and AT commands.
>
> Device info from lsusb:
> Bus 03 Device 12: ID 33f8:1003 Rolling Wireless S.a.r.l.
Please include the output from usb-devices which includes details about
the interfaces (see commit ae420771551b ("USB: serial: option: add
Rolling RW350-GL variants") for an example).
> Signed-off-by: Wanquan Zhong <wanquan.zhong@fibocom.com>
> ---
> drivers/usb/serial/option.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e349ed66d2ac..abeeb7c66977 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2449,6 +2449,9 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = RSVD(4) | RSVD(5) },
> { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0115, 0xff), /* Rolling RW135-GL (laptop MBIM) */
> .driver_info = RSVD(5) },
> + /* Rolling RW135R-GL (laptop MBIM) */
The comment should go after the entry (it's fine to ignore checkpatch
warnings about long lines here).
> + { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff),
And please try to keep the entries sorted by VID/PID (i.e. put the new
one after Rolling RW350-GL).
> + .driver_info = RSVD(5) },
> { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a2, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
> { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a3, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
> { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a4, 0xff), /* Rolling RW101-GL (laptop MBIM) */
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-12 12:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-12 10:21 [PATCH] usb: serial: add RW135R-GL (33f8:1003) support zwq2226404116
2026-03-12 11:09 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-03-12 11:32 zwq2226404116
2026-03-12 12:31 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox