From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E4B71E7C12; Fri, 13 Mar 2026 00:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773361183; cv=none; b=hRQfHzdXO2mPlbhvOrVYM3dJoHSLmx/5D++JeFpQA5doaRgRrSi1m7KW6PEY1yBMX/6kDdklGguZHsa/KCDVBH5bhOgqZ7K7hjLVGXqYHw07Sb9rV7CmR3N0E4ETHXY+0rYFM7UfZC7Y78bipA3Lfqawj7I0ZjdXStKfeDC/vJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773361183; c=relaxed/simple; bh=X/kBY42h2F53qu8QE7AbaKPKfnSDqElz1IdGpmh/fhE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RRTw8gZhadY840QYTezelzHYXu1hyrFsfFxnQvvwoPVSSU8o9DnA8H3UkYcMZiL9B0udMaq/kyfx5xh5PcdeTjczVW+NIHHf2lRTx4ie62ZszZejO2dNAUIAqZ6vTv4PcVTJ1lF1Umbyc+ZpwAEP9pNdc6Xme/QI7HpyDVV3J+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a12XMP5s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a12XMP5s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53872C4CEF7; Fri, 13 Mar 2026 00:19:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773361182; bh=X/kBY42h2F53qu8QE7AbaKPKfnSDqElz1IdGpmh/fhE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a12XMP5sfnB42RfPxKpgsQv5hq4zHDdIBjy5Q988JiS6XqmeILThiPKi3iPd6HY9f UtFze1vbnxgCPxYscdJNs793I/dCtKLWq3pCt765jybYI9Nv6ihUSGdC/1jJnRP1uj stVrbnCD4Zy/uhaomAXXU3ng0LpFnf0B+6b8iXR68pYW1w+c0226L0iNIt6Hu4YtA7 bCbETa1qz2JsOlTc3/mulGNQdTX/YNziQxWfnF9S8wk+0GPcYHvcYEXKudsu2ErGuk 3uZGreu35b4d988SKwPmSfyf0XtkIvIWQmG95uXQCnZP0KCZxhqHW5+A3Cty23+VJa rvtNQMJ6NgoGA== Date: Fri, 13 Mar 2026 08:19:40 +0800 From: Yixun Lan To: Trevor Gamblin Cc: Iker Pedrosa , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Michael Opdenacker , Javier Martinez Canillas , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/7] riscv: dts: spacemit: k1-orangepi-rv2: add PMIC and power infrastructure Message-ID: <20260313001940-GKA407679@kernel.org> References: <20260309-orangepi-sd-card-uhs-v2-0-5bb2b574df5d@gmail.com> <20260309-orangepi-sd-card-uhs-v2-6-5bb2b574df5d@gmail.com> <8e91c86d-ea41-4535-a7cd-5b602c546cb7@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e91c86d-ea41-4535-a7cd-5b602c546cb7@baylibre.com> Hi Trevor, Iker, On 14:27 Wed 11 Mar , Trevor Gamblin wrote: > Hi, > > On 2026-03-09 07:40, Iker Pedrosa wrote: > > Add Spacemit P1 PMIC configuration and board power infrastructure for > > voltage regulation support. > > > > - Add board power regulators (12V input, 4V rail) > > - Enable I2C8 for PMIC communication > > - Configure PMIC with buck4 (vmmc) and aldo1 (vqmmc) regulators > > - Set up regulator constraints for SD card operation > > > > Signed-off-by: Iker Pedrosa > > --- > > arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts | 48 ++++++++++++++++++++++++ > > 1 file changed, 48 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts > > index 7b7331cb3c726f11d597f81917f3a3f5fc21e1b9..414b03f5e6480f05f5d7eeaaa0afb4e86425ae36 100644 > > --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts > > +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts > > @@ -19,6 +19,25 @@ aliases { > > ethernet1 = ð1; > > }; > > > > + reg_dc_in: dc-in-12v { > > + compatible = "regulator-fixed"; > > + regulator-name = "dc_in_12v"; > > + regulator-min-microvolt = <12000000>; > > + regulator-max-microvolt = <12000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > Is this the correct voltage? I don't see a 12V rail in the RV2's > datasheet, and the board's specifications only indicate a 5V USB-C input. Right, this should be fixed. Please note Han submitted one version of basic DT for rv2 which I think that series will go in first https://lore.kernel.org/r/20260310161853.3900605-1-gaohan@iscas.ac.cn > > + reg_vcc_4v: vcc-4v { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc_4v"; > > + regulator-min-microvolt = <4000000>; > > + regulator-max-microvolt = <4000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + vin-supply = <®_dc_in>; > > + }; > > + > > chosen { > > stdout-path = "serial0"; > > }; > > @@ -92,3 +111,32 @@ &uart0 { > > pinctrl-0 = <&uart0_2_cfg>; > > status = "okay"; > > }; > > + > > +&i2c8 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c8_cfg>; > > + status = "okay"; > > + > > + pmic@41 { > > + compatible = "spacemit,p1"; > > + reg = <0x41>; > > + interrupts = <64>; > > + vin-supply = <®_vcc_4v>; > > + > > + regulators { > > + sd_vmmc: buck4 { I'd suggest name it more generic and add a comment where device reference to it, since buck4 requested by more than one devices, will make people less confused. something just like: buck4: buck4 { > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-ramp-delay = <5000>; > > + regulator-always-on; > > + }; > > + > > + sd_vqmmc: aldo1 { > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <3400000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + }; > > + }; > > +}; > > > -- Yixun Lan (dlan)