From: Robby Cai <robby.cai@nxp.com>
To: Mark Brown <broonie@kernel.org>
Cc: Andreas Kemnade <andreas@kemnade.info>,
lgirdwood@gmail.com, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: fp9931: Fix error handling for optional regulator
Date: Fri, 13 Mar 2026 08:27:21 +0800 [thread overview]
Message-ID: <20260313002721.GB1440672@shlinux88> (raw)
In-Reply-To: <62d8a4ce-bdf4-4629-8669-5f6c3e07a699@sirena.org.uk>
On Thu, Mar 12, 2026 at 06:00:54PM +0000, Mark Brown wrote:
> On Thu, Mar 12, 2026 at 06:58:54PM +0100, Andreas Kemnade wrote:
> > Robby Cai <robby.cai@nxp.com> wrote:
>
> > > data->vin_reg = devm_regulator_get_optional(&client->dev, "vin");
>
> > looking at that thing again. I think I have abused the optional api.
> > Of course this chip needs a supply. It may be hardwired so something
> > not switchable. But that needs to be wired to something... So I think
> > rather the _optional is wrong here.
>
> If it's a mandatory supply that's right, I may have misunderstood what
> the supply was doing when I originally reviewed this.
Thanks for the review. This does make sense. I'll send out patch v2 soon.
Regards,
Robby
next prev parent reply other threads:[~2026-03-13 0:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 4:01 [PATCH] regulator: fp9931: Fix error handling for optional regulator Robby Cai
2026-03-12 17:34 ` Mark Brown
2026-03-12 17:58 ` Andreas Kemnade
2026-03-12 18:00 ` Mark Brown
2026-03-13 0:27 ` Robby Cai [this message]
2026-03-13 0:24 ` Robby Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313002721.GB1440672@shlinux88 \
--to=robby.cai@nxp.com \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=imx@lists.linux.dev \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox