Re: [PATCH v25 1/9] sched: Make class_schedulers avoid pushing current, and get rid of proxy_tag_curr()

Peter Zijlstra
2026-03-18T20:34:35Z

On Wed, Mar 18, 2026 at 01:30:17PM -0700, John Stultz wrote:

> Yeah, this looks equivalent to what I had in my patch linked above.
> I'll go ahead and take your version though.
>
> The only tweak I might consider is setting the prev_donor along with
> prev, so we don't have to move the rq_set_donor() call to be on both
> sides of the sched_proxy_exec() conditional.
>
> Feels much simpler to read, and I'd hope the compiler would optimize
> the extra assignment away if it were unused at compile time. But maybe
> there is a concern you have I'm missing?

So my goal was to capture as much of the PE specific stuff inside that
sched_proxy_exec() branch.

Having to push that rq_set_donor() into the else branch was a little
unfortunate, but keeping it all inside that branch makes that we can
easily break that out into its own function.