Re: [PATCH v3] staging: rtl8723bs: Improve error handling

Dan Carpenter
2026-03-16T08:25:19Z

On Fri, Mar 13, 2026 at 07:37:41PM +0300, Bera Yüzlü wrote:
> Remove unnecessary ret variable and goto exit pattern. The function now
> returns immediately when an error occurs. Additionally, ensure that
> intf_free_irq() is called when pm_netdev_open() fails to avoid leaving
> the allocated IRQ uncleared.
>
> Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
> ---
> V3: Fixed patch description.
> V2: Used int_free_irq() in error condition.
> V1 Link: https://lore.kernel.org/linux-staging/20260312131933.29505-2-b9788213@gmail.com/
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 28 ++++++++-------------
> 1 file changed, 10 insertions(+), 18 deletions(-)

I responded to v2. Same comments here.

regards,
dan carpenter