From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDFC93C5DDE for ; Fri, 13 Mar 2026 17:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773421633; cv=none; b=QAWtan2PvcKijUFrT2TzihCRgunDRDxlujka8AsFQtxaDmF5rc5HBs5iohh89viCtzt8C3YO8CXYuB9/1EqhERhxhZkQlcA9dTNM+GcG94GRYqnEmRxL7v70pNxQPWPG4IW6fsjk69BgBwwkh+ID752lQfX84djvcDM/CSU4ZlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773421633; c=relaxed/simple; bh=z7AGwqb57CwAMqE9fS+3ykGurf6LPqrzuywb5yXOKzw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WOL2YdUelRO0UIGlHMvz3VqhHe+x9iDTGKinzVKJaYDIFu/fetEAGOW835GwrevfFdRy9xeYQAsmozl2aCQ7b0CLj2PBXpUnlpTVtQaE5+ZV3LLV22W7Y3vmdNP9O7jBdEhMsP1snDvhk/sBkq75xfhHX2n3ho1R/qOlVQm5M+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=H+mo1k8/; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="H+mo1k8/" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ae49120e97so3675ad.0 for ; Fri, 13 Mar 2026 10:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773421632; x=1774026432; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kcULnJOLAuZh87RKAsbNLZQYw5Yxpz2q2AsZGTy7iU8=; b=H+mo1k8/iHELVGCO1YKNn2bZEyDoPnA7xtKtqnllTeYFZkb0U3P7BgrkQWg2PASxya F7/M9Ehvn4GkRobu+Wdt6Q98audhSAYnPEhEPnpVrDrwodZ+/NImBeaHsGVOBJ5NFfHr uiM1Ou4mBM3zFtc998Wtj9lbS+Gx7pBGNzfU79rjUbSeKOjDA7TAn7l8h06BQroOF5h7 IwNVNzt/FA5yOxuyhoNbww4KDvCvt5N7/NU2f1AH60EvDpmOtyH8m7cvzhq1es/NNk1u kJWuJ+mIJvZBEVarCGiSh7f9GO3gi8Hr9cp1cTfWhWa0kk086WOL1biIBWzpCWQH1Qp2 TWdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773421632; x=1774026432; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kcULnJOLAuZh87RKAsbNLZQYw5Yxpz2q2AsZGTy7iU8=; b=LYLIM3GFAJ3JdaE3w1iigqLtojb91IJ4+E66RYB3CQaxbawqDBAhcC6Tr1ay3nhdDH gNrGzDuRAC3ndXxny6MN3xQnJDLGGlViIHLkwyEaUasc6EKisFBIKmGB2nYZ2rDOGS3D 1iTNhJJpDeFN58xLwS1PwgNT83cHm1rdklfczHJqwc2s+seNPE88SZJTFTAeCXolCa3M 8KrSTOhgKGGc3wBGUpy9nEncs/Oi2tYDnBUTQ4lMv4/YQfsSjknZsUgVVyZClz6EhXLN 7CWv3Ni+SKhy3wEJt5H5Tf1EGZL2JLj+SRzbMDC5UpwT2KqBr/g+xnba8VUu1DZ/fRtz wS8A== X-Forwarded-Encrypted: i=1; AJvYcCU0zJdcTjNlGJK6DqjXuc051kdLwzIGavxc66tNEoho0rAVC0RinF1GV5UGykul0vPrli/GQtpF53njFqw=@vger.kernel.org X-Gm-Message-State: AOJu0YxYD4uPtEJu8ILF3jzQaiLrqy96snnwG0Uc0S8ZisqvJF+DICHJ XpMzyGu1uflvbjaRqP4k00oNVr3FBEGe1HUnuSDQSuajr6OOR87PUZJ1zfEt3USE6A== X-Gm-Gg: ATEYQzzU10dS5s4QDScIcLaDtS+A7Q174bxsgc9waMwS8S6edLb8+JYe+WM41LXUesL C4tmDAIYdKvFaGwcoMP2X8psoJP87WSIXSkYSBRwb+lF/YNH2KdjycokFIQDJTsfEb1DZNFJ+YF qbosAos9IYaF04uvZXRLQSkt7eVEPF7+F5LULsiUiN/KUHJ/uGXMnYl+gFg7MHUW6APqMVxC6rD opfMuonzFou9P8DGyRv3mB4j0iYjnjO2DNSVjQgfeHi9ArpgF4OegHmAInSJA1qJjv4F5CWSWao 31Ba48pdLEynd0FvSdAodkP1Vv6pj8ZK3ZOtEDhmNmY+pe7ZS/NToS7lL94HPXXK0bMAskcGvhH RzwYC9kda7Ftk3m+HSLOsYjaFFzIobIczY14EdZgLIRgymijT3BAG8GJdu7Du3daRDtmw4VmOGR J7CJE3+myuwEQcy/D31brrzEN1RBvC81xRovqO0suJN+EUjYKBrkmLSRSsy0pjAzxFLQY= X-Received: by 2002:a17:902:ccc4:b0:2a1:3cdc:7720 with SMTP id d9443c01a7336-2aecd668c28mr2837265ad.21.1773421631684; Fri, 13 Mar 2026 10:07:11 -0700 (PDT) Received: from google.com (197.23.125.34.bc.googleusercontent.com. [34.125.23.197]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece5c1465sm39467795ad.21.2026.03.13.10.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 10:07:11 -0700 (PDT) Date: Fri, 13 Mar 2026 17:07:06 +0000 From: Sami Tolvanen To: Greg Kroah-Hartman Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Petr Pavlu , Daniel Gomez , Aaron Tomlin , Shyam Saini , Kees Cook , Thorsten Blum , Christoph Hellwig Subject: Re: [PATCH] module: remove MODULE_VERSION() Message-ID: <20260313170706.GC213695@google.com> References: <2026031341-evolve-repeater-987b@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026031341-evolve-repeater-987b@gregkh> Hi Greg, On Fri, Mar 13, 2026 at 03:20:42PM +0100, Greg Kroah-Hartman wrote: > Module "versions" do not make sense as the kernel is built all at once, > the "version" is the overall kernel version number, so modules can not > really be described as having a unique version given that they rely on > the infrastructure of the whole kernel. > > For now, just make this an "empty" define, to keep existing code > building properly as the tree is slowly purged of the use of this over > time. > > This macro will be removed entirely in the future when there are no > in-tree users. > > Cc: Luis Chamberlain > Cc: Petr Pavlu > Cc: Daniel Gomez > Cc: Sami Tolvanen > Cc: Aaron Tomlin > Cc: Shyam Saini > Cc: Kees Cook > Cc: Thorsten Blum > Cc: Christoph Hellwig > Signed-off-by: Greg Kroah-Hartman > --- > include/linux/module.h | 56 +++++++++--------------------------------- > kernel/params.c | 30 ---------------------- > 2 files changed, 11 insertions(+), 75 deletions(-) This certainly solves our version problems! I noticed there are a couple of __modver references left in the code base after this patch, which can be dropped too, and you can also remove the version field from struct module at the same time. Sami