From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D39AD362130 for ; Fri, 13 Mar 2026 18:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427383; cv=none; b=mzVSjvKfqHGuA2WjKg5vrFN0JXpE9BTmdnVhQ8jhbK8TePCoDiWbXzEEfsKbdZNjSAuQmuvRPk5tq2Iz644BOzwjKLMdN6PgtvyTsoYddRQKFwtq+ASu4UuWKlzR2Sgt3yVpCVkUhT/iaWiz2SSQO5TFJJGmxBYoWrmbh6KZqw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427383; c=relaxed/simple; bh=qG79F3bBT6jsj5MyZ+DmjyLvwJgCGA1ee7wOQ7HnB2c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P+cJZTFhDNgNKl559aMKKZSbJXjdHOAeZN3DfdpLqL1dh4lFp3J250j9W2v02pwKdeLL2DgyZg9SLO1Tkgr5VQCROxW0NDYoIRbhNwp4BjbSTzLcXhYjjikFhFUg8Q5sv+kL3gSdCYRgwgZtU6yBZL+yYeKKfrgU7rB+drsjcL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=cY3qvrw3; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="cY3qvrw3" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-509064418a8so28934961cf.1 for ; Fri, 13 Mar 2026 11:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773427381; x=1774032181; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=33LRHogpGiDAoJ0hSgyq37DznMxJ4ZqKispiDKsO2iw=; b=cY3qvrw3kHNCq827Ay7IsttxvYcDfoZefBb5Iz2z0Wr7FEVAlgBK/MApyYSjz6awY9 mtoqYzyicqfVAOp67mgqcTckmXugw9zu6yVDakthIqJm6vaTxzy19oyz7xU+7A1WLhSq uTlovw0ZvQr7ZnBwwC75C3FEkop/yWrGypPhaws241XCBlgNywuS4FJEz696Y8uaAtKv yFfsPL9I0ZHtqG9/56U1z8iGlTUawfY4/SxTd0gN8kMg0o6WAjRc4BprffG0vyWURBxt K5hDmZh3TLlscATqSZUFbHdqGKVUyZ1vOc0pQ8N6ZeOsl6bfVTNp7ePRjIcKH/wNMLiQ CF/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773427381; x=1774032181; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=33LRHogpGiDAoJ0hSgyq37DznMxJ4ZqKispiDKsO2iw=; b=pseHEkZSOarsIGAU1BhXPA3oIvYpIO5sXbx0Q1cNtOGtp6Xgvm7nksdD/kLpb8qqqo w8j5Re80ANGZ7/RRAJYejYrz++rrqT8SZz9UM4PuLTlpPjN++ugNpghhDJQegwCCukvX Xd8q9E6qKMWmsTPkshuw6Wtvl/aZs9RgRJEHUqtpDI93qp3zxairaQeBHU+qLdP8ndbg b43FerRUZbOvBtgNxRITge5J9wFM51mZFmbPm+JQerCRTWlLx2UILs4+RlBeIxMDFDbZ oaiXwr2A/gonXlvQ180Ulz0f4jly0sbZMtuu440vN65eO3Gdbtx1otXw3Pvat8jY8Lmj s60A== X-Forwarded-Encrypted: i=1; AJvYcCVG9tbu1eeoM9CV1wNz5lMCKCeiv6a50ThBOOjdCA1PP1sJsxKkHkbdlobcXIthzzPArlWcGEHUJZXQcEk=@vger.kernel.org X-Gm-Message-State: AOJu0YxNp6Kaw4AJEAKIOsh8bY91Xf53zms19SDFpmlVhV1ZvBkUdlMR EOdbnfzdY+45JdBGDxr8hVRqMQcOXqxVBHlYlYe3lHOQL5804j9/rN/WoUAagZXlWHI= X-Gm-Gg: ATEYQzySwFw+NehzbrzaEP3fPuEMsYZxu+D1nekXAPSmCXUoOcV+PV+MzwHi2hGpLJg zpkVHqamldFM/hzKRy5ebU7NxbIBR8bS/FJvul3YMMKq0rPRDeHd855CKphl6fAmdUSZ90LPfKz WuLH6RV/HJ36n5BCncCBcswc7h8+b37Kg+933N22KBdgLiHFzPJk2S1m/rMhOR7Rc8OMfIjZrrF Yk20j2FJFOEfW5B4iBXcPe2ly+CHM9dvalLWuOBAKiX1LatD04S2eyp+EwE0ispwuXYve5C+aEK jgnBzVHQi1VcoMdvtlHoR40yJGqaD++yzUIXM782tbks+S8xmHGeIY+jWMpCttxtuckoMfSwpYq /HtZ57F48pxqdOAtNk1vYglEBOTIaiCHDGC66HpM5smrjB3qM86ypw2opqucF3Urfh6S9qNBAwE NNcmxDNH0a+ZZOXhw8janlU422ACEVVlIc2ZVMx0GYWOb8LxApo4P+my3yKp1l+Sa+pfhRb5ItZ kNV+B0T X-Received: by 2002:a05:622a:1301:b0:509:2822:6701 with SMTP id d75a77b69052e-50957cc0c69mr54001261cf.28.1773427380808; Fri, 13 Mar 2026 11:43:00 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a65c071d4sm60555916d6.21.2026.03.13.11.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 11:43:00 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w17TP-00000007M0D-311H; Fri, 13 Mar 2026 15:42:59 -0300 Date: Fri, 13 Mar 2026 15:42:59 -0300 From: Jason Gunthorpe To: Jonathan Cameron Cc: "Aneesh Kumar K.V (Arm)" , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Kevin Tian , Joerg Roedel , Will Deacon , Bjorn Helgaas , Dan Williams , Alexey Kardashevskiy , Samuel Ortiz , Xu Yilun , Suzuki K Poulose , Steven Price Subject: Re: [PATCH v2 2/3] iommufd/tsm: add vdevice TSM bind/unbind ioctl Message-ID: <20260313184259.GM1704121@ziepe.ca> References: <20260309111704.2330479-1-aneesh.kumar@kernel.org> <20260309111704.2330479-3-aneesh.kumar@kernel.org> <20260311213555.00001064@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311213555.00001064@huawei.com> On Wed, Mar 11, 2026 at 09:35:55PM +0000, Jonathan Cameron wrote: > > +int iommufd_vdevice_tsm_op_ioctl(struct iommufd_ucmd *ucmd) > > +{ > > + int rc; > > + struct kvm *kvm; > > + struct iommufd_vdevice *vdev; > > + struct iommu_vdevice_tsm_op *cmd = ucmd->cmd; > > + > > + if (cmd->flags) > > + return -EOPNOTSUPP; > > + > > + vdev = container_of(iommufd_get_object(ucmd->ictx, cmd->vdevice_id, > > + IOMMUFD_OBJ_VDEVICE), > > + struct iommufd_vdevice, obj); > > I'd be tempted to do something with a helper function to simplify flow. It is already static inline struct iommufd_vdevice * iommufd_get_vdevice(struct iommufd_ctx *ictx, u32 id) { return container_of(iommufd_get_object(ictx, id, IOMMUFD_OBJ_VDEVICE), struct iommufd_vdevice, obj); } > Then the helper function can do direct returns on errors given the > iommfd_object is managed in outer function. Use cleanup.h ? It is not the iommufd style the break things up into little functions for error unwind reasons > > + if (!vdev->viommu->kvm_filp) { > > + rc = -ENODEV; > > + goto out_put_vdev; > > + } > > + > > + kvm = vdev->viommu->kvm_filp->private_data; > > + if (!kvm) { Ah this I don't think you should be doing. That needs a helper from kvm Jason