From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D42336EF8 for ; Fri, 13 Mar 2026 18:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427700; cv=none; b=KXHx86vgLslRtC7WPmVrrWRI8Ze/OAxZnhTOr2VGF8sFqoESAdLz/DOV0p5M8XdCAkf0+GrjXoZCFNmPGB1MTH2oaeXuRIUcTu9W89CZxfuZodbJq08sZOeHZwWmt7IWQAEg3AmA52v4XHztFBeZMDH0LklZxT/bEZNWNvb36Rs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427700; c=relaxed/simple; bh=bDMn+pND6C8k5z/VxMRY1ADpxIk5K4fL3QB8DYqqNso=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qOD606NSgU/1m9guy2ucwJ0EbhU19aHPphSaboGZ17hccyL///rhRaa0XVNN0B5qOtmzb5eg8DZZ0JXawh3dNX1/msxttZYdLyYkN4EQCFBxI9kniqwl0icZK3b72EbXWLZdKg8WzzNMHwIscn5WxiyY3pUi5qQOX7X4ZzKFfcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=fsmCu5rH; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="fsmCu5rH" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8c9f6b78ca4so315991985a.0 for ; Fri, 13 Mar 2026 11:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773427697; x=1774032497; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=01fjBoYSqV223rYI33+jsswxHzATZtFRcSWT+x97rj0=; b=fsmCu5rHN9FjND61WV73aay8XgGBLWa7laVXlmcCp7wsZOtJ3viERW+1khBil2ry0Z R0xOMTadRdcquWuI7rYgMQzyDuF/WOZHbRWOCJHoJ36LWZrrGaec5PjZVNa0v8bCr0iq mkXbsksX4sCaAtvozuYCUpzTCwh8PqXWMTK0ssftmMhMhSBXyeQXIpjce8NCyltrkhUq AMqDErbJr33l8Tn/cVDqqPDlNjdaoFdUq+TrF9ckDQ7drRavUrNkXKBnsk2h6NgSf0ms IkO8Qc3RNttjetij7h1bFkLi1tk+fZhVok2HnXe66hKzXKvM4vBIqHgRTmkXNbACc4X4 Sgbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773427697; x=1774032497; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=01fjBoYSqV223rYI33+jsswxHzATZtFRcSWT+x97rj0=; b=a4AyQnjukmj2XeG9WRYNTtLVIWh/5xeyWwYpj2teBWOeuMSGuQQOLqFbmc+0GaCBRb OOYGZVMFKHPHvQMb7I5IbqKPg6aQ80UnqLHuV7Zi7sJxn6S4Q8d0EnebRPZ5evSCJ0ZL bSmACAl2GwhjLYkrF/B6hQJrhWrt8iXhe2yHx2w86M+alG43DlUPxDxR44UTycDrVjsx VnVgLws4lJF17aAJLIfJJ2yEFZd1o5GO32mnsQcq37E88IFLrQamov+6Q9EaPCWz2GoA 5+bpjCFsjc8jgKRkAAanjQuW11OZ4/Ua5DZN/bYDDmBJFZENJfEosy+6JOYtizewgAms k50A== X-Forwarded-Encrypted: i=1; AJvYcCV04Q0tWvKCFM+RwAmq6BRWyoVm7//lwVpQpjJxd8tPZGdCCdKQa+Ur79faO/vzY7FviyTnS5S2/Yz/J3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyipMmiVFZ2esCEfbwAA079cO8l+jnMvsxRbTEtT1/tzLEu8RXq VSnAPSZN6kzbmzD7b3B6TojjNzC41PdamaVLJ9ATVPRncZa9QerRg7ee3isB28SA/6A= X-Gm-Gg: ATEYQzzLZKBbcpyF30bWrI+4D2xSVz+gkzLttLescGzejt3zFnilTCL40llpvZfIDnA N6G73Z80oLKhR6rr0dffnokAzcPP7uWHMovuraSTYgBpA6rQ1fPHh1cEHq4nyyysShxPNW3qs6D Y9JA4uezSYKZjdnzklhssLOhn+PmFot0q81KR+WsxG562RjrVfyM3guTgOugwqopUC9eXQGsMP1 sk/IUCN+04CKNJsP1Vh0CHFm6wFw9vTEDHwE7QzGCr8n+yZkRLqkp6ahjFuHBvkDyhC7RzKt8Zu g8c1XhEd2RVfwT+4SZoXpyrIg9aRRMMRXsvrXR/svp1tfuc5pZ8cKCvXD8vvv0QPcin7cO8R51K 4K6ziN6ZdzqBC3m8T12uARuxCwzkI5u74aDb680Rucg4O4484eKciP3H+8PyHTYMLTZ2BZmIvwL ZsuWpy5FCNMij96c1aNqa6Iev2wFxIUadrPOwuBMwyqMC89JejGrb0IgumR5sQTeM2hbBuGimcf 2bVa6XT X-Received: by 2002:a05:620a:4510:b0:8cd:b52c:5983 with SMTP id af79cd13be357-8cdb5b59a6emr636703785a.42.1773427697122; Fri, 13 Mar 2026 11:48:17 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cda212cac1sm715538585a.33.2026.03.13.11.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 11:48:16 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w17YV-00000007M4R-42dz; Fri, 13 Mar 2026 15:48:15 -0300 Date: Fri, 13 Mar 2026 15:48:15 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Kevin Tian , Joerg Roedel , Will Deacon , Bjorn Helgaas , Jonathan Cameron , Dan Williams , Alexey Kardashevskiy , Samuel Ortiz , Xu Yilun , Suzuki K Poulose , Steven Price Subject: Re: [PATCH v2 2/3] iommufd/tsm: add vdevice TSM bind/unbind ioctl Message-ID: <20260313184815.GO1704121@ziepe.ca> References: <20260309111704.2330479-1-aneesh.kumar@kernel.org> <20260309111704.2330479-3-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309111704.2330479-3-aneesh.kumar@kernel.org> On Mon, Mar 09, 2026 at 04:47:03PM +0530, Aneesh Kumar K.V (Arm) wrote: > @@ -1174,6 +1175,23 @@ enum iommu_veventq_flag { > IOMMU_VEVENTQ_FLAG_LOST_EVENTS = (1U << 0), > }; > > +/** > + * struct iommu_vdevice_tsm_op - ioctl(IOMMU_VDEVICE_TSM_OP) > + * @size: sizeof(struct iommu_vdevice_tsm_op) > + * @op: Either TSM_BIND or TSM_UNBIND > + * @flags: Must be 0 > + * @vdevice_id: Object handle for the vDevice. Returned from IOMMU_VDEVICE_ALLOC > + */ > +struct iommu_vdevice_tsm_op { > + __u32 size; > + __u32 op; > + __u32 flags; > + __u32 vdevice_id; > +}; > +#define IOMMU_VDEVICE_TSM_OP _IO(IOMMUFD_TYPE, IOMMUFD_CMD_VDEVICE_TSM_OP) > +#define IOMMU_VDEVICE_TSM_BIND 0x1 > +#define IOMMU_VDEVICE_TSM_UNBIND 0x2 use enum for an op, put it before the struct, add kdocs for the enum members. Jason