From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 278873C6A2C for ; Fri, 13 Mar 2026 18:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427801; cv=none; b=GtyNJg1nrhz4r2iPVWLO6uw5Q1axc9bCpSfkzxRf2Cb253O+jzx9keBWIzHROvWAjnALsbFRFXZRYFkVsqYq9POZ8LtfVLGA5ohBMkM0DC6IfF8u33cKmspqM1UY3OL4GnxTSKxSUXUvSPQRWvzChMZLuy517Ro0kwG3XPwshcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427801; c=relaxed/simple; bh=Cgw7rgg052jBwsBm6FVNyDCSrT6homGIa8xXe2Nl/LM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EWgK43LatbHYD1aVKP59w3ZqkcxX9gcyQ7om8J7Xix6DqZf78U0mlnoTARuUu8Sg6GeV4RRyoIz8JZLKpeDvjyIQb1GnPiDaDhINxHcH5uue6y50HRGxbLe90PFS0oYKKk9012uh40E/oO3bgJuhh4y9qyl2LkOVPwT0EUtXh4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=K9YjvRks; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="K9YjvRks" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-89a6ac6f389so33245996d6.3 for ; Fri, 13 Mar 2026 11:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773427799; x=1774032599; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OmAqHdmpJRsgkjLn2CzcNC2LkQHnurZaGunyWBb1R7Y=; b=K9YjvRksQY3FFeQ1Ul8m4OwqoG7uRV5kVSzI34hshgibVjh6/iaT45ASgrVOQuoJEg KwUdmPbcljGdyjVhm/gOMEaHWAgp1v2h7M7gig4pqIgrC6Rbs5UxisQd914AdmoyeEGr blDcFL5b7aT2kBHnl3OkryosFmHAJ5jrk4boo24+f0/raau9ruT00S5KaquvO9on0dzb hq7e6E0cLQqrEQSkWqOPiFB2c+qduQfWrQmwJhTWL/AFjGWhN5Ue7RSq1MN0vSRtX+X1 DUb0y6gOdJDd1J17SswISjCZgrZcBhdygZycT0P97u+0taLLxLf2FEFPOtrinVCcoCZZ 3byg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773427799; x=1774032599; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OmAqHdmpJRsgkjLn2CzcNC2LkQHnurZaGunyWBb1R7Y=; b=aBritOb6kBotkTvNVFLLTNBCX1AGZcw0mke4B+2oLl65yqtEHVEmVUiwPwhDE67NSg +T4JYsm2Zk21YaTQiZLc5ZOPYHIDA9VA+1jN7ma2vxNUexNwUABTln9X0yVkXzU2THz6 YfBMDRb2vxEev9ghcip266/fO23Cc7XtAkfa97GgPNSsS1cwejAaGrauDCbqfL/wct0H VfWt11JpUxf3EQGKHtBVvfDwWy9hgNzSP3EH44LUKTuTlBW752IWiMHyCH6FFZJOS0Vs sRbGyy6s5agdfT+gA8JLrLHchr2lCnn0kd2Ax3CYTjAqtrMFH4M++qooQzDES691NP8F 1vzA== X-Forwarded-Encrypted: i=1; AJvYcCVYGqRM8jW8tTeRFn4EI2biRF612zPCzeHBQpbS67NKhttLoO8E4+8+1zKaNE90o/YJUR7CGVzAW0AhZWs=@vger.kernel.org X-Gm-Message-State: AOJu0YxExiEpWWoZOKqMVOG4pjB47j1ErcKvTGmyKE+YCjdcomUeyLHd Sy+UPAmOsqIbaf7mOApoG4uGDDRQt9pJQHacVIIdijc/ut/yYXuhQMvZpXvRO/U2RyY= X-Gm-Gg: ATEYQzzNhh9jvm5YQkgViFRI/e0DFyTL2+zF/YLTMOnDU5eGIh+7trvTNiEmFbUBSpe dVJ4AZ+/kzU94LnrIraF6J5lgh6U8JKZKhW5M0K0plaETr55LwgEuK1mdGfUMsNBb9iCKELe+Ot OcOyzIAINeVJBSs89jPcVdv//WPee8jIFYtKow7OSlVBHKMFwsApQ0SRhTzXx4zxqiDKGN1uv3U Lrr48+BWrY6frD6rf3ymWSDNiIHop3d5GqUKuwwoTAcu3Ilo6fTCfXx5TRiq+YSj+TVIWHrKrAt zEkjllpJfxfrS67FjYBCs+1bi/Jhtxt1asDsE1fAD4UcLUeeBua/0KcViCdKF08AyJDtBlo6T2S SUtu3zPsHIzANK5WCi2UBF88fuGxxaaHetcS2IX0ZZuRTlrjI2pfZD0wOcDgEHFeljSrNX8jZs9 jKXE4tuTaqLXe6Oz/8TsUM224jHzcaRW2ar3sOKnscR80fI5218OvHAQBRSj/Fya6WjeEMSHJ8T ykliTdl X-Received: by 2002:a05:6214:1c0b:b0:89a:ff2:b8d4 with SMTP id 6a1803df08f44-89a81ef3356mr69685496d6.36.1773427799050; Fri, 13 Mar 2026 11:49:59 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a65bd318fsm60836326d6.8.2026.03.13.11.49.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 11:49:58 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w17a9-00000007M5A-3jdN; Fri, 13 Mar 2026 15:49:57 -0300 Date: Fri, 13 Mar 2026 15:49:57 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Kevin Tian , Joerg Roedel , Will Deacon , Bjorn Helgaas , Jonathan Cameron , Dan Williams , Alexey Kardashevskiy , Samuel Ortiz , Xu Yilun , Suzuki K Poulose , Steven Price Subject: Re: [PATCH v2 3/3] iommufd/vdevice: add TSM guest request ioctl Message-ID: <20260313184957.GP1704121@ziepe.ca> References: <20260309111704.2330479-1-aneesh.kumar@kernel.org> <20260309111704.2330479-4-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309111704.2330479-4-aneesh.kumar@kernel.org> On Mon, Mar 09, 2026 at 04:47:04PM +0530, Aneesh Kumar K.V (Arm) wrote: > +/** > + * struct iommu_vdevice_tsm_guest_request - ioctl(IOMMU_VDEVICE_TSM_GUEST_REQUEST) > + * @size: sizeof(struct iommu_vdevice_tsm_guest_request) > + * @vdevice_id: vDevice ID the guest request is for > + * @scope: scope of tsm guest request > + * @req_len: the blob size for @req_uptr, filled by guest > + * @resp_len: the blob size for @resp_uptr, filled by guest > + * @req_uptr: request data buffer filled by guest > + * @resp_uptr: response data buffer > + */ This needs a much better kdoc. Refer to specs that define this. Explain WTF scope is > +struct iommu_vdevice_tsm_guest_request { > + __u32 size; > + __u32 vdevice_id; > + __u32 scope; > + __u32 req_len; > + __u32 resp_len; do not leave implicit padding, add a reserved, and check it is 0 Jason