From: David Carlier <devnexen@gmail.com>
To: Namjae Jeon <linkinjeon@kernel.org>, Steve French <smfrench@gmail.com>
Cc: linux-kernel@vger.kernel.org, David Carlier <devnexen@gmail.com>
Subject: [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message
Date: Fri, 13 Mar 2026 21:13:42 +0000 [thread overview]
Message-ID: <20260313211342.137341-1-devnexen@gmail.com> (raw)
The condition checks preferred_send_size > max_recv_size, but the error
message prints "<" instead of ">", making the log misleading when
debugging SMBDirect RDMA negotiation failures.
Signed-off-by: David Carlier <devnexen@gmail.com>
---
fs/smb/common/smbdirect/smbdirect_connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/smb/common/smbdirect/smbdirect_connect.c b/fs/smb/common/smbdirect/smbdirect_connect.c
index b9be2f2f44be..2b54f79dba43 100644
--- a/fs/smb/common/smbdirect/smbdirect_connect.c
+++ b/fs/smb/common/smbdirect/smbdirect_connect.c
@@ -790,7 +790,7 @@ static void smbdirect_connect_negotiate_recv_work(struct work_struct *work)
if (preferred_send_size > sp->max_recv_size) {
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR,
- "invalid: preferred_send_size=%u < max_recv_size=%u\n",
+ "invalid: preferred_send_size=%u > max_recv_size=%u\n",
preferred_send_size,
sp->max_recv_size);
smbdirect_socket_schedule_cleanup(sc, -ECONNABORTED);
--
2.51.0
next reply other threads:[~2026-03-13 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 21:13 David Carlier [this message]
2026-03-14 0:59 ` [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message Namjae Jeon
2026-03-14 2:06 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313211342.137341-1-devnexen@gmail.com \
--to=devnexen@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox