* [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message
@ 2026-03-13 21:13 David Carlier
2026-03-14 0:59 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: David Carlier @ 2026-03-13 21:13 UTC (permalink / raw)
To: Namjae Jeon, Steve French; +Cc: linux-kernel, David Carlier
The condition checks preferred_send_size > max_recv_size, but the error
message prints "<" instead of ">", making the log misleading when
debugging SMBDirect RDMA negotiation failures.
Signed-off-by: David Carlier <devnexen@gmail.com>
---
fs/smb/common/smbdirect/smbdirect_connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/smb/common/smbdirect/smbdirect_connect.c b/fs/smb/common/smbdirect/smbdirect_connect.c
index b9be2f2f44be..2b54f79dba43 100644
--- a/fs/smb/common/smbdirect/smbdirect_connect.c
+++ b/fs/smb/common/smbdirect/smbdirect_connect.c
@@ -790,7 +790,7 @@ static void smbdirect_connect_negotiate_recv_work(struct work_struct *work)
if (preferred_send_size > sp->max_recv_size) {
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR,
- "invalid: preferred_send_size=%u < max_recv_size=%u\n",
+ "invalid: preferred_send_size=%u > max_recv_size=%u\n",
preferred_send_size,
sp->max_recv_size);
smbdirect_socket_schedule_cleanup(sc, -ECONNABORTED);
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message
2026-03-13 21:13 [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message David Carlier
@ 2026-03-14 0:59 ` Namjae Jeon
2026-03-14 2:06 ` Steve French
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2026-03-14 0:59 UTC (permalink / raw)
To: David Carlier; +Cc: Steve French, linux-kernel
On Sat, Mar 14, 2026 at 6:13 AM David Carlier <devnexen@gmail.com> wrote:
>
> The condition checks preferred_send_size > max_recv_size, but the error
> message prints "<" instead of ">", making the log misleading when
> debugging SMBDirect RDMA negotiation failures.
>
> Signed-off-by: David Carlier <devnexen@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message
2026-03-14 0:59 ` Namjae Jeon
@ 2026-03-14 2:06 ` Steve French
0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2026-03-14 2:06 UTC (permalink / raw)
To: Namjae Jeon; +Cc: David Carlier, linux-kernel
Added to ksmbd-for-next
(for 7.1-rc since file does not exist in 7.0-rc3 yet, it depends on
the RDMA/smbdirect patch series in ksmbd-for-next)
On Fri, Mar 13, 2026 at 8:00 PM Namjae Jeon <linkinjeon@kernel.org> wrote:
>
> On Sat, Mar 14, 2026 at 6:13 AM David Carlier <devnexen@gmail.com> wrote:
> >
> > The condition checks preferred_send_size > max_recv_size, but the error
> > message prints "<" instead of ">", making the log misleading when
> > debugging SMBDirect RDMA negotiation failures.
> >
> > Signed-off-by: David Carlier <devnexen@gmail.com>
> Acked-by: Namjae Jeon <linkinjeon@kernel.org>
> Thanks!
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-14 2:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 21:13 [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message David Carlier
2026-03-14 0:59 ` Namjae Jeon
2026-03-14 2:06 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox