From: Rob Herring <robh@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Linus Walleij <linusw@kernel.org>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.og>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
arm-scmi@vger.kernel.org
Subject: Re: [PATCH v3 6/7] dt-bindings: gpio: Add bindings for pinctrl based generic gpio driver
Date: Fri, 13 Mar 2026 19:12:45 -0500 [thread overview]
Message-ID: <20260314001245.GA3706571-robh@kernel.org> (raw)
In-Reply-To: <58446889d781435424c46bac563483e603d7c0e9.1773150895.git.dan.carpenter@linaro.org>
On Wed, Mar 11, 2026 at 10:39:17PM +0300, Dan Carpenter wrote:
> From: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> Add a dt binding for the gpio-by-pinctrl driver. The driver is used
> for doing GPIO over the SCMI pinctrl protocol. There are a few
> mandatory properties such as gpio-ranges and ngpios, but it's not
> mandatory to specify the pin-mux.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> .../bindings/gpio/pin-control-gpio.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml b/Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml
> new file mode 100644
> index 000000000000..81c68579df6e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/pin-control-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Pin control based generic GPIO controller
> +
> +description:
> + The pin control-based GPIO will facilitate a pin controller's ability
> + to drive electric lines high/low and other generic properties of a
> + pin controller to perform general-purpose one-bit binary I/O.
> +
> +maintainers:
> + - Dan Carpenter <dan.carpenter@linaro.og>
> +
> +properties:
> + compatible:
> + const: scmi-pinctrl-gpio
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + gpio-ranges: true
> +
> + ngpios: true
> +
> +patternProperties:
> + "^.+-hog(-[0-9]+)?$":
> + type: object
> +
> + required:
> + - gpio-hog
> +
> +required:
> + - compatible
> + - gpio-controller
> + - "#gpio-cells"
> + - gpio-ranges
> + - ngpios
> +
> +additionalProperties: true
That's only valid for common (incomplete) schemas. It must be false.
> +
> +examples:
> + - |
> + gpio1 {
> + compatible = "scmi-pinctrl-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + ngpios = <10>;
> + gpio-ranges = <&scmi_pinctrl 0 8 4>,
> + <&scmi_pinctrl 4 12 1>,
> + <&scmi_pinctrl 5 15 1>,
> + <&scmi_pinctrl 6 17 4>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_pins>;
> + };
> +
> + gpio2 {
> + compatible = "scmi-pinctrl-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + ngpios = <3>;
> + gpio-line-names = "gpio_5_17", "gpio_5_20", "gpio_5_22", "gpio_2_1";
> + gpio-ranges = <&scmi_pinctrl 0 30 4>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&keys_pins>;
> + };
I think 1 example is enough.
> --
> 2.51.0
>
next prev parent reply other threads:[~2026-03-14 0:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 19:37 [PATCH v3 0/7] gpio: introduce a gpio driver for SCMI Dan Carpenter
2026-03-11 19:38 ` [PATCH v3 1/7] pinctrl: introduce pinctrl_gpio_get_config() Dan Carpenter
2026-03-11 20:30 ` Andy Shevchenko
2026-03-11 21:47 ` Linus Walleij
2026-03-11 19:38 ` [PATCH v3 2/7] pinctrl: scmi: Add SCMI_PIN_INPUT_VALUE Dan Carpenter
2026-03-11 21:46 ` Linus Walleij
2026-03-12 15:27 ` Sudeep Holla
2026-03-11 19:38 ` [PATCH v3 3/7] pinctrl: Delete PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS support Dan Carpenter
2026-03-11 21:48 ` Linus Walleij
2026-03-11 19:38 ` [PATCH v3 4/7] pinctrl-scmi: ignore PIN_CONFIG_PERSIST_STATE Dan Carpenter
2026-03-11 21:49 ` Linus Walleij
2026-03-11 19:39 ` [PATCH v3 5/7] arm_scmi: pinctrl: allow PINCTRL_REQUEST to return EOPNOTSUPP Dan Carpenter
2026-03-11 21:50 ` Linus Walleij
2026-03-12 15:25 ` Sudeep Holla
2026-03-11 19:39 ` [PATCH v3 6/7] dt-bindings: gpio: Add bindings for pinctrl based generic gpio driver Dan Carpenter
2026-03-11 21:53 ` Linus Walleij
2026-03-14 0:12 ` Rob Herring [this message]
2026-03-11 19:39 ` [PATCH v3 7/7] gpio: add " Dan Carpenter
2026-03-11 20:34 ` Andy Shevchenko
2026-03-11 22:00 ` Linus Walleij
2026-03-12 10:41 ` Andy Shevchenko
2026-03-16 21:08 ` Linus Walleij
2026-03-11 21:55 ` Linus Walleij
2026-03-16 9:16 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314001245.GA3706571-robh@kernel.org \
--to=robh@kernel.org \
--cc=akashi.tkhro@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=arm-scmi@vger.kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.og \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox