public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	kees@kernel.org, tony.luck@intel.com, kernel-dev@igalia.com,
	kernel@gpiccoli.net
Subject: Re: [PATCH] pstore/ftrace: Factor KASLR offset in the core kernel instruction addresses
Date: Sun, 15 Mar 2026 10:09:36 -0400	[thread overview]
Message-ID: <20260315100936.33132aab@robin> (raw)
In-Reply-To: <b88aa1bd-5b7c-a31b-fea6-3886099e2fec@igalia.com>

On Fri, 13 Mar 2026 17:57:35 -0300
"Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:


> Hi Steve, this is very interesting! Thanks for pointing that
> infrastructure. And I'm glad it confirms my impression that the full fix
> of that isn't trivial heh
> 
> So, are you suggesting to use the ftrace infrastructure in the
> pstore/ftrace? Well, seeing how mature the ftrace infra is with regards
> the persistent ring buffer, I'd say pstore/ftrace+ramoops gets useless
> now heh

The persistent ring buffer only works when the memory is reliably
consistent between soft reboots. It doesn't work for any other pstore
interface. Thus, if you can rely on normal ram being available across
reboots, then use ftrace. If not, then you have to use pstore. Hence,
it doesn't make pstore useless.

I would not use the ftrace scratchpad for pstore, as if that works,
then just use ftrace ;-)

> 
> The usage then for pstore/ftrace would be more with other backends,
> really low memory cases like ERST or UEFI, for example, in embedded
> maybe. And in this case, saving the full modules name table + offsets
> could incur some precious memory consumption and/or performance impact.
> Or maybe I'm talking nonsense and this would be quite OK ... guess worth
> taking a look.

Exactly (I wrote the above before reading this paragraph!)

-- Steve

> 
> I'll wait a bit more to see what pstore maintainers think about that, if
> is worth to have the very simple KASLR fix or a bit more engineered
> solution that factors modules as well.


  reply	other threads:[~2026-03-15 14:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 20:00 [PATCH] pstore/ftrace: Factor KASLR offset in the core kernel instruction addresses Guilherme G. Piccoli
2026-03-13 20:22 ` Guilherme G. Piccoli
2026-03-13 20:28 ` Steven Rostedt
2026-03-13 20:57   ` Guilherme G. Piccoli
2026-03-15 14:09     ` Steven Rostedt [this message]
2026-03-15 15:02       ` Guilherme G. Piccoli
2026-03-28 21:47 ` Guilherme G. Piccoli
2026-03-31 21:48 ` Kees Cook
2026-04-01 22:28   ` Guilherme G. Piccoli
2026-04-07  3:58 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260315100936.33132aab@robin \
    --to=rostedt@goodmis.org \
    --cc=gpiccoli@igalia.com \
    --cc=kees@kernel.org \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox