From: Erikas Bitovtas <xerikasxx@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Meerwald" <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Erikas Bitovtas <xerikasxx@gmail.com>,
Raymond Hackley <raymondhackley@protonmail.com>
Subject: [PATCH v4 0/7] iio: light: vcnl4000: add regulator support
Date: Mon, 16 Mar 2026 19:19:44 +0200 [thread overview]
Message-ID: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> (raw)
This patch series introduces support for voltage supply, I2C and cathode
regulators. This fixes an issue where if a regulator is shared between
the proximity sensor and some other device, and the other device is
powered off, the proximity sensor would be powered off as well.
One of the commits includes a Reported-by: tag without a Closes: tag -
the report was done outside of LKML.
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
Changes in v4:
- Reworded device tree bindings commit into imperative mood and
clarified where do supplies come from.
- Moved data->chip_spec->set_power_state() calls from init functions to
probe.
- Removed explicit less than 0 checks for ret where unnecessary.
- Moved the patch that adds regulators to the end of the series.
- Added an explanation for removing duplicate prints in probe.
- Fixed indentation for devm_regulator_bulk_get_enable() and i2c_smbus
writes in vcnl4200_init().
- Removed a redundant check for "proximity-near-level" device property.
- Link to v3: https://lore.kernel.org/r/20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com
Changes in v3:
- Added a more detailed description for supplies in the dt-bindings commit.
- Separated sorting includes into a commit of its own.
- Replaced all occurrences of mutex_init with its device-managed
counterpart.
- Moved client->dev variable declaration into a commit for adding
regulators.
- Removed redundant dev_err messages in probe function.
- Replaced all direct usages of client->dev and data->client into usages
by variable.
- Link to v2: https://lore.kernel.org/r/20260312-vcnl4000-regulators-v2-0-2bdebbcbb58a@gmail.com
Changes in v2:
- Removed double quotes in includes.
- Reordered includes alphabetically.
- Enabled regulators before the mutex is initialized.
- Replaced direct usage of &client->dev with a variable.
- Link to v1: https://lore.kernel.org/r/20260311-vcnl4000-regulators-v1-0-66b6038ce563@gmail.com
---
Erikas Bitovtas (7):
dt-bindings: iio: light: vcnl4000: add regulators
iio: light: vcnl4000: sort includes by their name
iio: light: vcnl4000: move power enablement from init to probe
iio: light: vcnl4000: replace mutex_init with devm_mutex_init
iio: light: vcnl4000: remove error messages for trigger and irq
iio: light: vcnl4000: use variables for I2C client and device instances
iio: light: vcnl4000: add support for regulators
.../bindings/iio/light/vishay,vcnl4000.yaml | 7 ++
drivers/iio/light/vcnl4000.c | 90 ++++++++++++----------
2 files changed, 56 insertions(+), 41 deletions(-)
---
base-commit: 6e03baeeb160e6cfd72f2c39f26c50bcd925c7a0
change-id: 20260310-vcnl4000-regulators-bcf1b8a01ce6
Best regards,
--
Erikas Bitovtas <xerikasxx@gmail.com>
next reply other threads:[~2026-03-16 17:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 17:19 Erikas Bitovtas [this message]
2026-03-16 17:19 ` [PATCH v4 1/7] dt-bindings: iio: light: vcnl4000: add regulators Erikas Bitovtas
2026-03-17 7:20 ` Krzysztof Kozlowski
2026-03-17 8:07 ` Erikas Bitovtas
2026-03-17 15:42 ` Krzysztof Kozlowski
2026-03-18 12:47 ` Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 2/7] iio: light: vcnl4000: sort includes by their name Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 3/7] iio: light: vcnl4000: move power enablement from init to probe Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 4/7] iio: light: vcnl4000: replace mutex_init with devm_mutex_init Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 5/7] iio: light: vcnl4000: remove error messages for trigger and irq Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 6/7] iio: light: vcnl4000: use variables for I2C client and device instances Erikas Bitovtas
2026-03-16 20:03 ` Andy Shevchenko
2026-03-16 17:19 ` [PATCH v4 7/7] iio: light: vcnl4000: add support for regulators Erikas Bitovtas
2026-03-16 20:05 ` Andy Shevchenko
2026-03-16 19:59 ` [PATCH v4 0/7] iio: light: vcnl4000: add regulator support Andy Shevchenko
2026-03-16 20:20 ` Erikas Bitovtas
2026-03-16 21:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com \
--to=xerikasxx@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=raymondhackley@protonmail.com \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox