From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3095D33554F for ; Mon, 16 Mar 2026 16:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773677685; cv=none; b=Ta3Rk/rOhSfqiOBCS1e0rUycvlLwfa0PHctWSqSX3oChwNfLtYjrzgUdStO4+xvA29zXDmtZTXS1wohearpoF6kYxc2XUGsfbwDlnsvQQK69eQh2iYoBpa1mJTGCYwQd1q9fgnDljxa+Z9IvTzhoP1joegmA/DKHQvI0szBEVjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773677685; c=relaxed/simple; bh=S5/ArQW3GXTKBgmlBCKBAtBe+DVWxrrUeRrspxmQfeQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O0gQqaQeYGA/8CMk5RuoRPxf0T4mHhqz7nbF90HMPjRVkzJOBognDOG2GwN3UMVSbBWLwARrgfb6FR2PY3MBmT0mGDnDkCAiTgeo2SI/3u2S/bQCjIuyz1JasPOapqqJ4MPGvpboS46YmE7kRH9UhHNsJYwSexoFqmIzauBDhRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id E957D68BFE; Mon, 16 Mar 2026 17:14:41 +0100 (CET) Date: Mon, 16 Mar 2026 17:14:41 +0100 From: Christoph Hellwig To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: Re: [PATCH] nvme-tcp.h: drop kernel-doc comments, fix a few descriptions Message-ID: <20260316161441.GA21005@lst.de> References: <20260314040421.1499586-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260314040421.1499586-1-rdunlap@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Mar 13, 2026 at 09:04:21PM -0700, Randy Dunlap wrote: > Expand @fei into @feil and @feih because the field was split due to it > not being 32-bit aligned. > > Struct member @hdr was described twice in struct nvme_tcp_rsp_pdu, so > drop one of them. > > These structs are defined in a spec outside of the kernel, so kernel-doc > comments for them aren't needed here as well. > > This avoids kernel-doc warnings: I would have just dropped the comment entirely except for a reference to the spec, but let's get the warning fixed instead of bikeshedding for now: Reviewed-by: Christoph Hellwig