From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AAEF3E92B2; Mon, 16 Mar 2026 20:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773691987; cv=none; b=IJFdaAWENQd7lscfJNkzDCrh+WhredXH4ibuyWm+wBY/aNwtxhKV7hewTgAgOtLkPiKQWyNKgX0blgVDgxuCf377MlMHQFfJSO9w/vg/xio7A8yeAjR+st+HozV88MCeWy6pwdrciyjonrWpZYeu12DTxVrZBmCGdfdrzIL0Em0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773691987; c=relaxed/simple; bh=CNG/WxKOmcaQk7ehA4qGRPauU7Y1BgjTuNyXzTcCMKI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fPTt0f9naOldReCCcrbE5JQCknp5bOeU11xVIGMzN23cVcbCR/R6CSG34Rc0Bp0l8kMGLnxoxAHkh97+29mgUmiZn6MlqOsZaUUi0LKrqUnBOkAAgf7wF5RM7POMqGefFQR9L/tqQr1LMEJnprOd5UXqBeETRp5VLbBBUz0RbNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FMDQUOsO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FMDQUOsO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB9D1C19421; Mon, 16 Mar 2026 20:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773691986; bh=CNG/WxKOmcaQk7ehA4qGRPauU7Y1BgjTuNyXzTcCMKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FMDQUOsOEs4zq24dFcEgjGuuu2vouDipBUv7uIBmxCUT8C9nQw8jx0ewqTl4Z6fMh itUwzzsKQsO7d3OWtAp31bGS0hWbhGnMCRhhiQgSON8nOeW5s1lXnPmDJDUcDB51Mn e0aJ8JE3RBe7ZI5Az+PHxaoj75rAXc9IM1KKkLdaYst/uZq7I3yN2nL7X4uyj3kAH8 QEQOtKkf+nj/XXggW05yrSazyPa5uwD1spB+zIfyI6aKHIjBY1ZNKbjCn92tjhSYcu offSKQf9XX/EyrlkvjtUOLtDjRQeJF4Kn+lN1EEzISAvPA5E3h2ZNi73wUtosmZwAa FEzGpHp8E9JoA== Date: Mon, 16 Mar 2026 22:13:01 +0200 From: Leon Romanovsky To: Marco Crivellari Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Michal Hocko , Zhu Yanjun , Jason Gunthorpe Subject: Re: [PATCH] RDMA/rxe: Replace use of system_unbound_wq with system_dfl_wq Message-ID: <20260316201301.GL61385@unreal> References: <20260313154023.298325-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260313154023.298325-1-marco.crivellari@suse.com> On Fri, Mar 13, 2026 at 04:40:23PM +0100, Marco Crivellari wrote: > This patch continues the effort to refactor workqueue APIs, which has begun > with the changes introducing new workqueues and a new alloc_workqueue flag: > > commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") > commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") > > The point of the refactoring is to eventually alter the default behavior of > workqueues to become unbound by default so that their workload placement is > optimized by the scheduler. > > Before that to happen, workqueue users must be converted to the better named > new workqueues with no intended behaviour changes: > > system_wq -> system_percpu_wq > system_unbound_wq -> system_dfl_wq > > This way the old obsolete workqueues (system_wq, system_unbound_wq) can be > removed in the future. I recall earlier efforts to replace system workqueues with per‑driver queues, because unloading a driver forces a flush of the entire system workqueue, which is undesirable for overall system behavior. Wouldn't it be better to introduce a local workqueue here and use that instead? Thanks > > Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/ > Suggested-by: Tejun Heo > Signed-off-by: Marco Crivellari > --- > drivers/infiniband/sw/rxe/rxe_odp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_odp.c b/drivers/infiniband/sw/rxe/rxe_odp.c > index bc11b1ec59ac..d440c8cbaea5 100644 > --- a/drivers/infiniband/sw/rxe/rxe_odp.c > +++ b/drivers/infiniband/sw/rxe/rxe_odp.c > @@ -545,7 +545,7 @@ static int rxe_ib_advise_mr_prefetch(struct ib_pd *ibpd, > work->frags[i].mr = mr; > } > > - queue_work(system_unbound_wq, &work->work); > + queue_work(system_dfl_wq, &work->work); > > return 0; > > -- > 2.53.0 >