public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Peter Rosin <peda@axentia.se>, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] mux: mmio: Zero the allocated memory
Date: Tue, 17 Mar 2026 14:33:56 +0100	[thread overview]
Message-ID: <2026031710-implicit-hungrily-3b47@gregkh> (raw)
In-Reply-To: <20260317124826.233006-2-krzysztof.kozlowski@oss.qualcomm.com>

On Tue, Mar 17, 2026 at 01:48:27PM +0100, Krzysztof Kozlowski wrote:
> Zero the allocated memory in probe() for fields and states for increased
> code safety and to match expected Linux coding style.

What "style"?  I'm all for zeroing out memory to start with, but as this
has lived for so long without this, are you sure it's still needed?  Are
there uninitialized fields in here that we are now properly
initializing?

thanks,

greg k-h

  reply	other threads:[~2026-03-17 13:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 12:48 [RESEND PATCH] mux: mmio: Zero the allocated memory Krzysztof Kozlowski
2026-03-17 13:33 ` Greg Kroah-Hartman [this message]
2026-03-17 14:39   ` Krzysztof Kozlowski
2026-03-17 14:42     ` Greg Kroah-Hartman
2026-03-17 15:15       ` Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2026-03-01 14:17 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026031710-implicit-hungrily-3b47@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox