From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39F302BCF5D for ; Tue, 17 Mar 2026 13:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773754849; cv=none; b=ZQk4++j3UKcMro50nutW5A9itR2JsgvvBeHru6CCM0pqmtbRKmUla/XCiuC6PHp6pYvMUfeUDYvYTUvY8U+MdawrjRMt1SKwIjTvaPl/aijlkjyA81LiYUnA1Y6GF7bZ6E95oUXz8lM2wFibNjezLypNK8GyuUB5xVsuexsu2Nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773754849; c=relaxed/simple; bh=E5f8YhOH9Wr2D7e0J8VAYdwFHGMG8PSd6yQTrLb4iZo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jomug7gu7+YCQoS8J4TBfNAK4APP/EsqbBOYQo6YgxjkOcScfW2CRDhEsptOMkBZnkM6r0MF6jq1d0jKiPH8zCKoevefvP/HMB+rNzkcDsMviEixKg1Ahe6+Bhch8RYqIT1ykxABuPkKWLRmwvPVedpxq0HHMrcuT79lpgT/Iyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AuFSRH3E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AuFSRH3E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 894F0C4CEF7; Tue, 17 Mar 2026 13:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773754849; bh=E5f8YhOH9Wr2D7e0J8VAYdwFHGMG8PSd6yQTrLb4iZo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AuFSRH3E2epV3X4ZFWMfv7Nz5IXHkTI4Jo79mDlHLOi7prgUyIF6WIjrO+3z46WAB y7Fh33xrJHLLZx7eLTnQD2qJKYF8GJ1/zWTXFhFNZJTXgHzlX+qqrpQtQ0k1QXP8CU TDJ5fQvwjgXEmhOivHVso6a7AxYmN1CfKa30C4rA= Date: Tue, 17 Mar 2026 14:33:56 +0100 From: Greg Kroah-Hartman To: Krzysztof Kozlowski Cc: Peter Rosin , linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] mux: mmio: Zero the allocated memory Message-ID: <2026031710-implicit-hungrily-3b47@gregkh> References: <20260317124826.233006-2-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317124826.233006-2-krzysztof.kozlowski@oss.qualcomm.com> On Tue, Mar 17, 2026 at 01:48:27PM +0100, Krzysztof Kozlowski wrote: > Zero the allocated memory in probe() for fields and states for increased > code safety and to match expected Linux coding style. What "style"? I'm all for zeroing out memory to start with, but as this has lived for so long without this, are you sure it's still needed? Are there uninitialized fields in here that we are now properly initializing? thanks, greg k-h