From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013054.outbound.protection.outlook.com [40.107.201.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DF742D8DB1 for ; Tue, 17 Mar 2026 13:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.54 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773755141; cv=fail; b=ozR4fjaJI7DFomJkzwfM3eNIxqrz8GRenlTEKEiO18HvjLq3Q4hJ9ZVkLZsJrS87oQFJpezMiEtreoC2VPO59EjO17KcDJTwTJSFFSLvuSqmbwyjaNKRNN06HYyf21iSn0Y+srZaqiMRWljFpWiY5d0FTPurdvz0UF5TxnIgwd4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773755141; c=relaxed/simple; bh=9XBzq9UuHqAAfcXtOaTYuLuFD+c4X0fzMmLS0jWmND4=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tFq2UkeXU0K1Xauvs4a+uurpDEl9h26rkRnmx0/ByRMYfuBaOQKERyINbtuzw9zAFlYacwd5X+jGLgpXYpWu2lm+tn6+46feoUoaK37J7wqBeB9hTmQeZV6N7Ac2PP5DmRb18WiqFYDxl5ZsMHOjfLOGLTJ9nNYmcTIDE7GQ0u8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=fail (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=fail (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=GcO1oFgz reason="signature verification failed"; arc=fail smtp.client-ip=40.107.201.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="GcO1oFgz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l13wot9nzAc/wmYOk4hHIa3adnQaD9+iQZ9KC8lZJVlP8LVDd9WpfZCBENRLe9G3OmTDhSJl/uiL88tW0SJU7Dsw0lomcfcuB7Du2B4NyDS3wj8ulchQ6SfdM09ZQ0VDnZjHSnjMnZbAzAYxBYdgyRnIZzAJc2N/nMi/IifWPgyPWljmyHMO0Ce/x3OhPL2FMwacsyWUEcejJ7a82GZUrTnF8HSa5bV8WqUcqCXGQQy8y+vjxsbevjEj35kZaRIoBpkc5SnSvIN5w/LHKkogC0N/RtmRrF4u8Uuab0xfMLGjHOPNgzPNQWyV/eil4GMO3IP/tJXsi4kDmOlx9WlY0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TZ8q1Gr2sBie0HpFJh+zk3S264yKHkq8RdPcNUoZ1Ec=; b=eqi28mCu+4/+dH6N4xYd7+Xe4tqQb5QZhsVUiVVn/lgFgVWfF1Gk6Aij6BFdiN2jkSgbtgWTIKcwbl6QBishrS8DRK79HB/AaZDepwRhlW55AR58Ymqcjx32m1shKrqV4f5Gz/VZ65CACBPhhyRuoFFZ0UAUr9XK36i9rsEq6wM7PPO/VbubZf4sgJxJ3KRIgFFiizKpd+XR0hh9u4moqK1TQhvbcLz2tDcaKEvACksBxtA0bENt5wo5k3dIS2uVQ3IiLowL+LimYpLzBaUiEjUgb+jncGazllznh7yCI3BrRammbIQqoKGsj2182HpmU6Km9edoyBRN3s05dhwObA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TZ8q1Gr2sBie0HpFJh+zk3S264yKHkq8RdPcNUoZ1Ec=; b=GcO1oFgzh2qBX662EsKBhXl3+Ifa9fMpkKnmdjJUOcXC2Vw7hOEsjF7oGbXc4sLTOBYCYxtIz1izbSe8B4JoHIKBVlzFsqalQA6sUaOcjfZqQmoHURA9E6tbL3s1xasJKQNWh7XLov3+3f9WrAcYINL8C4OWXjVeQK+B9xJVGZvE3XqB4h2SfoxIoUohG5za99RZ5Ug1YMfBkQTUdKf3JyajFSIWxzo6s1XhgERpG0yuhJa0UmfHOUuZZ+vD+4zkehs2QbEkrJs6xcg61jR5CRAiCnCcxmwOo7dxHlcZLJLqlLxe5UsDPXOp8GFDSsibOgKdsnM4s1Vo7DJiWshSgA== Received: from CYZPR14CA0042.namprd14.prod.outlook.com (2603:10b6:930:a0::18) by MW5PR12MB5599.namprd12.prod.outlook.com (2603:10b6:303:194::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.17; Tue, 17 Mar 2026 13:45:35 +0000 Received: from CY4PEPF0000FCC4.namprd03.prod.outlook.com (2603:10b6:930:a0:cafe::4f) by CYZPR14CA0042.outlook.office365.com (2603:10b6:930:a0::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9700.27 via Frontend Transport; Tue, 17 Mar 2026 13:45:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000FCC4.mail.protection.outlook.com (10.167.242.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.17 via Frontend Transport; Tue, 17 Mar 2026 13:45:34 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 17 Mar 2026 06:45:14 -0700 Received: from localhost (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 17 Mar 2026 06:45:12 -0700 Date: Tue, 17 Mar 2026 15:45:09 +0200 From: Leon Romanovsky To: Mika =?iso-8859-1?Q?Penttil=E4?= CC: "David Hildenbrand (Arm)" , , , Jason Gunthorpe , "Alistair Popple" , Balbir Singh , Zi Yan , Matthew Brost Subject: Re: [PATCH v5 2/6] mm: Add helper to convert HMM pfn to migrate pfn Message-ID: <20260317134509.GZ61385@unreal> References: <20260211081301.2940672-1-mpenttil@redhat.com> <20260211081301.2940672-3-mpenttil@redhat.com> <3c0578a9-ce1c-4d26-86d5-681cae4b8200@kernel.org> <59d3c0e5-23fb-4a30-825a-d90fd07bd34e@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <59d3c0e5-23fb-4a30-825a-d90fd07bd34e@redhat.com> X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC4:EE_|MW5PR12MB5599:EE_ X-MS-Office365-Filtering-Correlation-Id: cd3f06aa-1972-4c5a-20e9-08de842b771b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|36860700016|7053199007|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: wOmnnxID5tXzG0olRSRunfCmqCPkGgnKg/pE4u+4qPVbwBnQ3Vd9J7brqTgtUxP521SnG7M3MgIG2c1oEjDFKG8irjvQXoHCEpPS5YL2Eq/dlp3QDfxcSx7DBDgG3zJQphGiFXzX1pYAG7jOhNgPR85hJkPtipk9VDWAfVirw99aAI2fUWUVP41SBL99ZnEDrw4ip0kFVau4o6WcIe7d4evoMSSYsjVB0fzwtu6uI7g19qzB5qNahTmAw+H4/+F9fn5SU3y2p4i6e19JTDTTAhhEhqi4tdFt+kc2n46toNc6edus+tzmbVK2tlCFkafyVvT+yufoNFbEs3S7Wz74iJFzGasq803AJdW5Lto60Ez5RRY6tBK5fJF61g47ZJ7X5NpvTAoZU3m/9JWwxLjv9sTVAdE5xUKPygO6r36b4fTrpcZtQAR+lmoU09h3ONdjnVms+tQMWoOYqT9+YGA3fMZOUK3S6G66MDBEDspRqwNXTeWOLe9qR2A3NtCWCAL4PV+mj8plljafUANWkh7nMQQIY2jjIwtvdVp+/+viNs4oD2j/HZXlkdKucaY2hscR9FpLzpd2YwngJ/pzzBcHTSLb1FhG1VTn/krZ3EbRM5tw8qsKPf2dCzzx9Ny6C4OPzUKDdLbcrCEMbUkp5LZCyQ3qpzpQHBDAp5jLdm+nHVHQmeJ/l5fb5ML4QN4a1+Xwye+hn/VX8mByK1dkKiOH5oAxsHclspDXsY2ub444Jhi8OU9lFIpogTRq9Yhg6nUVEzBsUMpvIr2/+b3aS2IxGA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(36860700016)(7053199007)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5sG+nW5936lSW5IMfV+Nq2IW8rbDl9geDm9QHvdS/PV3OqK/24N/MjslBnPwbkJPyjtPewMmm5BK3GBrCCnCRrwF8kpDYKESj0xr1ILtzdFpQfu6Yx3ZWl7nMlLUQquKRXDaI+WjARUvisiQXyH+5tCjBns2xIPb7iHdmHvIkoGUZqM/5zs780U0wVtq1mwsWAt93dwaQYzb2klKdxmw1pu6pDNCDJ19UM6z5JW/UdBcqLNsBCmH/+wbhKa5/4qt0faPB5xDVzg4bGAxt4uH/53K1cuuHgLdbxsNcibeIVyXtuyhGIbwkKLI/JAEB69LRiQKJB+wlPaLFKxfcdt2GPeRwwVUEYElYDF9YCpZ7Mtzihj8Ti2cm9RGwj63mCCvVP0hT+TgpPn+Cb6m56x4H1NMWJmAeGSe12KIbAg4U7sJG35A9UwVPft8l6gzt79l X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2026 13:45:34.8732 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd3f06aa-1972-4c5a-20e9-08de842b771b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5599 On Tue, Mar 17, 2026 at 03:01:09PM +0200, Mika Penttilä wrote: > Hi, > > On 3/17/26 11:05, David Hildenbrand (Arm) wrote: > > > On 2/11/26 09:12, mpenttil@redhat.com wrote: > >> From: Mika Penttilä > >> <...> > >> enum hmm_pfn_flags { > >> /* Output fields and flags */ > >> @@ -48,15 +50,25 @@ enum hmm_pfn_flags { > >> HMM_PFN_P2PDMA = 1UL << (BITS_PER_LONG - 5), > >> HMM_PFN_P2PDMA_BUS = 1UL << (BITS_PER_LONG - 6), > >> > >> - HMM_PFN_ORDER_SHIFT = (BITS_PER_LONG - 11), > >> + /* Migrate request */ > >> + HMM_PFN_MIGRATE = 1UL << (BITS_PER_LONG - 7), > >> + HMM_PFN_COMPOUND = 1UL << (BITS_PER_LONG - 8), > >> + HMM_PFN_ORDER_SHIFT = (BITS_PER_LONG - 13), Please don't add fields which are not flags to enum hmm_pfn_flags. Thanks > >> > >> /* Input flags */ > >> HMM_PFN_REQ_FAULT = HMM_PFN_VALID, > >> HMM_PFN_REQ_WRITE = HMM_PFN_WRITE, > >> + HMM_PFN_REQ_MIGRATE = HMM_PFN_MIGRATE, > >> > >> HMM_PFN_FLAGS = ~((1UL << HMM_PFN_ORDER_SHIFT) - 1), > >> }; > >>