From: Christoph Hellwig <hch@lst.de>
To: YunJe Shin <yjshin0438@gmail.com>
Cc: hare@suse.de, cleech@redhat.com, hch@lst.de,
ioerts@kookmin.ac.kr, kbusch@kernel.org, kch@nvidia.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
sagi@grimberg.me, stable@kernel.org
Subject: Re: [PATCH v2] nvmet: auth: validate dhchap id list lengths
Date: Tue, 17 Mar 2026 15:51:37 +0100 [thread overview]
Message-ID: <20260317145137.GA6462@lst.de> (raw)
In-Reply-To: <20260313052444.3865842-1-ioerts@kookmin.ac.kr>
On Fri, Mar 13, 2026 at 02:24:09PM +0900, YunJe Shin wrote:
> + /*
> + * idlist[0..29]: hash IDs
> + * idlist[30..59]: DH group IDs
> + */
> + if (data->auth_protocol[0].dhchap.halen > NVME_AUTH_DHCHAP_MAX_HASH_IDS ||
> + data->auth_protocol[0].dhchap.dhlen > NVME_AUTH_DHCHAP_MAX_DH_IDS)
Overly lone lines. A local variable for data->auth_protocol[0].dhchap
would really help with readability here.
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index b09dcaf5bcbc..ea0393ab16fc 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -1824,6 +1824,8 @@ struct nvmf_auth_dhchap_protocol_descriptor {
> __u8 dhlen;
> __u8 idlist[60];
> };
> +#define NVME_AUTH_DHCHAP_MAX_HASH_IDS 30
> +#define NVME_AUTH_DHCHAP_MAX_DH_IDS 30
Tabs before the values. Bonus points for a reference to the relevant
spec.
next prev parent reply other threads:[~2026-03-17 14:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 6:58 [PATCH] nvmet: auth: validate dhchap id list lengths(KASAN: slab-out-of-bounds) YunJe Shin
2026-02-12 1:49 ` yunje shin
2026-02-18 4:04 ` yunje shin
2026-03-08 15:09 ` yunje shin
2026-03-09 18:04 ` Chris Leech
2026-03-10 17:48 ` yunje shin
2026-03-10 17:52 ` yunje shin
2026-03-10 18:07 ` Chris Leech
2026-03-10 19:06 ` yunje shin
2026-03-10 20:34 ` Chris Leech
2026-03-12 7:01 ` Hannes Reinecke
2026-03-13 5:24 ` [PATCH v2] nvmet: auth: validate dhchap id list lengths YunJe Shin
2026-03-13 15:30 ` Chris Leech
2026-03-17 14:51 ` Christoph Hellwig [this message]
2026-03-17 16:55 ` yunje shin
2026-03-20 7:49 ` Christoph Hellwig
2026-03-20 8:13 ` yunje shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317145137.GA6462@lst.de \
--to=hch@lst.de \
--cc=cleech@redhat.com \
--cc=hare@suse.de \
--cc=ioerts@kookmin.ac.kr \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@kernel.org \
--cc=yjshin0438@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox