From: Josh Law <objecting@objecting.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Josh Law <objecting@objecting.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] lib/bch: fix signed shift overflow in build_mod8_tables
Date: Wed, 18 Mar 2026 07:48:06 +0000 [thread overview]
Message-ID: <20260318074806.16527-3-objecting@objecting.org> (raw)
In-Reply-To: <20260318074806.16527-1-objecting@objecting.org>
Cast loop variable to unsigned int before left-shifting to avoid
undefined behavior when i >= 128 and b == 3 (i << 24 overflows
signed int).
Signed-off-by: Josh Law <objecting@objecting.org>
---
lib/bch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/bch.c b/lib/bch.c
index ef733f08082f..c991c71c4cbd 100644
--- a/lib/bch.c
+++ b/lib/bch.c
@@ -1116,7 +1116,7 @@ static void build_mod8_tables(struct bch_control *bch, const uint32_t *g)
for (b = 0; b < 4; b++) {
/* we want to compute (p(X).X^(8*b+deg(g))) mod g(X) */
tab = bch->mod8_tab + (b*256+i)*l;
- data = i << (8*b);
+ data = (unsigned int)i << (8*b);
while (data) {
d = deg(data);
/* subtract X^d.g(X) from p(X).X^(8*b+deg(g)) */
--
2.34.1
prev parent reply other threads:[~2026-03-18 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 7:48 [PATCH 0/2] lib/bch: fix undefined behavior from signed left-shifts Josh Law
2026-03-18 7:48 ` [PATCH 1/2] lib/bch: fix signed left-shift undefined behavior Josh Law
2026-03-18 7:48 ` Josh Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318074806.16527-3-objecting@objecting.org \
--to=objecting@objecting.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox