From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F266936EAB0 for ; Wed, 18 Mar 2026 07:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773820621; cv=none; b=sMoDLZWKYab9x6owS79zGEOTsiRblnipGhGgk5yubSrcBWbGpFonCySF4DgwuHsUmfL/K3Atf4gjDzHnfJ7gpkUoG+cmfAfldQ6pzoO9rqMNtyOfef7rlto1lHIWuB5B7AhlMNoJsikTZVMgf9q/bjDyf/eJlGGEUuBun5oiLAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773820621; c=relaxed/simple; bh=ObYsugb5IWp4OVetKeyt2DqnWazvn6B9MZDHHw9XhqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F2BdTsVq+Ho7O+DC0+2zXriGS0g8LAStkYbRgxZFpcuhagj5UqI2ehyqomgDh9vPCTVE69kCG1HH6WNkGVhoiTRcQx8DbsUxXr3R6v4CDsSzhuC7ZhFsuWhyqxDRiDBSuuUMye9+0aEEDb4Rr7Zzi8ItR/YiZeFHMmLrkoL96D8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id C31DA68BEB; Wed, 18 Mar 2026 08:56:55 +0100 (CET) Date: Wed, 18 Mar 2026 08:56:55 +0100 From: Christoph Hellwig To: alistair23@gmail.com Cc: hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Alistair Francis , Kamaljit Singh , yjshin0438@gmail.com Subject: Re: [PATCH v3] nvme-auth: Don't propose NVME_AUTH_DHGROUP_NULL with SC_C Message-ID: <20260318075655.GA25711@lst.de> References: <20260318004658.3681991-1-alistair.francis@wdc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318004658.3681991-1-alistair.francis@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Mar 18, 2026 at 10:46:58AM +1000, alistair23@gmail.com wrote: > + idlist[dh_list_offset++] = NVME_AUTH_DHGROUP_6144; > + idlist[dh_list_offset++] = NVME_AUTH_DHGROUP_8192; > + data->auth_protocol[0].dhchap.dhlen = dh_list_offset - DH_GID_LIST_OFFSET; Still an overly long line here. > > return size; > } > diff --git a/include/linux/nvme.h b/include/linux/nvme.h > index 655d194f8e72..bd540ef33b63 100644 > --- a/include/linux/nvme.h > +++ b/include/linux/nvme.h > @@ -2332,4 +2332,6 @@ enum nvme_pr_change_ptpl { > > #define NVME_PR_IGNORE_KEY (1 << 3) > > +#define DH_GID_LIST_OFFSET 30 Note that we have a target side patch ("nvmet: auth: validate dhchap id list lengths") also adding defines related to this, but in a different place and using different naming: +#define NVME_AUTH_DHCHAP_MAX_HASH_IDS 30 +#define NVME_AUTH_DHCHAP_MAX_DH_IDS 30 Back in the day we usually did nvme.h patch separately to handle these kinds of conflicts a little better. YunJe/Alistair, maybe whoever resends next should split this out, add all the required values and add a pointer to the spec?