public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex@shazbot.org>
To: Ted Logan <tedlogan@fb.com>
Cc: David Matlack <dmatlack@google.com>,
	Shuah Khan <shuah@kernel.org>, <kvm@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Matt Evans <mattev@meta.com>,
	alex@shazbot.org
Subject: Re: [PATCH] vfio: selftests: Build tests on aarch64
Date: Wed, 18 Mar 2026 16:55:13 -0600	[thread overview]
Message-ID: <20260318165513.49c3830d@shazbot.org> (raw)
In-Reply-To: <20260317-vfio-selftests-aarch64-v1-1-2266077563e7@fb.com>

On Tue, 17 Mar 2026 16:25:18 -0700
Ted Logan <tedlogan@fb.com> wrote:

> Also build vfio self-tests on aarch64 variants, in addition to arm64 and
> x86_64.
> 
> Reported-by: Matt Evans <mattev@meta.com>
> Closes: https://lore.kernel.org/all/e51b4ff2-13c4-47d4-b781-3dcbd740d274@meta.com/
> ---
> Signed-off-by: Ted Logan <tedlogan@fb.com>

Careful, this is a good way to get your Sign-off lost in the tooling.

> ---
>  tools/testing/selftests/vfio/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> index 8e90e409e91d..98bc8d6271a4 100644
> --- a/tools/testing/selftests/vfio/Makefile
> +++ b/tools/testing/selftests/vfio/Makefile
> @@ -1,4 +1,4 @@
> -ARCH ?= $(shell uname -m)
> +ARCH ?= $(shell uname -m | sed -e 's/aarch64.*/arm64/')

Are we intentionally enabling aarch64_be with this glob or is that just
carry-over from similar in the mm selftest Makefile?

Big endian ARM64 support is really not on my radar for vfio, but it
wouldn't be our first foray into big endian systems.

If it wasn't intentional, maybe just add "aarch64" to the below filter
list directly.  Thanks,

Alex
 
>  ifeq (,$(filter $(ARCH),arm64 x86_64))
>  # Do nothing on unsupported architectures
> 
> ---
> base-commit: 96ca4caf9066f5ebd35b561a521af588a8eb0215
> change-id: 20260317-vfio-selftests-aarch64-636abf0f7674
> 
> Best regards,


  reply	other threads:[~2026-03-18 22:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 23:25 [PATCH] vfio: selftests: Build tests on aarch64 Ted Logan
2026-03-18 22:55 ` Alex Williamson [this message]
2026-03-19 13:51   ` Matt Evans
2026-03-19 14:37     ` Alex Williamson
2026-03-19 15:01       ` Matt Evans
2026-03-19 17:59 ` David Matlack
2026-03-19 22:55   ` Ted Logan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318165513.49c3830d@shazbot.org \
    --to=alex@shazbot.org \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mattev@meta.com \
    --cc=shuah@kernel.org \
    --cc=tedlogan@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox