Re: [PATCH v5 3/9] pci: pwrctrl: rename pci-pwrctrl-slot as generic

Manivannan Sadhasivam
2026-03-05T07:24:40Z

On Fri, Feb 20, 2026 at 04:04:42PM +0100, Neil Armstrong wrote:
> The driver is pretty generic and would fit for either
> PCI Slots or endpoints connected to PCI ports, so rename
> the driver and module as pci-pwrctrl-generic.
>
> Suggested-by: Manivannan Sadhasivam <mani@kernel.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

One comment below, but that can be fixed while applying. So,

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

> ---
> drivers/pci/controller/dwc/Kconfig | 4 +-
> drivers/pci/pwrctrl/Kconfig | 13 ++--
> drivers/pci/pwrctrl/Makefile | 4 +-
> drivers/pci/pwrctrl/generic.c | 139 +++++++++++++++++++++++++++++++++++++
> drivers/pci/pwrctrl/slot.c | 137 ------------------------------------
> 5 files changed, 150 insertions(+), 147 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index d0aa031397fa..4bd36e133ca6 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -309,7 +309,7 @@ config PCIE_QCOM
> select CRC8
> select PCIE_QCOM_COMMON
> select PCI_HOST_COMMON
> - select PCI_PWRCTRL_SLOT
> + select PCI_PWRCTRL_GENERIC
> help
> Say Y here to enable PCIe controller support on Qualcomm SoCs. The
> PCIe controller uses the DesignWare core plus Qualcomm-specific
> @@ -431,7 +431,7 @@ config PCIE_SPACEMIT_K1
> depends on ARCH_SPACEMIT || COMPILE_TEST
> depends on HAS_IOMEM
> select PCIE_DW_HOST
> - select PCI_PWRCTRL_SLOT
> + select PCI_PWRCTRL_GENERIC
> default ARCH_SPACEMIT
> help
> Enables support for the DesignWare based PCIe controller in
> diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig
> index cd3aa15bad00..ff67bec5b500 100644
> --- a/drivers/pci/pwrctrl/Kconfig
> +++ b/drivers/pci/pwrctrl/Kconfig
> @@ -11,17 +11,18 @@ config PCI_PWRCTRL_PWRSEQ
> select POWER_SEQUENCING
> select PCI_PWRCTRL
>
> -config PCI_PWRCTRL_SLOT
> - tristate "PCI Power Control driver for PCI slots"
> +config PCI_PWRCTRL_GENERIC
> + tristate "Generic PCI Power Control driver for PCI slots and endpoints"
> select POWER_SEQUENCING
> select PCI_PWRCTRL
> help
> - Say Y here to enable the PCI Power Control driver to control the power
> - state of PCI slots.
> + Say Y here to enable the generic PCI Power Control driver to control
> + the power state of PCI slots and endpoints.
>
> This is a generic driver that controls the power state of different
> - PCI slots. The voltage regulators powering the rails of the PCI slots
> - are expected to be defined in the devicetree node of the PCI bridge.
> + PCI slots and endpoints. The voltage regulators powering the rails
> + of the PCI slots or endpoints are expected to be defined in the
> + devicetree node of the PCI bridge.

'PCI bridge or endpoint'

- Mani

--
மணிவண்ணன் சதாசிவம்