From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B28E233D4E1 for ; Wed, 18 Mar 2026 20:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773866078; cv=none; b=GS9HRlpkgtlL3bZUfzRa5NOfjPflLJXP8EPGMtoQ1hNP9KODqpjjYljbTIxCM6qwHz4paxpg21axDhbbtgRu0FLoIWLiQaVmexOKJtXGBDgMC2jdfRWm+J9zSwiWgbzvB9ByeXbBDQ8Hif5Mtaj8M8NG9Iq3zbDp/opVoVLEQW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773866078; c=relaxed/simple; bh=H3dtoeeF9fKJqFeiqL/uOhl0k3hSOOrsTGPw7ECXWEo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mRix3AjkojWI42DnYtOPKZxZbO7/MQ31wpZOozf55uvSD4XKjbmxKUl3rNjw7Acg78YEFMGs2c8l37hID7uL/zhgy8e9Qz6DttOUPsez5rA2p3oCI3l2ExgN0e1hrUElJ5QED1cVXXd+ITFxJANd6bLvj+TKr9CO/DcV57GXaTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=c+kW2NGo; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="c+kW2NGo" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xOVOGn454xaGo45sycUMxECeLyDqCxGOp1cYYvZFdrI=; b=c+kW2NGo77HQMFbMrm2mclnIfu r/hwis/MhL5wWPY8Gs9WbWOOkktc1KnLZWJgwkPfoA0wX2RB8rSxK1KAU+oC3SK+aodcf2EF7fLGn 3oVQBxV0YXUDtMFSSB68j3ynRCPBvmpTu6F1o7lFlYFl/j4nfUa3Aiji61JumdSh5DVF7Z/yDHJwN fX9X+clPtHUEitvCyDh1kdgFZOEocext3sPSeoEw5VKF9cgncZ9telorsEtxJZCqSsQW6sRSRdrdJ WhCUrJY9W1cKg7trafFgxxuX7Dh4p0xO1WjZh5+kC6xNDQ9XjM2B2pIi6ywUWa0E4W6Fu7872Q+QD eSTqkuMw==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2xau-0000000CDzM-49rn; Wed, 18 Mar 2026 20:34:21 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id B46773004F8; Wed, 18 Mar 2026 21:34:19 +0100 (CET) Date: Wed, 18 Mar 2026 21:34:19 +0100 From: Peter Zijlstra To: John Stultz Cc: K Prateek Nayak , LKML , Joel Fernandes , Qais Yousef , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Mel Gorman , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , Thomas Gleixner , Daniel Lezcano , Suleiman Souhlal , kuyo chang , hupu , kernel-team@android.com Subject: Re: [PATCH v25 1/9] sched: Make class_schedulers avoid pushing current, and get rid of proxy_tag_curr() Message-ID: <20260318203419.GN3738010@noisy.programming.kicks-ass.net> References: <20260313023022.2902479-1-jstultz@google.com> <20260313023022.2902479-2-jstultz@google.com> <20ea3670-c30a-433b-a07f-c4ff98ae2379@amd.com> <20260318133640.GJ3738010@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 18, 2026 at 01:30:17PM -0700, John Stultz wrote: > Yeah, this looks equivalent to what I had in my patch linked above. > I'll go ahead and take your version though. > > The only tweak I might consider is setting the prev_donor along with > prev, so we don't have to move the rq_set_donor() call to be on both > sides of the sched_proxy_exec() conditional. > > Feels much simpler to read, and I'd hope the compiler would optimize > the extra assignment away if it were unused at compile time. But maybe > there is a concern you have I'm missing? So my goal was to capture as much of the PE specific stuff inside that sched_proxy_exec() branch. Having to push that rq_set_donor() into the else branch was a little unfortunate, but keeping it all inside that branch makes that we can easily break that out into its own function.