From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A5062D9EEA for ; Wed, 18 Mar 2026 22:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773874356; cv=none; b=t/dIYZHqXBCEtHDpdahMpCxtvaqDrtyp18xoqb1qMQlFpXxNu4mWOcmzReimISypLjVMz4pymN+FN5yo6oMr0IkZCJNutoQRfFvx6qdRIug8s0TP+LL8sWRyWJqYw0xDqjsiMggFbwQAfhQSo5OESc3E5Dos1gCbeXQUnuG1TpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773874356; c=relaxed/simple; bh=r94ekbBnB/YT1f6vWPhxo8I0UjxIWFxfzPU71eTV4zQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=evehsQe67sV2sJsMmX8OdFU7S89HQ9YUjwoxF31SL4LZUEVWlEn4eJkoIhP80qsddzrjCtjGwgowHTNW1uoB5jTFiJyzWQJBWg8pRJv6w2ZWU0s3QAOYIDUSmNRQslsFcgQsDAeeofNb/O8Ro85bQo+G21EMvmrcLR0e8KIjyuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CCrnl8/M; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CCrnl8/M" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-43b4d73463dso192275f8f.3 for ; Wed, 18 Mar 2026 15:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773874353; x=1774479153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=U1adgD7hBkrbnKeB5MC1p4RlzAgTicg+AvI0veQP4CU=; b=CCrnl8/Mc/y3mysJyywyu++fRY3mfni9baAzta7VmDRKdBXr79RNLD+WeSRQZk/v0X tvwcIW6huMFPoKNUcbe7l2CqWbIDhK4eprBxr7gJHZ6TiqsSUATFb1sOP74SV5i/zwcf dq8C6JqjKzM4W2aGSDB/MnbN7BkhZYmIWyqxkDHLKqAh6nn1WGHzWk7dJe8wfcWx7c4J shT4UqnLQt6BiBTgnPGO44JQTstAUIHQHkp/47o/2+RaNfX7ZzMoWSIgIvGg5V8gWSES rz6V0t/c63+CBZSOLT8l09XRTuywCRNyNLmcVQIeOP8sfdRuwr7AUp32QbD31fTUellg Qgxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773874353; x=1774479153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U1adgD7hBkrbnKeB5MC1p4RlzAgTicg+AvI0veQP4CU=; b=XWe7URpz+vo3ETM+yQKkvDsXl36gWzqVpZtZ2VFNfw1lkliwS5MUsrtIg/ttdbOHOQ ix1L9YZRs4fAJ38dU+aDyO1L4LoSnRenGUcKLr7/oZtzSTEtkZRTFKCKGUNxMQ2E7TEL KOMyMVmB3DraglwwBAE1Sk1XeMQiAVo1DyJiWFiDHBKK2MmTOLxIXcyFFd4DCtrO5/Ll JNbQFAwD9SOc6KCvSe040GRPSWZBEYvQ0tFhL3vG4gbxHefoVbS8we8Nnj6rwJ21/mfp J6kIzRNFd1LjgQ8MG9dKmXRx7msrrEHsG5k4Io96qI+qybMdSBRMcSYfXsKU4bMn3+Nx tJgQ== X-Forwarded-Encrypted: i=1; AJvYcCXAk4YTAbjvisnvub/XVTqS73qK0DQntHz2EfLoVftrnLfCHefOVDnF5EPeLHyoL8JCUAttdMWuTYYP2dI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1j9nuw4dljGe8O+3K5edEbJx1yEUwru6POCjeyru6C4HxW0Q4 sZ6m/KnI82L6PP+DsOuj+4qsTE1SRBrwwe3JjjUpxaMuCo34S6C50sDK X-Gm-Gg: ATEYQzzMMxuNozfgV5i72iSVr10t7gYfVyqCQhHIu8fcJgrtjCVIt+gurtNRQm8XBzD 2V96LQ79cxGYobdm0tUy7VaPpx6TcAQOIniY3qvdQuBu5llbBCFJSvkdYkJLOg5byrKzbAHsLtx OfL2JDESO89INqciNqp15HIlp+DrVdgf7yL/w5/VQl8AIxf0xatoL0RicCgnMUy/xG6krsroz/d gp6lLXzILjgorixzbzq2YMY5pbcXJhgMrYjUh9YUJIznss7IjjsiQYufID1JhHQzZWgFbPCuhV+ YaQ1BY1LEFaRlV2mKvLdFEtyUSzAdHP4XBq7X+B2OZDCC6WM6Ct0TzscQBtPtGJInKg+KYIXSwp V6ORfOeNOOIvAaLam7ps4v5okZ3Bs2xJ9Hg76xQu9tDYeEfom01h13hLn1OKjH6xM4V1m8N/m0r 9zVFtC3vxjJPXmCOfvGn4/4wn+BK1aVd7wy8NjOLTdzPF4kB5w4DJ8Z8ySoGbxHWmYm1T8vwWPn Oc= X-Received: by 2002:a05:600c:c163:b0:485:3abe:ab86 with SMTP id 5b1f17b1804b1-486f441b801mr96617235e9.4.1773874353167; Wed, 18 Mar 2026 15:52:33 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8c35057sm21162135e9.5.2026.03.18.15.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 15:52:32 -0700 (PDT) Date: Wed, 18 Mar 2026 22:52:31 +0000 From: David Laight To: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Cc: Willy Tarreau , Daniel Palmer , linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/nolibc: fix libc-test with musl libc Message-ID: <20260318225231.00b2f462@pumpkin> In-Reply-To: <20260318-nolibc-tests-musl-v1-1-884cd7f48646@weissschuh.net> References: <20260318-nolibc-tests-musl-v1-1-884cd7f48646@weissschuh.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 18 Mar 2026 18:20:46 +0100 Thomas Wei=C3=9Fschuh wrote: > Some of the nolibc testcases fail on musl. In these cases nolibc mirrors > the non-standard behavior of glibc. >=20 > Avoid the failures by only running these testcases on nolibc itself. >=20 > Fixes: a5f00be9b3b0 ("tools/nolibc: Add a simple test for writing to a FI= LE and reading it back") > Fixes: d94393e48c09 ("tools/nolibc/printf: Add support for length modifie= rs tzqL and formats iX") > Fixes: c2d234d3dc56 ("tools/nolibc/printf: Special case 0 and add support= for %#x") > Fixes: 63befd993da4 ("tools/nolibc/printf: Add support for zero padding a= nd field precision") > Fixes: d94393e48c09 ("tools/nolibc/printf: Add support for length modifie= rs tzqL and formats iX") > Signed-off-by: Thomas Wei=C3=9Fschuh > --- > I am thinking about folding the printf fixups directly into the original > patches. Any objections? > --- > tools/testing/selftests/nolibc/nolibc-test.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing= /selftests/nolibc/nolibc-test.c > index 180611aabbfb..b03fb9aeb54e 100644 > --- a/tools/testing/selftests/nolibc/nolibc-test.c > +++ b/tools/testing/selftests/nolibc/nolibc-test.c > @@ -867,7 +867,7 @@ int test_file_stream(void) > =20 > errno =3D 0; > r =3D fwrite("foo", 1, 3, f); > - if (r !=3D 0 || errno !=3D EBADF) { > + if (r !=3D 0 || (is_nolibc && errno !=3D EBADF)) { > fclose(f); > return -1; > } > @@ -1824,13 +1824,13 @@ static int run_printf(int min, int max) > CASE_TEST(hex_alt_prec); EXPECT_VFPRINTF(1, "| 0x02|0x03| 0x123|", "|%= #5.2x|%#04x|%#6.2x|", 2, 3, 0x123); break; > CASE_TEST(hex_0_alt); EXPECT_VFPRINTF(1, "|0|0000| 00|", "|%#x|%#= 04x|%#5.2x|", 0, 0, 0); break; > CASE_TEST(pointer); EXPECT_VFPRINTF(1, "0x1", "%p", (void *) 0x1)= ; break; > - CASE_TEST(pointer_NULL); EXPECT_VFPRINTF(1, "|(nil)|(nil)|", "|%p|%.4p= |", (void *)0, (void *)0); break; > - CASE_TEST(string_NULL); EXPECT_VFPRINTF(1, "|(null)||(null)|", "|%s|%= .5s|%.6s|", (void *)0, (void *)0, (void *)0); break; > + CASE_TEST(pointer_NULL); EXPECT_VFPRINTF(is_nolibc, "|(nil)|(nil)|", "= |%p|%.4p|", (void *)0, (void *)0); break; > + CASE_TEST(string_NULL); EXPECT_VFPRINTF(is_nolibc, "|(null)||(null)|"= , "|%s|%.5s|%.6s|", (void *)0, (void *)0, (void *)0); break; > CASE_TEST(percent); EXPECT_VFPRINTF(1, "a%d42%69%", "a%%d%d%%%d%%= ", 42, 69); break; > - CASE_TEST(perc_qual); EXPECT_VFPRINTF(1, "a%d2", "a%-14l%d%d", 2); = break; > - CASE_TEST(invalid); EXPECT_VFPRINTF(1, "a%12yx3%y42%P", "a%12yx%d= %y%d%P", 3, 42); break; > + CASE_TEST(perc_qual); EXPECT_VFPRINTF(is_nolibc, "a%d2", "a%-14l%d%= d", 2); break; > + CASE_TEST(invalid); EXPECT_VFPRINTF(is_nolibc, "a%12yx3%y42%P", "= a%12yx%d%y%d%P", 3, 42); break; > CASE_TEST(intmax_max); EXPECT_VFPRINTF(1, "9223372036854775807", "%l= ld", ~0ULL >> 1); break; > - CASE_TEST(intmax_min); EXPECT_VFPRINTF(1, "-9223372036854775808", "%= Li", (~0ULL >> 1) + 1); break; > + CASE_TEST(intmax_min); EXPECT_VFPRINTF(is_nolibc, "-9223372036854775= 808", "%Li", (~0ULL >> 1) + 1); break; > CASE_TEST(uintmax_max); EXPECT_VFPRINTF(1, "18446744073709551615", "%= ju", ~0ULL); break; > CASE_TEST(truncation); EXPECT_VFPRINTF(1, "0123456789012345678901234= 56789", "%s", "012345678901234567890123456789"); break; > CASE_TEST(string_width); EXPECT_VFPRINTF(1, " 1", "%10s", "1")= ; break; Hmmm.... Those are deliberately matching glibc behaviour, at least annotating that might be useful. Can you think of a way of detecting whether glibc is being used? Even !is_musl might be better than is_nolibc - even even they are the same. I'm guessing musl doesn't support 'L' as a length modifier for integers ? (I'm pretty sure that comes from M$.) The intmax_min test could use %qi instead since that is checking the value = as well. Another test for %Li could be added, I just mixed the formats up a bit. David=20 >=20 > --- > base-commit: d59131de97ee69ab4e4b8926089a6e953d699b11 > change-id: 20260318-nolibc-tests-musl-61c46f82fbec >=20 > Best regards,