From: Greg KH <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: Oskar Ray-Frayssinet <rayfraytech@gmail.com>,
dtwlin@gmail.com, elder@kernel.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: replace DEFINE_IDR with DEFINE_XARRAY_ALLOC in uart.c
Date: Wed, 18 Mar 2026 15:51:06 +0100 [thread overview]
Message-ID: <2026031843-decent-harness-bb3d@gregkh> (raw)
In-Reply-To: <abq4U39uvJYSfdv7@hovoldconsulting.com>
On Wed, Mar 18, 2026 at 03:36:03PM +0100, Johan Hovold wrote:
> On Wed, Mar 18, 2026 at 03:20:20PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 17, 2026 at 10:16:51PM +0100, Oskar Ray-Frayssinet wrote:
> > > Replace deprecated DEFINE_IDR and idr_* functions with the modern
> > > DEFINE_XARRAY_ALLOC and xa_* equivalents in the greybus uart driver.
> >
> > What tool is causing people to want to do this change that I keep
> > rejecting? Can you please go and fix it?
>
> It's checkpatch:
>
> WARNING: Deprecated use of 'DEFINE_IDR', prefer 'DEFINE_XARRAY' instead
> #70: FILE: drivers/staging/greybus/uart.c:70:
> +static DEFINE_IDR(tty_minors);
Ugh, that should be changed to only trigger that warning on a patch, not
on an existing file.
thanks,
greg k-h
prev parent reply other threads:[~2026-03-18 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 21:16 [PATCH] staging: greybus: replace DEFINE_IDR with DEFINE_XARRAY_ALLOC in uart.c Oskar Ray-Frayssinet
2026-03-18 7:45 ` Johan Hovold
2026-03-18 14:20 ` Greg KH
2026-03-18 14:36 ` Johan Hovold
2026-03-18 14:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031843-decent-harness-bb3d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rayfraytech@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox