From: Yixun Lan <dlan@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Ze Huang <huang.ze@linux.dev>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Emil Renner Berthing <kernel@esmil.dk>,
Junzhong Pan <junzhong.pan@spacemit.com>,
Inochi Amaoto <inochiama@gmail.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: usb: dwc3: spacemit: add support for K3 SoC
Date: Thu, 19 Mar 2026 10:41:24 +0800 [thread overview]
Message-ID: <20260319024124-GKB489299@kernel.org> (raw)
In-Reply-To: <20260318-crock-tinderbox-ae12024627d9@spud>
Hi Conor,
On 17:21 Wed 18 Mar , Conor Dooley wrote:
> On Wed, Mar 18, 2026 at 05:44:35AM +0800, Yixun Lan wrote:
> > Hi Conor,
> >
> > On 12:55 Tue 17 Mar , Conor Dooley wrote:
> > > On Tue, Mar 17, 2026 at 11:53:02AM +0000, Yixun Lan wrote:
> > > > Add compatible string for DWC3 USB controller found in SpacemiT K3 SoC.
> > > > The USB2.0 host controller in K3 SoC actually use DWC3 IP but only has
> > > > USB2.0 functionality, and requires only one USB2.0 PHY connected.
> > > >
> > > > Explicitly reduce number of phy property to minimal one.
> > >
> > > Is this valid for the existing compatible, will it work with only one
> > > clock?
> > >
> > I didn't change clock binding, do you mean phy?
> >
> > Both k1 and k3 work with one clock (no change here)
> >
> > for phy, the existing k1 requires two. for k3, one controller requires
> > one phy due to only has USB2.0 support, other controllers requires two
> > phys - USB2, USB3 PHY
>
> Yep, phy is what I meant. Sorry bout that. Since you're relaxing the
> constraints for the k1, can you please add a conditional section to the
> binding to enforce 2 phys min for k1?
>
To be explicit, the change should be applied to both K1 and K3, even in K1
use case, it's perfectly fine for designer to choose enabling USB2.0
only, and leave the comb phy to pcie contoller, so only one phy required
While revisiting the DT file, the phy related property should be moved
to board level, but this is another thing we should fix..
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-03-19 2:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 11:53 [PATCH 0/3] usb: spacemit: k3: Add USB2.0 support Yixun Lan
2026-03-17 11:53 ` [PATCH 1/3] dt-bindings: usb: dwc3: spacemit: add support for K3 SoC Yixun Lan
2026-03-17 12:55 ` Conor Dooley
2026-03-17 21:44 ` Yixun Lan
2026-03-18 17:21 ` Conor Dooley
2026-03-19 2:41 ` Yixun Lan [this message]
2026-03-19 14:36 ` Conor Dooley
2026-03-20 6:52 ` Yixun Lan
2026-03-17 11:53 ` [PATCH 2/3] usb: dwc3: dwc3-generic-plat: " Yixun Lan
2026-03-18 1:24 ` Thinh Nguyen
2026-03-17 11:53 ` [PATCH 3/3] riscv: dts: spacemit: k3: Add USB2.0 support Yixun Lan
2026-03-18 9:01 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319024124-GKB489299@kernel.org \
--to=dlan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=huang.ze@linux.dev \
--cc=inochiama@gmail.com \
--cc=junzhong.pan@spacemit.com \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox