From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 284E32248B3; Thu, 19 Mar 2026 06:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773900514; cv=none; b=BvfmF9/uvwZy9rLTXfQ0GjEjDEI8xgUozqt5NQ6BG6rZXkjJZyDZRQiOUqrzaqtHt7+7VXQS8ktprQUntttKpNz24wM9xeJFfewcQAxiyHk8PQwsMNrmHP+zJxZZKiuyE5GHevrmzKeCCcF+94pwAQhxmebWqjHWkKIookX47zQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773900514; c=relaxed/simple; bh=sjVMLUwpS3c+gFUKAFN/d5MgZTX7s+jQwrgjDxItyYw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=euXQDF9UPagwUKD0vxtdXo9vnkABPwuJBmoWt6PmTCrZxuP7/Ocjiu86afu4SkvS5Rt2ZJ3bqNkwNLN6/v+Yc64RrewWLOI4nwDCMew1ee0uTTuAhFKTzj26p2PkO/Ji63HVjoyQNWReGa4uzG9G2+UNemybB9oZHQPq2kTVTW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LcwKhVK/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LcwKhVK/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10CD5C19425; Thu, 19 Mar 2026 06:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773900513; bh=sjVMLUwpS3c+gFUKAFN/d5MgZTX7s+jQwrgjDxItyYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LcwKhVK/cE1gFcETdBWq81JQ5GhOynD1mWjQMGatQfSpjPUZUo1zI5Wv50bqed60B VFFNgV2qTwXFYJ07nHehWBwdNiZ3aSn8jr66uXbEDGkq/GrVSt1+UCp8RA62k0cJLM js+F5nIwWQwo7Uv9N2VvStcftmGns0RIZgjE0KnM= Date: Thu, 19 Mar 2026 07:08:23 +0100 From: Greg KH To: Sudarshan Srinivasan Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: media: av7110: coding style fixes: too many tabs Message-ID: <2026031905-resubmit-germicide-8b87@gregkh> References: <20260316152340.238100-1-ss22.kern.dev@gmail.com> <20260318193233.110451-1-ss22.kern.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318193233.110451-1-ss22.kern.dev@gmail.com> On Thu, Mar 19, 2026 at 01:02:29AM +0530, Sudarshan Srinivasan wrote: > This patch fixes below warning reported by checkpatch.pl > WARNING: Too many leading tabs - consider code refactoring > > Signed-off-by: Sudarshan Srinivasan > --- > drivers/staging/media/av7110/av7110.c | 33 +++++++++++++++++++-------- > 1 file changed, 23 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c > index 607992100baf..15460ca026dc 100644 > --- a/drivers/staging/media/av7110/av7110.c > +++ b/drivers/staging/media/av7110/av7110.c > @@ -932,6 +932,28 @@ static int dvb_feed_stop_pid(struct dvb_demux_feed *dvbdmxfeed) > return ret; > } > > +static int handle_ts_memory_fe(struct dvb_demux_feed *feed, > + struct dvb_demux *demux, > + struct av7110 *av7110) > +{ > + int ret = 0; > + > + if (feed->pes_type >= 2) > + return 0; > + > + if ((demux->pids[0] & 0x8000) || (demux->pids[1] & 0x8000)) > + return 0; > + > + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout); > + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout); > + > + ret = av7110_av_start_play(av7110, RP_AV); > + if (!ret) > + demux->playing = true; > + > + return ret; > +} > + > static int av7110_start_feed(struct dvb_demux_feed *feed) > { > struct dvb_demux *demux = feed->demux; > @@ -951,16 +973,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed) > (feed->pes_type <= DMX_PES_PCR)) { > switch (demux->dmx.frontend->source) { > case DMX_MEMORY_FE: > - if (feed->ts_type & TS_DECODER) > - if (feed->pes_type < 2 && > - !(demux->pids[0] & 0x8000) && > - !(demux->pids[1] & 0x8000)) { > - dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout); > - dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout); > - ret = av7110_av_start_play(av7110, RP_AV); > - if (!ret) > - demux->playing = 1; > - } > + ret = handle_ts_memory_fe(feed, demux, av7110); > break; > default: > ret = dvb_feed_start_pid(feed); > -- > 2.43.0 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot