From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5224A36B07B for ; Thu, 19 Mar 2026 09:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773912037; cv=none; b=Y6zsLn0uY6eEa+YR7YC6ZrnzwGzj04wY6fqMrWRpOt8IerX+jJ7uF3cwEsR61HHW//bW3ZhmZ6KbZyBRuBCcTO2ibhwZ8Pd58gO08C+vI+BIA2z4Nr0T9Ee2/dEIBxO20aeRUjCJQmUIhvoZbeYI8nhJvWkgZ/6zlXa4T7M866o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773912037; c=relaxed/simple; bh=csqh72pvbW7YY7R3XIOvJh756MwexbW99uIjvevHg2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C5RbrmqMOMhQEt6kalU4zMPeQ98zQSjcFwSja2c6REBMVU39k/UX618xxUZal7nIJ52+Ljjks8FbQcGVMzZN/+r4awOrZl7/q4LuRtK7UI6PCEsVN3Avfr4b6RGgJ+XN40O2FQ0m9/FWvabhUOyHxZ7kz9cO0mPtClJR6eArXF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=TiWfSva5; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TiWfSva5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=csqh72pvbW7YY7R3XIOvJh756MwexbW99uIjvevHg2k=; b=TiWfSva5uDTMk/pGj7zo4Ackp6 4KJzEUZgMGfgM2hcFu/AG/YmkrfQXEd5bqrMqkNPZ/I8mZhcZ95Kgr6ub4g7H7Iv4GBQLadyHrMvg keLmBh9bGtf3s75A9MsmEshwo9cMqhtepZ2JLeptSnXzSUBpVgz/uT1HtOjarON+q+TN+FeKr6jJq 079CIkCBXPvXbWyBYX0ZruSVsW/EtxAJ9TLDcGaN67v1U0KGVlMjzNbRLgEyTzSwie9GCC1geZHLe Q5Y8aFuF5qoCwsfLEo/6zRzRSGC0otmnk72enbY8WktidDvkc0beZUnffIo6GqKGXtMCqPHEWZMLj PLOK/wMA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1w39YM-00000005rgk-3J1W; Thu, 19 Mar 2026 09:20:31 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 47BDF301BD5; Thu, 19 Mar 2026 10:20:30 +0100 (CET) Date: Thu, 19 Mar 2026 10:20:30 +0100 From: Peter Zijlstra To: Shrikanth Hegde Cc: mingo@kernel.org, vincent.guittot@linaro.org, linux-kernel@vger.kernel.org, kprateek.nayak@amd.com, juri.lelli@redhat.com, vschneid@redhat.com, tglx@linutronix.de, dietmar.eggemann@arm.com, frederic@kernel.org, longman@redhat.com Subject: Re: [PATCH 2/2] sched/fair: get this cpu once in find_new_ilb Message-ID: <20260319092030.GU3738010@noisy.programming.kicks-ass.net> References: <20260319065314.343932-1-sshegde@linux.ibm.com> <20260319065314.343932-3-sshegde@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319065314.343932-3-sshegde@linux.ibm.com> On Thu, Mar 19, 2026 at 12:23:14PM +0530, Shrikanth Hegde wrote: > smp_processor_id() is pointless to fetch in the loop. Move it out. > No functional change. Isn't this what compilers are for?