From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A333BE17A for ; Thu, 19 Mar 2026 10:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773915859; cv=none; b=lvSTV9mI4SFH+4TDHJRxIUgea/kal4i1nzdY0iMXRY/KB2rD1Bw3VsYQ2vandc02TcpAMQQJ1bKRYAP44iyU6VzOnLWI7nJoDSFl0JPvpIHKZIa57vcNi6a+XhbQwxTWxhNHvnYlZqCAuYJo1wakfrtARZdSbmY87grVI7axhaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773915859; c=relaxed/simple; bh=UFI4rilMGhjmMJ785QgAEdxo2YKj8CV8LEYRubft/BA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G2ZuUnRnuSC0WznXU2OgP4sxKqnTHLWQy9qZ9D5NJw/5sYy5sfYK/G4+MoiN0cMpfDZvo+7bp6i+5RnYQCVdI4QfXfTpKb8w23D4y3tnPnTaAkJy0GxkcDF8cKE6Vi0sbA7d3PcbdHZZ1bNIiwWpwq5TyoZuQlZAMXxOMwb83I0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BpYBU0Cb; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BpYBU0Cb" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so7532495e9.0 for ; Thu, 19 Mar 2026 03:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773915856; x=1774520656; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wivFKoN2d2a1K2MBBGxKs8DzGhGNy/SrH65IzZ0YMuA=; b=BpYBU0CbUSd9svXy7QS3qkDgVsju4hIUtBk4K4DlB1hlgjOq1JTEhW3JEHR8yptWqD Sbycos9TD5uJqtU6pNkWhcrDJp17KVovODAnWbl7s0WPQdflHmq/PwLGXJM9TMTIRhAm ttfUxJuOtpaja05oe1mDg/FpRkxgGdvEmp/coYboSUXy4MTv3Ffv2bE+slAbX1p9HHKL ACp2L/JxT90WjlbXUt2VAXszZ8PecSOyk4yf/Qs/Kc327oVn9B0DjBkLOziZDWnOozKr gJKrLJu5PpCyg1CDJW25xoG+HGJdgh7v5FTMeybPKG72AGUUWwwJAgD0RpCLHHhptMkz 2X4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773915856; x=1774520656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wivFKoN2d2a1K2MBBGxKs8DzGhGNy/SrH65IzZ0YMuA=; b=GiSnApg+HQrtAZCg4A73/e+mw6th8oD7McfSAzjdBBztpO+mUKfBJMR8VSH1zleToz 29AEJxL6dhtfCQVHlyDmcvL6BZyJ/oIxE7hHZJMptvYdx730/Q1MqBwEC1trXfZ0ASAF ihzJqx+S/tD9iSd3IPyH+wOHDKQaObdyaCWYLK4YPptgKecBxQAXUOgl7qkxY9BEumkz it7OnVaE5OPlT4zMnWiS+I01uNiKosutHB2424YvC4UP+Sv2v8iEZxvxtg93gjQoHcIR KfU9emdoIGJ6JsZ/68ZGQHpWWP5TO1KGHQPfHIr1sCx3HhCCfWGHjVgct52vnM9HAywz k0EA== X-Forwarded-Encrypted: i=1; AJvYcCVmrh/DptynaCTegVoVqoUFBMPcBe53hhqyBkIuP5amLt+3DcCKhbvv1uNJBtThbyzdCNOAAtEuNAZUsN0=@vger.kernel.org X-Gm-Message-State: AOJu0YwSCgj6o5G0dCTASa1HFy7MYXkmpSPAv1snA5NI+38GdP8YkO/n i2ODoP9a7AiILW8oUWLlAXvHDBeWsrqIC4l1MqKwFVXCmn5syu7AbZPBuoNAWNXr X-Gm-Gg: ATEYQzy+MjnGR4ktgofdwIdHReSEqalpAFeGfKM/qNOZaooc/3s4U06C8edLre2jtUx F2yKEB/C8x23nsPn3v6Uz5foLcElIKneZOQJt0xEgZbwzlGir1ZFH20Uy6xSQ4sZhNVCIi7yRmp Rt4OD4BRkF36wPsY/oa5fQesCXpASgMRy0ifeWk+o2Ypm6Z9DUUVMimBTrgTx8Dgb2T5w5LFog5 YO2TJNP/vArTg66bvTeKvepyXBqiqllpwRgIWeHBdL00v/ItmJnZ6mXflN9bUQjmEXsXqTS5sB6 xTXreOyCsI5rn+8at86ZcRYr5GahZjWJ1yih8cDB1EFteQahF1v6lr8Dkhz/NRXHA0qOkSmEUyB F9RXaAm53MoA7v/JB77OqlCfEam12IX4LDCQVOWCLVlsyi3LtRlhFZoCS2myiO4fqh/QKlhCn5W damwIOwni1I8Q/OJNGQE2E95HkimseMFqajiZxKZ/IycZFfGvKQCufJ+EaS1lkJRCj X-Received: by 2002:a05:600c:1f96:b0:477:7af8:c8ad with SMTP id 5b1f17b1804b1-486f44606efmr107471975e9.31.1773915855485; Thu, 19 Mar 2026 03:24:15 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8b1fe65sm54933495e9.5.2026.03.19.03.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 03:24:15 -0700 (PDT) Date: Thu, 19 Mar 2026 10:24:14 +0000 From: David Laight To: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Cc: Willy Tarreau , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] tools/nolibc: avoid -Wundef warning for __STDC_VERSION__ Message-ID: <20260319102414.4c44de3f@pumpkin> In-Reply-To: <20260318-nolibc-wundef-v1-1-fcb7f9ac7298@weissschuh.net> References: <20260318-nolibc-wundef-v1-0-fcb7f9ac7298@weissschuh.net> <20260318-nolibc-wundef-v1-1-fcb7f9ac7298@weissschuh.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 18 Mar 2026 17:12:42 +0100 Thomas Wei=C3=9Fschuh wrote: > With -std=3Dc89 the macro __STDC_VERSION__ is not defined. > While undefined identifiers in '#if' directives are assumed to be '0', > with -Wundef a warning is emitted. >=20 > Avoid the warning by explicitly falling back to '0' if __STDC_VERSION__ > is not provided by the preprocessor. >=20 > Fixes: 37219aa5b123 ("tools/nolibc: add __nolibc_static_assert()") > Signed-off-by: Thomas Wei=C3=9Fschuh > --- > tools/include/nolibc/compiler.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/tools/include/nolibc/compiler.h b/tools/include/nolibc/compi= ler.h > index f03f84cfadce..dac09badff0a 100644 > --- a/tools/include/nolibc/compiler.h > +++ b/tools/include/nolibc/compiler.h > @@ -47,6 +47,12 @@ > # define __nolibc_fallthrough do { } while (0) > #endif /* __nolibc_has_attribute(fallthrough) */ > =20 > +#ifdef __STDC_VERSION__ > +# define __nolibc_stdc_version __STDC_VERSION__ > +#else > +# define __nolibc_stdc_version 0 > +#endif How about: #ifndef __STDC_VERSION__ #define __STDC_VERSION__ 198900 #endif David > + > #define __nolibc_version(_major, _minor, _patch) ((_major) * 10000 + (_m= inor) * 100 + (_patch)) > =20 > #ifdef __GNUC__ > @@ -63,7 +69,7 @@ > # define __nolibc_clang_version 0 > #endif /* __clang__ */ > =20 > -#if __STDC_VERSION__ >=3D 201112L || \ > +#if __nolibc_stdc_version >=3D 201112L || \ > __nolibc_gnuc_version >=3D __nolibc_version(4, 6, 0) || \ > __nolibc_clang_version >=3D __nolibc_version(3, 0, 0) > # define __nolibc_static_assert(_t) _Static_assert(_t, "") >=20