From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55D903C3C01 for ; Thu, 19 Mar 2026 10:52:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773917532; cv=none; b=VE60s31cFOf2i8wTeRZ02yPY69swmP+4NN5mNB1L+EYEOL9eZB4aOGPzgg33xqzR9XUpjE2LFD1yJB3EB8DC4SvR1rWvfYO2sTBGINMvnVC2Nc3KaQx5txLz4Bg5j+LgoGgaO9QWIMoneTZPapLDuFHVmSW3whf2QGKmq8EST6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773917532; c=relaxed/simple; bh=wLuH2pq/2Q9Zojp+Zwjhgo3H2A5slcb1aaeX21qnUeQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=si/S7w0qZQisFhTYT+GL6WDbUTuX0qwC4hncnYoUvxUpx+pTLC3UtyAOvz2p22ZSsojnnRioIK6IOa38v+UNknl/IqgDrz3szVRTOEaSgkjG7NsGDlgRBBJUNg2iG2XiF/xYVysd/3dvgm8fH6YIH1rG75Fm5NmNVeDOfrIMafY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MXuM0zQL; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MXuM0zQL" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-486fd5360d4so1491545e9.1 for ; Thu, 19 Mar 2026 03:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773917530; x=1774522330; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kX0116/SPsy0Sk5GOK1fUZKS2yOHaPMo+qoSwMIHErg=; b=MXuM0zQLQ3O/YkHnI6tsdHKrdKQ8Jc9+lQVB2f3TVbh3m1yiR0uWnJTmnvKos+LqS6 CBh68C8f6Y1pSXjFE/3IQZfUutqJqekFu0RU87SQnM+WewAMUTpEp/SRCbJIEQj2SZbU GLrYWIQ96cJhminNoOouNXZ+Fx0HiJo6EdCKEP24cc2ZMN4hoJpzj64pi80BMkJS7H2F RK9GCCRHPSBRfuN0/0h6s0GViBYK7+tqHZab7zFf+PUOYY6qF38bNp02iKsLP0cfTxYn eNd9/QyZ1ekQmpzRwLNimlTeKFQJluv++WVZdVK4KQt6eLk7iEstQKyBOycSXjxdq6is qVDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773917530; x=1774522330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kX0116/SPsy0Sk5GOK1fUZKS2yOHaPMo+qoSwMIHErg=; b=qMf0/ODpOfY3CbBIextgIuVaC+worVatOV2HsKO8Ngd5RPYCoLlG0jwDdHVSHNoouK Jcn9zyXUvFrWVWMS1UD3ToeApTt9iQbAhz4CkKqX/8/wqP6j4ZTE+WrjFldWb9/vsrEF pd1MhpZIGYchFai9bhb1MjtMshurIYtOFVpPs7rstgqgzvNrdx4VriHlBChMND926Bf+ qJTQtVLoAZGAwUYBI+VloO2S4rJYjcYvRDG9gmVrBToCATjn79R4139AUMreWAFfcN6R U5Q6S0RfDkrVZjKhKnzx77X45SX7URpfB2RWaGkI0P4OGWx66rmhgLzsf7s/Kttdm7Xa RGlA== X-Forwarded-Encrypted: i=1; AJvYcCUQGlhbhFP9I+K7Sss0Qxx3rEGnM7qEtPDqU2tXOPbOk6WYHTdwEK33Ioq2YIvxBt2zlALKv9rRZ/zTxNE=@vger.kernel.org X-Gm-Message-State: AOJu0YwvGEzCQJcV1F2QMetmEtHjvefy/cckDjAgb3FSHTXSGQz3DWJk HO8SgbT0qB5xE5PdFgxPT46zwyj913LjlyD0Zw7EEz/sRcJxjGX+Lit1 X-Gm-Gg: ATEYQzxVVS+NCOGnDukcZkM5uUGGgX93swyooxsHauWTnmbcrxcINol7BceLnVkX+RV 4c8XseacWcP8GbQ8oVXhPLt5fp4WJ/FjqTAy6DEdYPdgPlBGBmvFiWfZQYAeymmrRBEZ5q4xDQm R5uTW1rvhnCblerzHhb5esBncoxULMXP1+kdOt2EBoT34bqJHh+7lLhTi+w0pHDJZ9c9H3aiOcp ksQnMi9TVflzp8Qm5CulVJ3eIU+Yy0UGjJoGEhHlE91pdIkFpXvJQ5M4VL6MfFo9MhyvU0jmAHV cvyc6qCy2kmrziiANDd4wedgm+t9Wxr2fy0zu7/6ts3QtDw3fc+Lk5d/rm3RMIVjq5b/+IIKqCQ UVBxalJbhd/uCzcZP1rrXEEnu1oc87bbp8b7zcHEGPQFs/yGs+dukFkW9QvCVGDOZtwUxb44H1x IMe2Rir4UltcSm6Tei9yMU65j++lomNox62CFeje8uINyldEdHzdKPGiK19dDZ41QMLfHh7TGD7 HM= X-Received: by 2002:a05:600c:a21b:b0:485:3812:36dc with SMTP id 5b1f17b1804b1-486f443d5afmr71748615e9.9.1773917529478; Thu, 19 Mar 2026 03:52:09 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51851e43sm15576634f8f.10.2026.03.19.03.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 03:52:09 -0700 (PDT) Date: Thu, 19 Mar 2026 10:52:07 +0000 From: David Laight To: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Cc: Willy Tarreau , Daniel Palmer , linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/nolibc: fix libc-test with musl libc Message-ID: <20260319105207.07b66eea@pumpkin> In-Reply-To: <20260318225231.00b2f462@pumpkin> References: <20260318-nolibc-tests-musl-v1-1-884cd7f48646@weissschuh.net> <20260318225231.00b2f462@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 18 Mar 2026 22:52:31 +0000 David Laight wrote: > On Wed, 18 Mar 2026 18:20:46 +0100 > Thomas Wei=C3=9Fschuh wrote: >=20 > > Some of the nolibc testcases fail on musl. In these cases nolibc mirrors > > the non-standard behavior of glibc. > >=20 > > Avoid the failures by only running these testcases on nolibc itself. > >=20 > > Fixes: a5f00be9b3b0 ("tools/nolibc: Add a simple test for writing to a = FILE and reading it back") > > Fixes: d94393e48c09 ("tools/nolibc/printf: Add support for length modif= iers tzqL and formats iX") > > Fixes: c2d234d3dc56 ("tools/nolibc/printf: Special case 0 and add suppo= rt for %#x") > > Fixes: 63befd993da4 ("tools/nolibc/printf: Add support for zero padding= and field precision") > > Fixes: d94393e48c09 ("tools/nolibc/printf: Add support for length modif= iers tzqL and formats iX") > > Signed-off-by: Thomas Wei=C3=9Fschuh > > --- > > I am thinking about folding the printf fixups directly into the original > > patches. Any objections? > > --- > > tools/testing/selftests/nolibc/nolibc-test.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > >=20 > > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testi= ng/selftests/nolibc/nolibc-test.c > > index 180611aabbfb..b03fb9aeb54e 100644 > > --- a/tools/testing/selftests/nolibc/nolibc-test.c > > +++ b/tools/testing/selftests/nolibc/nolibc-test.c > > @@ -867,7 +867,7 @@ int test_file_stream(void) > > =20 > > errno =3D 0; > > r =3D fwrite("foo", 1, 3, f); > > - if (r !=3D 0 || errno !=3D EBADF) { > > + if (r !=3D 0 || (is_nolibc && errno !=3D EBADF)) { > > fclose(f); > > return -1; > > } > > @@ -1824,13 +1824,13 @@ static int run_printf(int min, int max) > > CASE_TEST(hex_alt_prec); EXPECT_VFPRINTF(1, "| 0x02|0x03| 0x123|", "= |%#5.2x|%#04x|%#6.2x|", 2, 3, 0x123); break; > > CASE_TEST(hex_0_alt); EXPECT_VFPRINTF(1, "|0|0000| 00|", "|%#x|= %#04x|%#5.2x|", 0, 0, 0); break; > > CASE_TEST(pointer); EXPECT_VFPRINTF(1, "0x1", "%p", (void *) 0x= 1); break; > > - CASE_TEST(pointer_NULL); EXPECT_VFPRINTF(1, "|(nil)|(nil)|", "|%p|%.= 4p|", (void *)0, (void *)0); break; > > - CASE_TEST(string_NULL); EXPECT_VFPRINTF(1, "|(null)||(null)|", "|%s= |%.5s|%.6s|", (void *)0, (void *)0, (void *)0); break; > > + CASE_TEST(pointer_NULL); EXPECT_VFPRINTF(is_nolibc, "|(nil)|(nil)|",= "|%p|%.4p|", (void *)0, (void *)0); break; > > + CASE_TEST(string_NULL); EXPECT_VFPRINTF(is_nolibc, "|(null)||(null)= |", "|%s|%.5s|%.6s|", (void *)0, (void *)0, (void *)0); break; > > CASE_TEST(percent); EXPECT_VFPRINTF(1, "a%d42%69%", "a%%d%d%%%d= %%", 42, 69); break; > > - CASE_TEST(perc_qual); EXPECT_VFPRINTF(1, "a%d2", "a%-14l%d%d", 2)= ; break; > > - CASE_TEST(invalid); EXPECT_VFPRINTF(1, "a%12yx3%y42%P", "a%12yx= %d%y%d%P", 3, 42); break; > > + CASE_TEST(perc_qual); EXPECT_VFPRINTF(is_nolibc, "a%d2", "a%-14l%= d%d", 2); break; > > + CASE_TEST(invalid); EXPECT_VFPRINTF(is_nolibc, "a%12yx3%y42%P",= "a%12yx%d%y%d%P", 3, 42); break; > > CASE_TEST(intmax_max); EXPECT_VFPRINTF(1, "9223372036854775807", "= %lld", ~0ULL >> 1); break; > > - CASE_TEST(intmax_min); EXPECT_VFPRINTF(1, "-9223372036854775808", = "%Li", (~0ULL >> 1) + 1); break; > > + CASE_TEST(intmax_min); EXPECT_VFPRINTF(is_nolibc, "-92233720368547= 75808", "%Li", (~0ULL >> 1) + 1); break; > > CASE_TEST(uintmax_max); EXPECT_VFPRINTF(1, "18446744073709551615", = "%ju", ~0ULL); break; > > CASE_TEST(truncation); EXPECT_VFPRINTF(1, "01234567890123456789012= 3456789", "%s", "012345678901234567890123456789"); break; > > CASE_TEST(string_width); EXPECT_VFPRINTF(1, " 1", "%10s", "1= "); break; =20 >=20 > Hmmm.... > Those are deliberately matching glibc behaviour, at least annotating that > might be useful. > Can you think of a way of detecting whether glibc is being used? > Even !is_musl might be better than is_nolibc - even even they are the sam= e. Thinking more, the nil/null tests want is_nolibc || is_glibc. Setting is_glibc might be hard (unless done from the command line). The musl people think you don't need to know because their library is confo= rmant. I found something from someone trying to detect pthread_setname_np(), glibc's features.h will set __USE_GNU (and similar) that musl doesn't set. There might also be issues with bionic and uClibc. David >=20 > I'm guessing musl doesn't support 'L' as a length modifier for integers ? > (I'm pretty sure that comes from M$.) > The intmax_min test could use %qi instead since that is checking the valu= e as well. > Another test for %Li could be added, I just mixed the formats up a bit. >=20 > David=20 >=20 >=20 > >=20 > > --- > > base-commit: d59131de97ee69ab4e4b8926089a6e953d699b11 > > change-id: 20260318-nolibc-tests-musl-61c46f82fbec > >=20 > > Best regards, =20 >=20 >=20