From: Kees Cook <kees@kernel.org>
To: Kamal Dasu <kamal.dasu@broadcom.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
William Zhang <william.zhang@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] mmc: core: Add MMC pstore backend driver
Date: Thu, 19 Mar 2026 13:59:06 -0700 [thread overview]
Message-ID: <202603191358.1895CEC26@keescook> (raw)
In-Reply-To: <20260319185705.1516950-5-kamal.dasu@broadcom.com>
On Thu, Mar 19, 2026 at 02:57:05PM -0400, Kamal Dasu wrote:
> Add mmcpstore, a pstore backend driver that provides persistent storage
> for kernel crash logs and other pstore data on eMMC devices. The driver
> registers with the pstore_blk framework and performs direct MMC writes
> during kernel panic using the panic-context host operations.
I'm glad to see another pstore_zone user! I can't speak to the MMC bits,
but the interface to pstore looks correct to me on a first pass
examination.
Thanks for picking this up again!
--
Kees Cook
next prev parent reply other threads:[~2026-03-19 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 18:57 [PATCH v3 0/4] mmc: Add pstore backend for crash dump storage on eMMC Kamal Dasu
2026-03-19 18:57 ` [PATCH v3 1/4] mmc: core: Add panic-context host operations for pstore backends Kamal Dasu
2026-03-19 18:57 ` [PATCH v3 2/4] mmc: sdhci: Implement panic-context write support Kamal Dasu
2026-03-20 3:40 ` kernel test robot
2026-03-20 16:22 ` kernel test robot
2026-03-19 18:57 ` [PATCH v3 3/4] mmc: block: Add helper to look up mmc_card by device name Kamal Dasu
2026-03-19 18:57 ` [PATCH v3 4/4] mmc: core: Add MMC pstore backend driver Kamal Dasu
2026-03-19 20:59 ` Kees Cook [this message]
2026-03-20 15:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603191358.1895CEC26@keescook \
--to=kees@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gpiccoli@igalia.com \
--cc=kamal.dasu@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox