From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CCD139184A for ; Thu, 19 Mar 2026 18:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773945668; cv=none; b=Cbzhn3RFs7GCmuMa4xYuwx29ddgPgl7y7ZZN7eyBbbSXpEOgJGQwTdqYqrJg5QYsSBLyKbRIpHieBenrBQXJH3oLCmBNHcpekZ88uPT94N4sjNJF8NK3M9xQSEG4q0dqVg77vbixiRlCyhivzeBETaT90qIlM6XDOmT3ZST+PzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773945668; c=relaxed/simple; bh=hiOcvAOZU+Go06U22CYBuOeWPiu1hvx3VQOdDsDJoTM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pSYMXTOuvZuTtcmUqRnoGVU1TQNGvyZeVA4mrdHZ1HeYCl6jFNTDX3LWDBYDxUV/Ni6Cysr1sbLaIG5NmYfDWk1pclbsNRI3BPlvPLg/9ilRJnB6dEu9YVW3fIOkGVpYaoJHhEOwJ+FZWysJlMrdqexPWCIW9AeWKJxILljC21s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DUAa+f7l; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DUAa+f7l" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7d74dbfe84cso862322a34.1 for ; Thu, 19 Mar 2026 11:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773945664; x=1774550464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UkL9G5F8IWfaZsPq/S8Wu6RBCXk3sjjW1IZ7vLbDtek=; b=DUAa+f7lUrgii1rf/txCsDqGBxksbLKo6kV6ocZyPcvyvEGW/8V0WQTbXmHBvwwIfI wb/trbi+NvL2gb2khq8onZ195Ie4BuhLqhajJmKhcUeSHqM59mB0V31AA2XgCzWMDHCm oh3TAKFtzwqY83kRH7ddptk0JaWh/oi+tzKcm4T86wtRuEFVrmKK4c8j9M8vT3MHLfX4 4hZsx+/3aqtm718AKzyHWoLxRaUuq0tWbqvQg3u8LyNLLBGqheHnSkuvEemQlyjuiL3z +ebWQ/IXwh9m9oZSfJQ0JvPnVTbCqW085i0HIYuZLlMKlCwI0n8CX849SyC4K6n0vWkV SmTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773945664; x=1774550464; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UkL9G5F8IWfaZsPq/S8Wu6RBCXk3sjjW1IZ7vLbDtek=; b=SWboxa9Siz2MCtQ4iGvo+Csh48A0DY3z53zm51exijgCc+LVVnPcbuLtBxN6MO3gqu K2qgWqSGJvaq5vU9TQjIxyGQM189B3P6cWBVq31m6ernF3GuZUzckgfAi1CwHFNyFLRu oSyyNiOhSw7bAl28eI6oW7QxNBCYAOs1A5E0rB9msHL18ckOtGLT1kbSt+BudjgW4IOR tMBHX21CUNt2uXbRncuznpx9Mc+Jv1atqROwbr0NSY2/R3JHJMegJ9ETdyGoyhnuPG9a xo7NbFneFazxw4mmJxSMdTwoh/5w5R5fO9QPSwjhr5P+b8lWzXpMimYzMf0C0dZZeg8H yKnA== X-Forwarded-Encrypted: i=1; AJvYcCXjixC9CVCXsjjOFZM74sPPFJgER/4EerBxjWO2dql3Q0s120IB/L0O0+9GGo1ZXskUyk9BZ+V9L9eYmbs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4WOmoP934QfBKV3vgL+qfGNdymB5HSZVd/LOMykqgZOegJRYq 5Mmwg5gNtjw5Aau/90hwRdjmH04hGOLIBXcY8Z2BKRoH8DfyXMYWqa3j X-Gm-Gg: ATEYQzxHJHGaDKpwzCxNZDEGbKS/Q0Kt6V5C5DvwXV8/s8L9PYw+ahPCj40KzPoF8Wy f+HH6uV0LoNxmicalcIFLmz9kYXGgth51CK/lx3mW07u0PZDoKD4jjFJbRNNdWr+i8/y63fxM3F 8ij9/kfl5qBn91lCNJYhCpzYITDdU8PCROy6X9XsOIF0A1X5dTVbJkki9z0012/zxbeIF6ec6Qf mp7QNCPSnoQL82DnmIvKBLp1wzglQ66fF2EGVt6pBYRczeL56mjC+9JYuqwmX2rQQ8KreIQ0FhV p3xp7PQxmwovkwICsV09yTgcPivjO2CrMRzwfSfNglhdpRKwmwjAmVHlvKu/j+w7XLuj4tOQm38 sTJzKH2l4ebzkBoRBCklxWQtSZfTZIrXbIqF/4QD9lAWCld5m4IXtAQbZa8ZVaftB7zTY2ADTIW kEE1VpVCxEmk5b5AsQWZpNxgHKzwHsRmLt61/CupGj7raisetXtLWsocJ0Q2pyaTn7ks5NiyqbE pH4c+4S8bI= X-Received: by 2002:a05:6830:3e07:b0:7d7:e8f4:4800 with SMTP id 46e09a7af769-7d7eae7e608mr222164a34.9.1773945664407; Thu, 19 Mar 2026 11:41:04 -0700 (PDT) Received: from celestia.turtle.lan (static-23-234-115-121.cust.tzulo.com. [23.234.115.121]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d7eadcb757sm181486a34.15.2026.03.19.11.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 11:41:04 -0700 (PDT) From: Sam Edwards X-Google-Original-From: Sam Edwards To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Russell King , Maxime Chevallier , Ovidiu Panait , Vladimir Oltean , Baruch Siach , Serge Semin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sam Edwards Subject: [PATCH net v2 0/2] stmmac crash/stall fixes when under memory pressure Date: Thu, 19 Mar 2026 11:40:29 -0700 Message-ID: <20260319184031.8596-1-CFSworks@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi netdev, This is v2 of my series containing a pair of bugfixes for the stmmac driver's receive pipeline. These issues occur when stmmac_rx_refill() does not (fully) succeed, which happens more frequently when free memory is low. The first patch closes Bugzilla bug #221010 [1], where stmmac_rx() can circle around to a still-dirty descriptor (with a NULL buffer pointer), mistake it for a filled descriptor (due to OWN=0), and attempt to dereference the buffer. In testing that patch, I discovered a second issue: starvation of available RX buffers causes the NIC to stop sending interrupts; if the driver stops polling, it will wait indefinitely for an interrupt that will never come. (Note: the first patch makes this issue more prominent -- mostly because it lets the system survive long enough to exhibit it -- but doesn't *cause* it.) The second patch addresses that problem as well. Both patches are minimal, appropriate for stable, and designated to `net`. Regards, Sam [1] https://bugzilla.kernel.org/show_bug.cgi?id=221010 v2: - Completely rewrote the commit message of patch 1, now assuming the reader is generally familiar with DMA but wholly unfamiliar with the stmmac device (thanks Jakub!) - Added missing `Fixes:` to patch 2 - Moved patch 2's `int budget = limit;` decl per the reverse-xmas-tree rule - Dropped patch 3: this was a code improvement not appropriate for stable - Generated the series with --subject-prefix='PATCH net' v1: https://lore.kernel.org/netdev/20260316021009.262358-1-CFSworks@gmail.com/ Sam Edwards (2): net: stmmac: Prevent NULL deref when RX memory exhausted net: stmmac: Prevent indefinite RX stall on buffer exhaustion drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) -- 2.52.0