Re: [PATCH 2/2] irqchip: Add Lightning Mountain irqchip support

[kernel test robot <lkp@intel.com>]

Hi Florian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on f338e77383789c0cae23ca3d48adcc5e9e137e3c]

url:    https://github.com/intel-lab-lkp/linux/commits/Florian-Eckert/dt-bindings-Add-Lightning-Mountain-MSI-interrupt-controller-bindings/20260319-033849
base:   f338e77383789c0cae23ca3d48adcc5e9e137e3c
patch link:    https://lore.kernel.org/r/20260318-irq-intel-soc-msi-v1-2-0e8cdf844fa8%40dev.tdt.de
patch subject: [PATCH 2/2] irqchip: Add Lightning Mountain irqchip support
config: um-allyesconfig (https://download.01.org/0day-ci/archive/20260319/202603191849.1i02oaur-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260319/202603191849.1i02oaur-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603191849.1i02oaur-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/irqchip/irq-intel-soc-msi.c: In function 'nmi_msi_compose_msg':
   drivers/irqchip/irq-intel-soc-msi.c:138:18: error: 'apic' undeclared (first use in this function)
     138 |         destid = apic->calc_dest_apicid(cpuid);
         |                  ^~~~
   drivers/irqchip/irq-intel-soc-msi.c:138:18: note: each undeclared identifier is reported only once for each function it appears in
   drivers/irqchip/irq-intel-soc-msi.c:141:25: error: 'arch_msi_msg_addr_lo_t' {aka 'struct arch_msi_msg_addr_lo'} has no member named 'base_address'
     141 |         msg.arch_addr_lo.base_address = X86_MSI_BASE_ADDRESS_LOW;
         |                         ^
   drivers/irqchip/irq-intel-soc-msi.c:141:41: error: 'X86_MSI_BASE_ADDRESS_LOW' undeclared (first use in this function)
     141 |         msg.arch_addr_lo.base_address = X86_MSI_BASE_ADDRESS_LOW;
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/irqchip/irq-intel-soc-msi.c:142:25: error: 'arch_msi_msg_addr_lo_t' {aka 'struct arch_msi_msg_addr_lo'} has no member named 'dest_mode_logical'
     142 |         msg.arch_addr_lo.dest_mode_logical = apic->dest_mode_logical;
         |                         ^
   drivers/irqchip/irq-intel-soc-msi.c:143:25: error: 'arch_msi_msg_addr_lo_t' {aka 'struct arch_msi_msg_addr_lo'} has no member named 'redirect_hint'
     143 |         msg.arch_addr_lo.redirect_hint = 0;
         |                         ^
   drivers/irqchip/irq-intel-soc-msi.c:144:25: error: 'arch_msi_msg_addr_lo_t' {aka 'struct arch_msi_msg_addr_lo'} has no member named 'destid_0_7'
     144 |         msg.arch_addr_lo.destid_0_7 = destid & 0xFF;
         |                         ^
   drivers/irqchip/irq-intel-soc-msi.c:146:26: error: 'X86_MSI_BASE_ADDRESS_HIGH' undeclared (first use in this function)
     146 |         msg.address_hi = X86_MSI_BASE_ADDRESS_HIGH;
         |                          ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/irqchip/irq-intel-soc-msi.c:152:22: error: 'arch_msi_msg_data_t' {aka 'struct arch_msi_msg_data'} has no member named 'is_level'
     152 |         msg.arch_data.is_level = 0;
         |                      ^
   drivers/irqchip/irq-intel-soc-msi.c:153:22: error: 'arch_msi_msg_data_t' {aka 'struct arch_msi_msg_data'} has no member named 'delivery_mode'
     153 |         msg.arch_data.delivery_mode = APIC_DELIVERY_MODE_NMI;
         |                      ^
   drivers/irqchip/irq-intel-soc-msi.c:153:39: error: 'APIC_DELIVERY_MODE_NMI' undeclared (first use in this function)
     153 |         msg.arch_data.delivery_mode = APIC_DELIVERY_MODE_NMI;
         |                                       ^~~~~~~~~~~~~~~~~~~~~~
   drivers/irqchip/irq-intel-soc-msi.c: In function 'soc_msi_compose_msg':
   drivers/irqchip/irq-intel-soc-msi.c:164:9: error: implicit declaration of function '__irq_msi_compose_msg'; did you mean 'nmi_msi_compose_msg'? [-Wimplicit-function-declaration]
     164 |         __irq_msi_compose_msg(irqd_cfg(data), msg, false);
         |         ^~~~~~~~~~~~~~~~~~~~~
         |         nmi_msi_compose_msg
   drivers/irqchip/irq-intel-soc-msi.c:164:31: error: implicit declaration of function 'irqd_cfg' [-Wimplicit-function-declaration]
     164 |         __irq_msi_compose_msg(irqd_cfg(data), msg, false);
         |                               ^~~~~~~~
   drivers/irqchip/irq-intel-soc-msi.c: In function 'soc_msi_domain_alloc':
   drivers/irqchip/irq-intel-soc-msi.c:198:31: error: storage size of 'info' isn't known
     198 |         struct irq_alloc_info info;
         |                               ^~~~
   drivers/irqchip/irq-intel-soc-msi.c:229:9: error: implicit declaration of function 'init_irq_alloc_info' [-Wimplicit-function-declaration]
     229 |         init_irq_alloc_info(&info, NULL);
         |         ^~~~~~~~~~~~~~~~~~~
>> drivers/irqchip/irq-intel-soc-msi.c:198:31: warning: unused variable 'info' [-Wunused-variable]
     198 |         struct irq_alloc_info info;
         |                               ^~~~
   drivers/irqchip/irq-intel-soc-msi.c: In function 'intel_soc_msi_probe':
   drivers/irqchip/irq-intel-soc-msi.c:304:46: error: 'x86_vector_domain' undeclared (first use in this function)
     304 |         domain = irq_domain_create_hierarchy(x86_vector_domain, 0,
         |                                              ^~~~~~~~~~~~~~~~~


vim +/info +198 drivers/irqchip/irq-intel-soc-msi.c

   192	
   193	static int soc_msi_domain_alloc(struct irq_domain *domain, unsigned int virq,
   194					unsigned int nr_irqs, void *arg)
   195	{
   196		struct msi_domain_info *msi_info = domain->host_data;
   197		struct irq_fwspec *fwspec = arg;
 > 198		struct irq_alloc_info info;
   199		irq_hw_number_t hwirq;
   200		unsigned int type;
   201		void *chip_data;
   202		int i, ret;
   203	
   204		if (!msi_info)
   205			return -EINVAL;
   206	
   207		chip_data = msi_info->chip_data;
   208	
   209		ret = soc_msi_domain_xlate(domain, fwspec, &hwirq, &type);
   210		if (ret)
   211			return ret;
   212	
   213		if (irq_find_mapping(domain, hwirq) > 0)
   214			return -EEXIST;
   215	
   216		/*
   217		 * All NMI interrupts go to vector 2, no irq mapping needed.
   218		 * What we want is to configure hardware once, don't do anything else.
   219		 * 0 means it will continue to initialize other stuff in the irqdomain.
   220		 * We can just return other value after hw initialized. In this case,
   221		 * irqdomain will release all resources.
   222		 */
   223		if (soc_nmi_msi(hwirq)) {
   224			nmi_msi_compose_msg((struct soc_msi_dev *)chip_data, hwirq);
   225			return -EINVAL;
   226		}
   227	
   228		/* Translate to X86 favorite arguments */
   229		init_irq_alloc_info(&info, NULL);
   230	
   231		/* Need to allocate from x86 vector domain */
   232		ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, &info);
   233		if (ret < 0)
   234			return ret;
   235	
   236		for (i = 0; i < nr_irqs; i++) {
   237			irq_domain_set_info(domain, virq + i, hwirq + i,
   238					    &soc_msi_irq_chip, chip_data,
   239					    handle_edge_irq, chip_data, "edge");
   240		}
   241	
   242		return 0;
   243	}
   244	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki