From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Craig McQueen <craig@mcqueen.au>,
linux-kernel@vger.kernel.org,
Michael Tretter <m.tretter@pengutronix.de>,
Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node
Date: Thu, 19 Mar 2026 19:02:44 +0000 [thread overview]
Message-ID: <20260319190244.GD2902881@google.com> (raw)
In-Reply-To: <abwYGm9zlnCECUkO@ashevche-desk.local>
On Thu, 19 Mar 2026, Andy Shevchenko wrote:
> On Thu, Mar 19, 2026 at 03:03:30PM +0000, Lee Jones wrote:
> > On Tue, 10 Mar 2026, Andy Shevchenko wrote:
> >
> > > Adjust documentation of brightness sysfs node about accepted value range.
> > > The code accepts only decimal values. We may not relax that due to different
> > > readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> > > 100.
>
> ...
>
> > > - The value is between 0 and
> > > + The decimal value is between 0 and
> >
> > How about?
> >
> > The value is between 0 and /sys/class/leds/<led>/max_brightness and is
> > represented by as a decimal.
>
> I tried to be less invasive, but I have no objection on this proposal. Can you
> update it whilst applying or should I send a new version?
New version please. I'm done for the day.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2026-03-19 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 16:51 [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node Andy Shevchenko
2026-03-19 15:03 ` Lee Jones
2026-03-19 15:36 ` Andy Shevchenko
2026-03-19 19:02 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319190244.GD2902881@google.com \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=craig@mcqueen.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox