[PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node

[PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node

[Andy Shevchenko]

Adjust documentation of brightness sysfs node about accepted value range.
The code accepts only decimal values. We may not relax that due to different
readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
100.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 Documentation/ABI/testing/sysfs-class-led | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-class-led b/Documentation/ABI/testing/sysfs-class-led
index 0313b82644f2..39ac8453e670 100644
--- a/Documentation/ABI/testing/sysfs-class-led
+++ b/Documentation/ABI/testing/sysfs-class-led
@@ -22,7 +22,7 @@ Description:
 		  For additional details please refer to
 		  Documentation/leds/leds-class-multicolor.rst.
 
-		The value is between 0 and
+		The decimal value is between 0 and
 		/sys/class/leds/<led>/max_brightness.
 
 		Writing 0 to this file clears active trigger.
-- 
2.50.1

Re: [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node

[Lee Jones]

On Tue, 10 Mar 2026, Andy Shevchenko wrote:

> Adjust documentation of brightness sysfs node about accepted value range.
> The code accepts only decimal values. We may not relax that due to different
> readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> 100.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  Documentation/ABI/testing/sysfs-class-led | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-class-led b/Documentation/ABI/testing/sysfs-class-led
> index 0313b82644f2..39ac8453e670 100644
> --- a/Documentation/ABI/testing/sysfs-class-led
> +++ b/Documentation/ABI/testing/sysfs-class-led
> @@ -22,7 +22,7 @@ Description:
>  		  For additional details please refer to
>  		  Documentation/leds/leds-class-multicolor.rst.
>  
> -		The value is between 0 and
> +		The decimal value is between 0 and

How about?

The value is between 0 and /sys/class/leds/<led>/max_brightness and is
represented by as a decimal.

>  		/sys/class/leds/<led>/max_brightness.
>  
>  		Writing 0 to this file clears active trigger.
> -- 
> 2.50.1
> 
> 

-- 
Lee Jones [李琼斯]

Re: [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node

[Andy Shevchenko]

On Thu, Mar 19, 2026 at 03:03:30PM +0000, Lee Jones wrote:
> On Tue, 10 Mar 2026, Andy Shevchenko wrote:
> 
> > Adjust documentation of brightness sysfs node about accepted value range.
> > The code accepts only decimal values. We may not relax that due to different
> > readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> > 100.

...

> > -		The value is between 0 and
> > +		The decimal value is between 0 and
> 
> How about?
> 
> The value is between 0 and /sys/class/leds/<led>/max_brightness and is
> represented by as a decimal.

I tried to be less invasive, but I have no objection on this proposal. Can you
update it whilst applying or should I send a new version?

> >  		/sys/class/leds/<led>/max_brightness.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node

[Lee Jones]

On Thu, 19 Mar 2026, Andy Shevchenko wrote:

> On Thu, Mar 19, 2026 at 03:03:30PM +0000, Lee Jones wrote:
> > On Tue, 10 Mar 2026, Andy Shevchenko wrote:
> > 
> > > Adjust documentation of brightness sysfs node about accepted value range.
> > > The code accepts only decimal values. We may not relax that due to different
> > > readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> > > 100.
> 
> ...
> 
> > > -		The value is between 0 and
> > > +		The decimal value is between 0 and
> > 
> > How about?
> > 
> > The value is between 0 and /sys/class/leds/<led>/max_brightness and is
> > represented by as a decimal.
> 
> I tried to be less invasive, but I have no objection on this proposal. Can you
> update it whilst applying or should I send a new version?

New version please.  I'm done for the day.

-- 
Lee Jones [李琼斯]