* [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node
@ 2026-03-10 16:51 Andy Shevchenko
2026-03-19 15:03 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2026-03-10 16:51 UTC (permalink / raw)
To: Craig McQueen, Andy Shevchenko, linux-kernel
Cc: Michael Tretter, Pavel Machek, linux-leds, Lee Jones
Adjust documentation of brightness sysfs node about accepted value range.
The code accepts only decimal values. We may not relax that due to different
readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
100.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Documentation/ABI/testing/sysfs-class-led | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/ABI/testing/sysfs-class-led b/Documentation/ABI/testing/sysfs-class-led
index 0313b82644f2..39ac8453e670 100644
--- a/Documentation/ABI/testing/sysfs-class-led
+++ b/Documentation/ABI/testing/sysfs-class-led
@@ -22,7 +22,7 @@ Description:
For additional details please refer to
Documentation/leds/leds-class-multicolor.rst.
- The value is between 0 and
+ The decimal value is between 0 and
/sys/class/leds/<led>/max_brightness.
Writing 0 to this file clears active trigger.
--
2.50.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node
2026-03-10 16:51 [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node Andy Shevchenko
@ 2026-03-19 15:03 ` Lee Jones
2026-03-19 15:36 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2026-03-19 15:03 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Craig McQueen, linux-kernel, Michael Tretter, Pavel Machek,
linux-leds
On Tue, 10 Mar 2026, Andy Shevchenko wrote:
> Adjust documentation of brightness sysfs node about accepted value range.
> The code accepts only decimal values. We may not relax that due to different
> readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> 100.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Documentation/ABI/testing/sysfs-class-led | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-led b/Documentation/ABI/testing/sysfs-class-led
> index 0313b82644f2..39ac8453e670 100644
> --- a/Documentation/ABI/testing/sysfs-class-led
> +++ b/Documentation/ABI/testing/sysfs-class-led
> @@ -22,7 +22,7 @@ Description:
> For additional details please refer to
> Documentation/leds/leds-class-multicolor.rst.
>
> - The value is between 0 and
> + The decimal value is between 0 and
How about?
The value is between 0 and /sys/class/leds/<led>/max_brightness and is
represented by as a decimal.
> /sys/class/leds/<led>/max_brightness.
>
> Writing 0 to this file clears active trigger.
> --
> 2.50.1
>
>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node
2026-03-19 15:03 ` Lee Jones
@ 2026-03-19 15:36 ` Andy Shevchenko
2026-03-19 19:02 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2026-03-19 15:36 UTC (permalink / raw)
To: Lee Jones
Cc: Craig McQueen, linux-kernel, Michael Tretter, Pavel Machek,
linux-leds
On Thu, Mar 19, 2026 at 03:03:30PM +0000, Lee Jones wrote:
> On Tue, 10 Mar 2026, Andy Shevchenko wrote:
>
> > Adjust documentation of brightness sysfs node about accepted value range.
> > The code accepts only decimal values. We may not relax that due to different
> > readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> > 100.
...
> > - The value is between 0 and
> > + The decimal value is between 0 and
>
> How about?
>
> The value is between 0 and /sys/class/leds/<led>/max_brightness and is
> represented by as a decimal.
I tried to be less invasive, but I have no objection on this proposal. Can you
update it whilst applying or should I send a new version?
> > /sys/class/leds/<led>/max_brightness.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node
2026-03-19 15:36 ` Andy Shevchenko
@ 2026-03-19 19:02 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2026-03-19 19:02 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Craig McQueen, linux-kernel, Michael Tretter, Pavel Machek,
linux-leds
On Thu, 19 Mar 2026, Andy Shevchenko wrote:
> On Thu, Mar 19, 2026 at 03:03:30PM +0000, Lee Jones wrote:
> > On Tue, 10 Mar 2026, Andy Shevchenko wrote:
> >
> > > Adjust documentation of brightness sysfs node about accepted value range.
> > > The code accepts only decimal values. We may not relax that due to different
> > > readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> > > 100.
>
> ...
>
> > > - The value is between 0 and
> > > + The decimal value is between 0 and
> >
> > How about?
> >
> > The value is between 0 and /sys/class/leds/<led>/max_brightness and is
> > represented by as a decimal.
>
> I tried to be less invasive, but I have no objection on this proposal. Can you
> update it whilst applying or should I send a new version?
New version please. I'm done for the day.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-19 19:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-10 16:51 [PATCH v1 1/1] leds: Adjust documentation of brightness sysfs node Andy Shevchenko
2026-03-19 15:03 ` Lee Jones
2026-03-19 15:36 ` Andy Shevchenko
2026-03-19 19:02 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox