From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EA89283FD4 for ; Fri, 20 Mar 2026 06:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773986977; cv=none; b=FTh/yfQ8tBw6YfH0VFL0cZJ3Ads7dYiO0ba84d9YN448fmz3L88MUq9nCEgJjMnHH9YRUWj5KFemScIgz4Yf7clZ8N0VxC8PMJrk0ZVU92g/Qjd/WlVC/vt18UW7fc08iP0gRt61vatFwa6vgEq4Gh/Zss08vjDUQIh4aPE51ZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773986977; c=relaxed/simple; bh=7gZTYvCYms6JLg4kbg3LMUFIljecloyM93oJfeULTjg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lEXpCByUBf1tc443d8DlJ2ih6tWBOGxRpFf/o25x8bh/g9YPnZVmvYGm7Z05I4Llcq+nIvjXsl9FOxg+Ztu3w8DQ3ftUihr1zx80O3LdBqFNsrChI0p5YbJlwZJOMFWKz5bgrxCfAY1H+bFSY6DCs8Z5X+L6GiG2xaiVyXGSs6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=mv9+d/VP; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="mv9+d/VP" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1773986974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YQcMr+CuWLq8RG6gUzwSk4dQyB0LcYdk73WHFDu273k=; b=mv9+d/VPBKfDjFilfhE2bHGIwTlmVmGbkIgFN/Cko7k8Xl3bn65yphgTHn2wmKf6ei+teN 3+nTV5Ry2i6xsSofmOLxzxGnYtDEfFSVV/w8UMpsU9VE7/oWJREOakoQDplur9X2xsMC4+ uxjSuJEsE2HXyTYvaLCTYclU/B3wZyo= From: sunliming@linux.dev To: song@kernel.org, yukuai@fnnas.com, akpm@linux-foundation.org Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, sunliming Subject: [PATCH RESEND v3 1/3] lib/raid6: Divide the raid6 algorithm selection process into two parts Date: Fri, 20 Mar 2026 14:07:48 +0800 Message-Id: <20260320060750.31334-2-sunliming@linux.dev> In-Reply-To: <20260320060750.31334-1-sunliming@linux.dev> References: <20260320060750.31334-1-sunliming@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: sunliming Divide the RAID6 algorithm selection process into two parts: fast selection and benchmark selection. To prepare for the asynchronous processing of the benchmark phase. Signed-off-by: sunliming --- lib/raid6/algos.c | 76 +++++++++++++++++++++++++++++++++-------------- 1 file changed, 54 insertions(+), 22 deletions(-) diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c index 799e0e5eac26..c21e3ad99d97 100644 --- a/lib/raid6/algos.c +++ b/lib/raid6/algos.c @@ -152,8 +152,32 @@ static inline const struct raid6_recov_calls *raid6_choose_recov(void) return best; } -static inline const struct raid6_calls *raid6_choose_gen( - void *(*const dptrs)[RAID6_TEST_DISKS], const int disks) +/* Quick selection: select the highest priority valid algorithm. */ +static inline int raid6_choose_gen_fast(void) +{ + int ret = 0; + const struct raid6_calls *const *algo; + const struct raid6_calls *best = NULL; + + for (best = NULL, algo = raid6_algos; *algo; algo++) + if (!best || (*algo)->priority > best->priority) + if (!(*algo)->valid || (*algo)->valid()) + best = *algo; + + if (best) { + raid6_call = *best; + pr_info("raid6: skipped pq benchmark and selected %s\n", + best->name); + } else { + pr_err("raid6: No valid algorithm found even for fast selection!\n"); + ret = -EINVAL; + } + + return ret; +} + +static inline const struct raid6_calls *raid6_gen_benchmark( + void *(*const dptrs)[RAID6_TEST_DISKS], const int disks) { unsigned long perf, bestgenperf, j0, j1; int start = (disks>>1)-1, stop = disks-3; /* work on the second half of the disks */ @@ -165,11 +189,6 @@ static inline const struct raid6_calls *raid6_choose_gen( if ((*algo)->valid && !(*algo)->valid()) continue; - if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) { - best = *algo; - break; - } - perf = 0; preempt_disable(); @@ -200,12 +219,6 @@ static inline const struct raid6_calls *raid6_choose_gen( raid6_call = *best; - if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) { - pr_info("raid6: skipped pq benchmark and selected %s\n", - best->name); - goto out; - } - pr_info("raid6: using algorithm %s gen() %ld MB/s\n", best->name, (bestgenperf * HZ * (disks - 2)) >> @@ -239,15 +252,13 @@ static inline const struct raid6_calls *raid6_choose_gen( /* Try to pick the best algorithm */ /* This code uses the gfmul table as convenient data set to abuse */ -int __init raid6_select_algo(void) +static int raid6_choose_gen_benmark(void) { const int disks = RAID6_TEST_DISKS; - const struct raid6_calls *gen_best; - const struct raid6_recov_calls *rec_best; char *disk_ptr, *p; void *dptrs[RAID6_TEST_DISKS]; - int i, cycle; + int i, cycle, ret = 0; /* prepare the buffer and fill it circularly with gfmul table */ disk_ptr = (char *)__get_free_pages(GFP_KERNEL, RAID6_TEST_DISKS_ORDER); @@ -269,15 +280,36 @@ int __init raid6_select_algo(void) if ((disks - 2) * PAGE_SIZE % 65536) memcpy(p, raid6_gfmul, (disks - 2) * PAGE_SIZE % 65536); - /* select raid gen_syndrome function */ - gen_best = raid6_choose_gen(&dptrs, disks); + gen_best = raid6_gen_benchmark(&dptrs, disks); + if (!gen_best) + ret = -EINVAL; + + free_pages((unsigned long)disk_ptr, RAID6_TEST_DISKS_ORDER); + + return ret; +} + +int __init raid6_select_algo(void) +{ + int ret = 0; + const struct raid6_recov_calls *rec_best = NULL; + + /* select raid gen_syndrome functions */ + if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) + ret = raid6_choose_gen_fast(); + else + ret = raid6_choose_gen_benmark(); + + if (ret < 0) + goto out; /* select raid recover functions */ rec_best = raid6_choose_recov(); + if (!rec_best) + ret = -EINVAL; - free_pages((unsigned long)disk_ptr, RAID6_TEST_DISKS_ORDER); - - return gen_best && rec_best ? 0 : -EINVAL; +out: + return ret; } static void raid6_exit(void) -- 2.25.1