From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF9433EAEA for ; Fri, 20 Mar 2026 07:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773992981; cv=none; b=cqhUC5dH0bND0wR+DgaADHGkY0uvGck8X7yRRylPXJwzSlDdgFnVEtfy/LI0p5l6NhWXbLbkKmwYyZJDkX+hwSeeQoo0YaEz/Db8kZAbvCyuH4LXuJCxrcOaocVjBWguni8Caeilhbol9wB3h9MCejSOZBnX2yort4rhuEqcjq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773992981; c=relaxed/simple; bh=GV7D7aLDAz+jr09SmDnQ6SyVHXGQs+r72j8/ONTXhJ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=beA1+vZZL+DRtG/4brEnA9XG1Xpk5L4HhFdL//Vo8BQ7g/ceW1CJfNbko7Jn3e+e/9t7aFzoljjorlqTnZ6w8TEzqUzpvFVudaHxAffnE9bgwWCL6dm7J9zsvD/y1EPVGe2oKS+IzoL4QqcACcnVw95IfVH1uVuEgNK60uDMDJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 2BDF76732A; Fri, 20 Mar 2026 08:49:36 +0100 (CET) Date: Fri, 20 Mar 2026 08:49:35 +0100 From: Christoph Hellwig To: yunje shin Cc: Christoph Hellwig , hare@suse.de, cleech@redhat.com, ioerts@kookmin.ac.kr, kbusch@kernel.org, kch@nvidia.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, sagi@grimberg.me, stable@kernel.org Subject: Re: [PATCH v2] nvmet: auth: validate dhchap id list lengths Message-ID: <20260320074935.GA14616@lst.de> References: <20260313052444.3865842-1-ioerts@kookmin.ac.kr> <20260317145137.GA6462@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Mar 18, 2026 at 01:55:13AM +0900, yunje shin wrote: > Regarding the local variable — I understand the readability concern, > but data->auth_protocol[0].dhchap is currently used without a local > variable in 8 places in target/fabrics-cmd-auth.c (lines 42-44, 71, > 75-76, 100-101) and 12 places in host/auth.c (lines 145-156). > Adding one only for the bounds check felt inconsistent, so I kept > the existing style. Happy to hear your thoughts on this. Bonus points for fixing all of them up :)