From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5047377024 for ; Fri, 20 Mar 2026 09:08:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773997685; cv=none; b=MrobYNdssKlPvARLPMnNWaGTREuZUeso/D28G46W4ww+/YECaSFOcvhzq7uPKIMsRrAYFs3WS9vv0vnoGBgxsZbsA05HXQ2wanGmqDdd0zVk3/nAQTk7eq4Znyh53b5uYRZTZSxodaGNINLDFhsx3mDzAYHBPlzrskxdXaltG5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773997685; c=relaxed/simple; bh=KYO02n5+SND8h//NBOdE6SaTW5YRuX0NO/blQ8cAYdo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vc4VqdynwEBrHgP4nsX1EupJV9q3J7Ws9PHL6nYCO9Zvb/0fWpsX7qXuM8HeCeowatZiqjWYGOy+MoTtexocHTuZOdIYkQZ9gtl94JVH5gB1zQJz5ahRMwQve3ervXNgIPaVDrqMyJzuUV1PjSfLklBhE24nA9k6vDtm65ZbEiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=sYonHIuz; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sYonHIuz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M0040fLFYC+VVsuifWMUfvKX8M0RdW6o05wD9uxFQ8Y=; b=sYonHIuzd6KXH+VSXiKKwg9b/6 ARJN5TPERFCk3HsLof7wd4DZEIQVlGfZ4sc+wmT8ue/H3dNjuaVIOruS/Kubgu1DNKCPvHqM36BK4 Yn9KS2wPDwi117RQx61aO4uNYc3TW6UsoiVgZTTLmXgmDJW2KshcXKj9zVtTTrpfnRDOvYN4pGzl2 yz8dAD/hl1rig2Y4s81FyUPxTi4+alfqvpXZsgSDTvVr+bRfL++BkuLAvXxcvFLDg2M/tgk1WnZzr ie1tWdZaefUWDAfHTeXHdAwe0aGuKIIZwZwq1f77Iz43+N3ZXR9yp5NWF0B8SpOV3b54KfyT5z3nP l6EiQ4WQ==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1w3Vpf-00000007Wa4-2dr2; Fri, 20 Mar 2026 09:07:51 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 2A714301150; Fri, 20 Mar 2026 10:07:51 +0100 (CET) Date: Fri, 20 Mar 2026 10:07:51 +0100 From: Peter Zijlstra To: Thomas Gleixner Cc: LKML , Mathieu Desnoyers , =?iso-8859-1?Q?Andr=E9?= Almeida , Sebastian Andrzej Siewior , Carlos O'Donell , Florian Weimer , Rich Felker , Torvald Riegel , Darren Hart , Ingo Molnar , Davidlohr Bueso , Arnd Bergmann , "Liam R . Howlett" , Uros Bizjak , Thomas =?iso-8859-1?Q?Wei=DFschuh?= Subject: Re: [patch v2 08/11] futex: Add robust futex unlock IP range Message-ID: <20260320090751.GO3738786@noisy.programming.kicks-ass.net> References: <20260319225224.853416463@kernel.org> <20260319231239.682582451@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319231239.682582451@kernel.org> On Fri, Mar 20, 2026 at 12:24:46AM +0100, Thomas Gleixner wrote: > /** > + * struct futex_unlock_cs_range - Range for the VDSO unlock critical section > + * @start_ip: The start IP of the robust futex unlock critical section (inclusive) > + * @end_ip: The end IP of the robust futex unlock critical section (exclusive) > + * @pop_size32: Pending OP pointer size indicator. 0 == 64-bit, 1 == 32-bit > + */ > +struct futex_unlock_cs_range { > + unsigned long start_ip; > + unsigned long end_ip; > + unsigned int pop_size32; > +}; > + > +#define FUTEX_ROBUST_MAX_CS_RANGES 2 Would it make sense to write that like: #define FUTEX_ROBUST_MAX_CS_RANGE (1+IS_ENABLED(CONFIG_COMPAT)) Given you only ever use that second entry when COMPAT?