From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C95C51CAA7D for ; Fri, 20 Mar 2026 09:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774000144; cv=none; b=iHdLTZgU85cG8EIP2jT3ApMYzX0ySdoRvRPhHgO5GLo4T3Y7UXqBZYk7RKqWHkxxqYdj5hytMu9va8L9Nur0V+zsenTNADdLcPRTG2cgG497xer7iLDHAbr1a8v5OsJhqlnBmVMCTJi8KM2ueOxrlyMEY5wfJ0vaCUzWsXlHn+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774000144; c=relaxed/simple; bh=QmW5pQ1PCCiFgRRb/lniA9vi0HWlZ/TLLcm2lJekOhU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F2VbKnmceu2oKmQKWoVE11dmhRj+e9Dcib7hxub2xWM78OtnOFdiCdnhFXObDo5at616JC9grG3R9Ione0ph59ysy4Is8CA0PRfsugO2BJjKdL2ElJLEb9WUmb15+2G4byk6GPW3tWKPo0LcHQphm3oNThNoQqMmajMbH+s/7HU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UAil8xNq; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UAil8xNq" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-486fe2024a9so2343825e9.0 for ; Fri, 20 Mar 2026 02:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774000141; x=1774604941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SDFF7892V8hdy4v9+ldpTBjbRxZV8VHqysT2kdnSqLA=; b=UAil8xNqd4KClNz15VxJ5fa2gsiPb921LAxY/3NPaPZ1J342t2GZz9r75A8uWjMtXI T/afkCNbGZtV/pkgRDtYSiNXIS+3jC4c7xqWlhsy9wLMUnqdk4PldLa04+YmuFCCMfNA uMz+o7383hxbLz2of1CheZS5hkP3RouraNvzgFdMYkDkIuzdlOkbtEpyZeNGTF3f/lcZ SEALyfb33ZSU/sdQHRkMgJD4SDBwoC+WUB6oZsWtYnz6XA1iFErAazzZDLCztifu3XD9 NkTCzlgvtVgsKtxpVtuPr5FiXIiS7h7AC2AhjN/jkY8yKNQ0SZTkLHovjdnq12mMKWdM 825w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774000141; x=1774604941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SDFF7892V8hdy4v9+ldpTBjbRxZV8VHqysT2kdnSqLA=; b=E8BUjsPeLsuLycJDoofbvdlJZu2UVbdNJCVqAGmDpqJ1hq82Goc+Pky55e+p7YeBkK enxmA/xMScUCObOZLSxxMbCRF8j36jDycOFPcmSnapzIEC2oSkSM2hbi4W+2B/3Wmev9 Sn6nJ0S+Tar+mXWU66B1fLobDlTrI6+Qusq8z/Mpboko0iPFKfzLrHAZmbKeZttOshmc vZURwh5lGOjo3qaebCn5Royndi/YcP1gaTL/5EOPZ5wLPsqHrtbnQrkBxdPYETDFcXIt nh1mli/fKWGBOQbIg4SPHz7PFQV3fqmfb/o99PWQEWW/LN8GtVs3ZnQHOc1ajkuKq8uk d0Dw== X-Forwarded-Encrypted: i=1; AJvYcCV5kbAy5a26FwZKVrF8Z2zOqj/RUd4nnb1R4OYdVwclpmkqCkaxjqG0nJBF4RZhmHP5qCsmpo3X2fiYvTw=@vger.kernel.org X-Gm-Message-State: AOJu0YyHsPDST6a5l0OwfXvyXIq9oO+CGgfLomqNXAquomY6+xUCYfKq os/wLD6cNQfQ8VRxQu4zhb/QZIpRY2A8ueTUuz7pZ4SWNl46xgxK0pop X-Gm-Gg: ATEYQzxmOi6QjzNA2zbJV012cNmkWMPOl9vSWT0FQcNXi5/sVg0VLHRDBCbi5pjg50Q cAWluhyse/1IJAf61gzOoW1kfOByZjMrUgrsL5dyGYwSUaDR15EhBy0Ogc6uPWwBTFJCpua2dtm KuFAnw99k53Tu15lEWvqzvcxAXzF139n5aEXAYza16T610LwTU836ymA2bY/ApNYKZRLs3/xp+C NFhSmHu9EFk+Q7B+2GAVBPiEL6BLL3qZZktIh1f1v/siyKkBg4BN0vu+o3Ivln6pcNHehrzMyrg b50CP5aDrRiLmciRVHGAA0E816QNy7eFYFyLcZHvyWbbVDrRXKiB2vGfHDpo5/fZ/OTtDjmkK+f sdVrrP1/zWPdGr1+zGLN+puBXdWBeVM7u5bHmvkk5RJ7U6NwTS2QMNA/hm6MsFTz/gT+mVs4SiW bbUBXcBTesQRzOc4d83z7bGQs69gb6JAcR3OzdQKm0x0rE2duCPs6CsM2E1Uj51IZL X-Received: by 2002:a05:600c:c84:b0:480:1c69:9d36 with SMTP id 5b1f17b1804b1-486fee0d808mr33085205e9.17.1774000140493; Fri, 20 Mar 2026 02:49:00 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe7e2665sm56567825e9.6.2026.03.20.02.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 02:48:59 -0700 (PDT) Date: Fri, 20 Mar 2026 09:48:58 +0000 From: David Laight To: "Masami Hiramatsu (Google)" Cc: Petr Mladek , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] lib/vsprintf: Fix to check field_width and precision Message-ID: <20260320094858.36979c73@pumpkin> In-Reply-To: <177397888866.33018.11400875989661138560.stgit@devnote2> References: <177397887883.33018.9867883986177366222.stgit@devnote2> <177397888866.33018.11400875989661138560.stgit@devnote2> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 20 Mar 2026 12:54:48 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Check the field_width and presition correctly. Previously it depends > on the bitfield conversion from int to check out-of-range error. > However, commit 938df695e98d ("vsprintf: associate the format state > with the format pointer") changed those fields to int. > We need to check the out-of-range correctly without bitfield > conversion. > > Fixes: 938df695e98d ("vsprintf: associate the format state with the format pointer") > Reported-by: David Laight > Closes: https://lore.kernel.org/all/20260318151250.40fef0ab@pumpkin/ > Signed-off-by: Masami Hiramatsu (Google) > --- > Changes in v2: > - Fix to use logical split. > --- > lib/vsprintf.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 800b8ac49f53..32a164e2adf4 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -2803,7 +2803,8 @@ static void > set_field_width(struct printf_spec *spec, int width) > { > spec->field_width = width; > - if (WARN_ONCE(spec->field_width != width, "field width %d too large", width)) { > + if (WARN_ONCE(spec->field_width > FIELD_WIDTH_MAX || spec->field_width < -FIELD_WIDTH_MAX, Check and update width before the assignment to spec->field_width. David > + "field width %d too large", width)) { > spec->field_width = clamp(width, -FIELD_WIDTH_MAX, FIELD_WIDTH_MAX); > } > } > @@ -2812,7 +2813,8 @@ static void > set_precision(struct printf_spec *spec, int prec) > { > spec->precision = prec; > - if (WARN_ONCE(spec->precision != prec, "precision %d too large", prec)) { > + if (WARN_ONCE(spec->precision > PRECISION_MAX || spec->precision < 0, > + "precision %d too large", prec)) { > spec->precision = clamp(prec, 0, PRECISION_MAX); > } > } >