From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66BA336E465 for ; Fri, 20 Mar 2026 10:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774001062; cv=none; b=W0EuJBmj/8W50cFFzuR3LDTLo3DBfd6I1SmBGjLM3yhJjOWdhRO9a1v5uF0Ha6tBvjIzPvINYJvfvoE83vBk+9/MN6invLp2mEZQaEL4kXdmmu/o5j5gvMvM7YXYBvxhlL4ggzz1XkGJ4wUJptTAdmHaP8maKAOYprSyFzKXIM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774001062; c=relaxed/simple; bh=XknTIXIOBfvE+KiKyn7087ICqtG3lMhDc3+hPbG6g5k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NrFHGBYzTEx/h39kRgP6tZJdlEMr7laHYw4006sR/I/XIAd5Mh4SAbSBM2lefXXYZWX1nPwNzXrxRf75I6yBYreqkxK93/fY7JwHdy8FCkJFANyuGTsJ3dySsIiJM7uBerYVQbgnAhwaZtcNcMlbaAsMNug0bftORuoO8PmIgGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g9U+GNEf; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g9U+GNEf" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439b9b190easo1346927f8f.2 for ; Fri, 20 Mar 2026 03:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774001060; x=1774605860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4hSkxfkKssqPBK4aVXeFh3DwtG/Y5oxjT1XZn9LucJA=; b=g9U+GNEfoveapSffFm5OIiYUmUEv6MdaYihECxePkEBfDDLftG9Wsx46XAe0WLH6WQ gVxPAnFztmccHNuvA+XL5CIGbkF029JLIgckH2nyz/dlCx+yXcjq3l01v9p2R9FKdQwo 3Rg+sWtgENh6AUdk7HM22JROseL3rA9wGbRQPSs9c6A6a0Mtt4LqkWQjoo4JhCrMHTDT QsWP730PMoFlAL92wS53YJna6dojbqTXCw7+msSklb2a7iKHiv/oXU167/5rRC/VyJU+ yumsTH3p4btNpl1Rq63p9SxQtpFxD0WXMdPe5nVTjNz5x23ZprR4qTsk2VQlMFSNbWuf E/5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774001060; x=1774605860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4hSkxfkKssqPBK4aVXeFh3DwtG/Y5oxjT1XZn9LucJA=; b=C3OUr4OO4p7/jwvwkIat6qEgqFgMN8FWrlWr5pBCmutzFnwo91hg/9ZjzY6ibyR/lQ hz+FK9af2GQOsVt/nvMuCPbLitsV/UFkLByUeTx4AsSXvjNkcnYJmj/yV+INkDh96L13 Pju3ydy50kDCn7J61W4eZPdFPp//U30vuD6vmEZrPK2pYN9qSGCDOMu+xhjytJ744t7z TW6ZPBChdnaF74xxm/mUNbof1liqNZ55G+DALi8xGpHUnstTq5KDtNOFfdQ9XkPwZMXV Gwqk7gOHLSQiIyWjOP65AQ8rxB1tPbg1qVpdY03jLKpEoJbneiTshjI65Wuj1XRcfHr2 jhQA== X-Forwarded-Encrypted: i=1; AJvYcCUf2ukSnxdr13VhHd5QFl7d2tgt76QRy5SqN4p1F39rl3WZNxz+EjVepDg/fa9UeBAc3FOk6r5/NIYOv9k=@vger.kernel.org X-Gm-Message-State: AOJu0Yyez0ZR4ENKU2dflTHZvcAT2HQgxIA7gjB/SkwfivMXq1ibhQvz jFgb9l1qRVQyOEESfgqp/1bUzIaUdkvcBPqY/MIeX0e9DeIs22xv+A9z X-Gm-Gg: ATEYQzzjI3wAzans878z58qBmdu03UGG2Nda1rOW8a7JFHsmtvSr3MYx7+gB7/5a3oI oB13BtHQPQP9CQaYI+nj1hEjD7j6LmfrOMPLd2532fg2BEL1Oowagq6KORXxlPjLcsdIdU+uUYr EE0tpBVmRuzHi1Z3jrXmKrSXqFU64Z1cc9dc7l5F5yleG4UE6P0bcZD6IVzJzbExt8PxuSAbnnt 3wLLBV8fF1VPdP2d4qDJiJ45gqR/MFxU6nPTixyM0fJBoxUt+5oPi7lbcCuK52GXrGF1ffxEsP3 3JbkZUOmENxe2feF+DySHZXpp1HDlm7vGfSvZbyKxtu2Mb0/jEmno+yZdUqL3aRlZmwgrQKsul+ /p2QvSKdVYn8hygKVflABnhNZDmsY+CPpa11AGbw4CDl52u9XWOjsgxDVpbvwSvtjAbcBIAp6x2 diss1GYOZEqHeKfBEjBzIEdlHUyuPt9EMdxL1zW3b2TqB0K+3wMP1+Gc5Eo+odOGEA52lYDbZMK ys= X-Received: by 2002:a5d:5f55:0:b0:43b:47c9:9b3c with SMTP id ffacd0b85a97d-43b642430d2mr3898838f8f.4.1774001058830; Fri, 20 Mar 2026 03:04:18 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644bf1c5sm5521171f8f.14.2026.03.20.03.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 03:04:18 -0700 (PDT) Date: Fri, 20 Mar 2026 10:04:17 +0000 From: David Laight To: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Cc: Willy Tarreau , Daniel Palmer , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/nolibc: fix libc-test with musl libc Message-ID: <20260320100417.61ecd50b@pumpkin> In-Reply-To: <20260320-nolibc-tests-musl-v2-1-5fa468b5ba64@weissschuh.net> References: <20260320-nolibc-tests-musl-v2-1-5fa468b5ba64@weissschuh.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 20 Mar 2026 08:00:46 +0100 Thomas Wei=C3=9Fschuh wrote: > Some of the nolibc testcases fail on musl. In these cases nolibc mirrors > the non-standard behavior of glibc. >=20 > Avoid the failures by only running these testcases on nolibc and glibc. >=20 > Fixes: a5f00be9b3b0 ("tools/nolibc: Add a simple test for writing to a FI= LE and reading it back") > Fixes: d94393e48c09 ("tools/nolibc/printf: Add support for length modifie= rs tzqL and formats iX") > Fixes: c2d234d3dc56 ("tools/nolibc/printf: Special case 0 and add support= for %#x") > Fixes: 63befd993da4 ("tools/nolibc/printf: Add support for zero padding a= nd field precision") > Fixes: d94393e48c09 ("tools/nolibc/printf: Add support for length modifie= rs tzqL and formats iX") > Signed-off-by: Thomas Wei=C3=9Fschuh > --- > Changes in v2: > - Also run the affected testcases on glibc. > - Link to v1: https://patch.msgid.link/20260318-nolibc-tests-musl-v1-1-88= 4cd7f48646@weissschuh.net > --- > I am thinking about folding the printf fixups directly into the original > patches. Any objections? > --- > tools/testing/selftests/nolibc/nolibc-test.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) >=20 > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing= /selftests/nolibc/nolibc-test.c > index 180611aabbfb..4b653172d570 100644 > --- a/tools/testing/selftests/nolibc/nolibc-test.c > +++ b/tools/testing/selftests/nolibc/nolibc-test.c > @@ -74,6 +74,14 @@ static const int is_nolibc =3D > #endif > ; > =20 > +static const int is_glibc =3D > +#ifdef __GLIBC__ > + 1 > +#else > + 0 > +#endif > +; > + > #if !defined(NOLIBC) > /* Some disabled tests may not compile. */ > =20 > @@ -867,7 +875,7 @@ int test_file_stream(void) > =20 > errno =3D 0; > r =3D fwrite("foo", 1, 3, f); > - if (r !=3D 0 || errno !=3D EBADF) { > + if (r !=3D 0 || ((is_nolibc || is_glibc) && errno !=3D EBADF)) { > fclose(f); > return -1; > } > @@ -1824,13 +1832,13 @@ static int run_printf(int min, int max) > CASE_TEST(hex_alt_prec); EXPECT_VFPRINTF(1, "| 0x02|0x03| 0x123|", "|%= #5.2x|%#04x|%#6.2x|", 2, 3, 0x123); break; > CASE_TEST(hex_0_alt); EXPECT_VFPRINTF(1, "|0|0000| 00|", "|%#x|%#= 04x|%#5.2x|", 0, 0, 0); break; > CASE_TEST(pointer); EXPECT_VFPRINTF(1, "0x1", "%p", (void *) 0x1)= ; break; > - CASE_TEST(pointer_NULL); EXPECT_VFPRINTF(1, "|(nil)|(nil)|", "|%p|%.4p= |", (void *)0, (void *)0); break; > - CASE_TEST(string_NULL); EXPECT_VFPRINTF(1, "|(null)||(null)|", "|%s|%= .5s|%.6s|", (void *)0, (void *)0, (void *)0); break; > + CASE_TEST(pointer_NULL); EXPECT_VFPRINTF(is_nolibc || is_glibc, "|(nil= )|(nil)|", "|%p|%.4p|", (void *)0, (void *)0); break; > + CASE_TEST(string_NULL); EXPECT_VFPRINTF(is_nolibc, "|(null)||(null)|"= , "|%s|%.5s|%.6s|", (void *)0, (void *)0, (void *)0); break; string_NULL should pass on glibc. > CASE_TEST(percent); EXPECT_VFPRINTF(1, "a%d42%69%", "a%%d%d%%%d%%= ", 42, 69); break; > - CASE_TEST(perc_qual); EXPECT_VFPRINTF(1, "a%d2", "a%-14l%d%d", 2); = break; > - CASE_TEST(invalid); EXPECT_VFPRINTF(1, "a%12yx3%y42%P", "a%12yx%d= %y%d%P", 3, 42); break; > + CASE_TEST(perc_qual); EXPECT_VFPRINTF(is_nolibc || is_glibc, "a%d2"= , "a%-14l%d%d", 2); break; > + CASE_TEST(invalid); EXPECT_VFPRINTF(is_nolibc || is_glibc, "a%12y= x3%y42%P", "a%12yx%d%y%d%P", 3, 42); break; > CASE_TEST(intmax_max); EXPECT_VFPRINTF(1, "9223372036854775807", "%l= ld", ~0ULL >> 1); break; > - CASE_TEST(intmax_min); EXPECT_VFPRINTF(1, "-9223372036854775808", "%= Li", (~0ULL >> 1) + 1); break; > + CASE_TEST(intmax_min); EXPECT_VFPRINTF(is_nolibc || is_glibc, "-9223= 372036854775808", "%Li", (~0ULL >> 1) + 1); break; > CASE_TEST(uintmax_max); EXPECT_VFPRINTF(1, "18446744073709551615", "%= ju", ~0ULL); break; > CASE_TEST(truncation); EXPECT_VFPRINTF(1, "0123456789012345678901234= 56789", "%s", "012345678901234567890123456789"); break; > CASE_TEST(string_width); EXPECT_VFPRINTF(1, " 1", "%10s", "1")= ; break; >=20 > --- > base-commit: d59131de97ee69ab4e4b8926089a6e953d699b11 > change-id: 20260318-nolibc-tests-musl-61c46f82fbec >=20 > Best regards,